test(732): cover the three clauses a cold review measured as having no red
Round 5 enumerated the guards independently and ran the full suite against each: `HaloBlur` and `LineHeight` in FitTextBlock's rebuilt style, and the per-style `HaloBlur` override in BuildTextStyles, could all be deleted with 2062 tests green. All three were added by the round-4 fix commit - the same commit that rewrote the mutation-coverage paragraph and warned that adding a guard without its row makes that paragraph false. It did exactly that, three times, in itself. The blanket claim is already gone. These three now have differential tests and measured rows, so they are covered rather than merely unclaimed. The existing halo rows were written at whole-block granularity, which is what hid the per-field gap: HaloColor and HaloWidth were reachable, HaloBlur was not. Also disclosed: the per-style halo fix and the Scale path now carrying line_height are operator-visible changes for custom templates, which belongs in the release notes rather than only in a commit message. And a comment on the schema still said an unset background_color means no box at all, which the border-only path and its own test contradict. Refs: #732
This commit is contained in:
@@ -98,7 +98,13 @@ Every one of these overrides the `base_style`'s value when the style declares it
|
||||
did not until #732, so before that a non-base style silently rendered the base style's halo. The
|
||||
seeded `on-now-next.yml` is unaffected because all three of its styles declare the same halo: its
|
||||
rendered bitmap is byte-identical either way (md5 `0663AF1E13C558F4DB99F887318E275D`, 1920x1080,
|
||||
measured 2026-08-26). A third-party template that varies halo per style will change, correctly.
|
||||
measured 2026-08-26).
|
||||
|
||||
**This is an operator-visible change and belongs in the release notes.** A custom template whose
|
||||
non-base style declares its own `halo_color` / `halo_width` / `halo_blur` renders differently after
|
||||
this version — correctly, but differently. So does one using `line_height` with `text_fit: Scale`:
|
||||
the Scale path now carries line height through, which changes measured height and therefore where the
|
||||
element anchors.
|
||||
Halo is drawn by RichTextKit as part of the text, not by the box code — a wide halo **on top of** a
|
||||
background box over-darkens the glyphs, which is why the seeded template cuts it to 1px.
|
||||
|
||||
|
||||
Reference in New Issue
Block a user