more bug reporting (#679)

ErsatzTV.Application/Filler/Commands/CreateFillerPresetHandler.cs

@@ -1,4 +1,5 @@
-using ErsatzTV.Core;
+using Bugsnag;
+using ErsatzTV.Core;
 using ErsatzTV.Core.Domain.Filler;
 using ErsatzTV.Infrastructure.Data;
 using Microsoft.EntityFrameworkCore;
@@ -7,10 +8,12 @@ namespace ErsatzTV.Application.Filler;
 
 public class CreateFillerPresetHandler : IRequestHandler<CreateFillerPreset, Either<BaseError, Unit>>
 {
+    private readonly IClient _client;
     private readonly IDbContextFactory<TvContext> _dbContextFactory;
 
-    public CreateFillerPresetHandler(IDbContextFactory<TvContext> dbContextFactory)
+    public CreateFillerPresetHandler(IClient client, IDbContextFactory<TvContext> dbContextFactory)
     {
+        _client = client;
         _dbContextFactory = dbContextFactory;
     }
 
@@ -18,7 +21,7 @@ public class CreateFillerPresetHandler : IRequestHandler<CreateFillerPreset, Eit
     {
         try
         {
-            await using TvContext dbContext = _dbContextFactory.CreateDbContext();
+            await using TvContext dbContext = await _dbContextFactory.CreateDbContextAsync(cancellationToken);
 
             var fillerPreset = new FillerPreset
             {
@@ -42,6 +45,7 @@ public class CreateFillerPresetHandler : IRequestHandler<CreateFillerPreset, Eit
         }
         catch (Exception ex)
         {
+            _client.Notify(ex);
             return BaseError.New(ex.Message);
         }
     }

ErsatzTV.Application/Playouts/Commands/BuildPlayoutHandler.cs

@@ -1,4 +1,5 @@
-using ErsatzTV.Core;
+using Bugsnag;
+using ErsatzTV.Core;
 using ErsatzTV.Core.Domain;
 using ErsatzTV.Core.Interfaces.Scheduling;
 using ErsatzTV.Infrastructure.Data;
@@ -9,26 +10,36 @@ namespace ErsatzTV.Application.Playouts;
 
 public class BuildPlayoutHandler : MediatR.IRequestHandler<BuildPlayout, Either<BaseError, Unit>>
 {
+    private readonly IClient _client;
     private readonly IDbContextFactory<TvContext> _dbContextFactory;
     private readonly IPlayoutBuilder _playoutBuilder;
 
-    public BuildPlayoutHandler(IDbContextFactory<TvContext> dbContextFactory, IPlayoutBuilder playoutBuilder)
+    public BuildPlayoutHandler(IClient client, IDbContextFactory<TvContext> dbContextFactory, IPlayoutBuilder playoutBuilder)
     {
+        _client = client;
         _dbContextFactory = dbContextFactory;
         _playoutBuilder = playoutBuilder;
     }
 
     public async Task<Either<BaseError, Unit>> Handle(BuildPlayout request, CancellationToken cancellationToken)
     {
-        await using TvContext dbContext = _dbContextFactory.CreateDbContext();
+        await using TvContext dbContext = await _dbContextFactory.CreateDbContextAsync(cancellationToken);
         Validation<BaseError, Playout> validation = await Validate(dbContext, request);
-        return await LanguageExtensions.Apply(validation, playout => ApplyUpdateRequest(dbContext, request, playout));
+        return await validation.Apply(playout => ApplyUpdateRequest(dbContext, request, playout));
     }
 
     private async Task<Unit> ApplyUpdateRequest(TvContext dbContext, BuildPlayout request, Playout playout)
+    {
+        try
         {
             await _playoutBuilder.BuildPlayoutItems(playout, request.Rebuild);
             await dbContext.SaveChangesAsync();
+        }
+        catch (Exception ex)
+        {
+            _client.Notify(ex);
+        }
+
         return Unit.Default;
     }
 

ErsatzTV.Application/Streaming/Queries/GetPlayoutItemProcessByChannelNumberHandler.cs

@@ -18,8 +18,7 @@ using Microsoft.EntityFrameworkCore;
 
 namespace ErsatzTV.Application.Streaming;
 
-public class GetPlayoutItemProcessByChannelNumberHandler :
+public class GetPlayoutItemProcessByChannelNumberHandler : FFmpegProcessHandler<GetPlayoutItemProcessByChannelNumber>
-    FFmpegProcessHandler<GetPlayoutItemProcessByChannelNumber>
 {
     private readonly IEmbyPathReplacementService _embyPathReplacementService;
     private readonly IMediaCollectionRepository _mediaCollectionRepository;
@@ -108,8 +107,7 @@ public class GetPlayoutItemProcessByChannelNumberHandler :
 
         IFFmpegProcessService ffmpegProcessService = await _ffmpegProcessServiceFactory.GetService();
 
-        return await maybePlayoutItem.Match(
+        foreach (PlayoutItemWithPath playoutItemWithPath in maybePlayoutItem.RightToSeq())
-            async playoutItemWithPath =>
         {
             MediaVersion version = playoutItemWithPath.PlayoutItem.MediaItem.GetHeadVersion();
 
@@ -162,8 +160,9 @@ public class GetPlayoutItemProcessByChannelNumberHandler :
             var result = new PlayoutItemProcessModel(process, playoutItemWithPath.PlayoutItem.FinishOffset);
 
             return Right<BaseError, PlayoutItemProcessModel>(result);
-            },
+        }
-            async error =>
+
+        foreach (BaseError error in maybePlayoutItem.LeftToSeq())
         {
             var offlineTranscodeMessage =
                 $"offline image is unavailable because transcoding is disabled in ffmpeg profile '{channel.FFmpegProfile.Name}'";
@@ -245,7 +244,9 @@ public class GetPlayoutItemProcessByChannelNumberHandler :
                         return BaseError.New(message);
                     }
             }
-            });
+        }
+
+        return BaseError.New($"Unexpected error locating playout item for channel {channel.Number}");
     }
 
     private async Task<Either<BaseError, PlayoutItemWithPath>> CheckForFallbackFiller(

ErsatzTV.Core.Tests/FFmpeg/TranscodingTests.cs

@@ -277,7 +277,7 @@ public class TranscodingTests
 
         var localStatisticsProvider = new LocalStatisticsProvider(
             metadataRepository.Object,
-            new LocalFileSystem(LoggerFactory.CreateLogger<LocalFileSystem>()),
+            new LocalFileSystem(new Mock<IClient>().Object, LoggerFactory.CreateLogger<LocalFileSystem>()),
             new Mock<IClient>().Object,
             LoggerFactory.CreateLogger<LocalStatisticsProvider>());
 

ErsatzTV.Core/Metadata/LocalFileSystem.cs

@@ -1,4 +1,5 @@
-using ErsatzTV.Core.Domain;
+using Bugsnag;
+using ErsatzTV.Core.Domain;
 using ErsatzTV.Core.Interfaces.Metadata;
 using Microsoft.Extensions.Logging;
 
@@ -6,10 +7,12 @@ namespace ErsatzTV.Core.Metadata;
 
 public class LocalFileSystem : ILocalFileSystem
 {
+    private readonly IClient _client;
     private readonly ILogger<LocalFileSystem> _logger;
 
-    public LocalFileSystem(ILogger<LocalFileSystem> logger)
+    public LocalFileSystem(IClient client, ILogger<LocalFileSystem> logger)
     {
+        _client = client;
         _logger = logger;
     }
 
@@ -44,9 +47,10 @@ public class LocalFileSystem : ILocalFileSystem
             {
                 return Directory.EnumerateDirectories(folder);
             }
-            catch
+            catch (Exception ex)
             {
                 // do nothing
+                _client.Notify(ex);
             }
         }
 
@@ -61,9 +65,10 @@ public class LocalFileSystem : ILocalFileSystem
             {
                 return Directory.EnumerateFiles(folder, "*", SearchOption.TopDirectoryOnly);
             }
-            catch
+            catch (Exception ex)
             {
                 // do nothing
+                _client.Notify(ex);
             }
         }
 
@@ -92,6 +97,7 @@ public class LocalFileSystem : ILocalFileSystem
         }
         catch (Exception ex)
         {
+            _client.Notify(ex);
             return BaseError.New(ex.ToString());
         }
     }

ErsatzTV.Core/Metadata/TelevisionFolderScanner.cs

@@ -18,6 +18,7 @@ public class TelevisionFolderScanner : LocalFolderScanner, ITelevisionFolderScan
     private readonly ILocalMetadataProvider _localMetadataProvider;
     private readonly ILogger<TelevisionFolderScanner> _logger;
     private readonly IMediator _mediator;
+    private readonly IClient _client;
     private readonly IMetadataRepository _metadataRepository;
     private readonly ISearchIndex _searchIndex;
     private readonly ISearchRepository _searchRepository;
@@ -57,6 +58,7 @@ public class TelevisionFolderScanner : LocalFolderScanner, ITelevisionFolderScan
         _searchRepository = searchRepository;
         _libraryRepository = libraryRepository;
         _mediator = mediator;
+        _client = client;
         _logger = logger;
     }
 
@@ -287,6 +289,7 @@ public class TelevisionFolderScanner : LocalFolderScanner, ITelevisionFolderScan
         }
         catch (Exception ex)
         {
+            _client.Notify(ex);
             return BaseError.New(ex.ToString());
         }
     }
@@ -348,6 +351,7 @@ public class TelevisionFolderScanner : LocalFolderScanner, ITelevisionFolderScan
         }
         catch (Exception ex)
         {
+            _client.Notify(ex);
             return BaseError.New(ex.ToString());
         }
     }
@@ -371,6 +375,7 @@ public class TelevisionFolderScanner : LocalFolderScanner, ITelevisionFolderScan
         }
         catch (Exception ex)
         {
+            _client.Notify(ex);
             return BaseError.New(ex.ToString());
         }
     }
@@ -390,6 +395,7 @@ public class TelevisionFolderScanner : LocalFolderScanner, ITelevisionFolderScan
         }
         catch (Exception ex)
         {
+            _client.Notify(ex);
             return BaseError.New(ex.ToString());
         }
     }
@@ -411,6 +417,7 @@ public class TelevisionFolderScanner : LocalFolderScanner, ITelevisionFolderScan
         }
         catch (Exception ex)
         {
+            _client.Notify(ex);
             return BaseError.New(ex.ToString());
         }
     }