From 54a0760fcd65e39db4cd636349456c61b4338189 Mon Sep 17 00:00:00 2001 From: Timothy Date: Mon, 6 Jul 2026 23:22:52 +0200 Subject: [PATCH] fix(web): Channel Builder review fixes (refs #89) - Dialog: focus only on open transition (was stealing focus from its own inputs every parent re-render); Escape listener via latest-ref - Advanced overrides: honest 'Inherit from template' semantics - the handler coalesces null with the template value so 'None' could never clear anything (clear-to-none follow-up: #135); save-as-template now composes from the same effective-value helper - toggle rows: label->div (label activation forwarding double-fired in real browsers); clear stale 422 row highlight on lineup mutations - port .ctv-lift/.ctv-press motion utilities + apply per prototype; Advanced expand scroll-into-view; Info glyph on advanced info line - fixture fidelity: real 'Validation failed' title, verbatim handler detail message, omit null keys, collectionKind on rerun fixture - cache successful artwork upload across create retries Co-Authored-By: Claude Fable 5 --- web/src/App.test.tsx | 37 ++-- web/src/builder/ChannelBuilder.tsx | 342 +++++++++++++++++++---------- web/src/components/overlay.tsx | 27 ++- web/src/shell.css | 43 +++- 4 files changed, 309 insertions(+), 140 deletions(-) diff --git a/web/src/App.test.tsx b/web/src/App.test.tsx index fdc48bc6f..84e7786d0 100644 --- a/web/src/App.test.tsx +++ b/web/src/App.test.tsx @@ -2203,7 +2203,7 @@ describe('ChicoryTV SPA scaffold', () => { ...builderDefaults(), browseItems: [ browseItem(), - browseItem({ id: 9, title: 'Saturday Block', mediaType: 'RerunCollection', collectionType: 'RerunFirstRun', rerunCollectionId: 9, mediaItemId: undefined }) + browseItem({ id: 9, title: 'Saturday Block', mediaType: 'RerunCollection', collectionType: 'RerunFirstRun', collectionKind: 'Rerun', rerunCollectionId: 9, mediaItemId: undefined }) ] }); @@ -2276,7 +2276,9 @@ describe('ChicoryTV SPA scaffold', () => { mockDashboardApi({ ...builderDefaults(), browseItems: [browseItem(), browseItem({ id: 2, mediaItemId: 2, title: 'Tom & Jerry' })], - fromLineupFailure: { detail: 'lineup[1] references a missing media item.', status: 422, title: 'Invalid lineup' } + // Verbatim wire shape: ApiResults hard-codes the 422 title "Validation failed", + // and the handler's not-found detail is "lineup[i]