style(742): ruff format the new tests with the CI-pinned version
Build ErsatzTV Image / CI toolchain image resolves (pull_request) Successful in 13s
Build ErsatzTV Image / Delimiter ban (release path) (pull_request) Successful in 26s
PR Gates / Fix proofs (Proves trailers) (pull_request) Successful in 15s
PR Gates / Docs update reminder (pull_request) Successful in 29s
PR Gates / CI image pin matches docker/ci (pull_request) Successful in 35s
PR Gates / decisions lifecycle (pull_request) Successful in 36s
Review verdict / Set review-verdict status (pull_request_target) Successful in 37s
PR Gates / Script lint and tests (ruff + pytest) (pull_request) Successful in 6m17s
Build ErsatzTV Image / Build & test (.NET) (pull_request) Successful in 8m47s
Build ErsatzTV Image / EF migration integrity (SQLite + MySql) (pull_request) Successful in 6m18s
Build ErsatzTV Image / Build & push image (amd64) (pull_request) Skipped
Build ErsatzTV Image / Functional E2E (curl + UI contracts) (pull_request) Successful in 6m1s
Build ErsatzTV Image / API docs in sync (OpenAPI + endpoint index) (pull_request) Successful in 7s
Build ErsatzTV Image / Formatting (changed .cs conform to .editorconfig) (pull_request) Successful in 5s
review-verdict/h10 Review-verdict: MERGEABLE @ 586577c (base: main)
Build ErsatzTV Image / CI toolchain image resolves (pull_request) Successful in 13s
Build ErsatzTV Image / Delimiter ban (release path) (pull_request) Successful in 26s
PR Gates / Fix proofs (Proves trailers) (pull_request) Successful in 15s
PR Gates / Docs update reminder (pull_request) Successful in 29s
PR Gates / CI image pin matches docker/ci (pull_request) Successful in 35s
PR Gates / decisions lifecycle (pull_request) Successful in 36s
Review verdict / Set review-verdict status (pull_request_target) Successful in 37s
PR Gates / Script lint and tests (ruff + pytest) (pull_request) Successful in 6m17s
Build ErsatzTV Image / Build & test (.NET) (pull_request) Successful in 8m47s
Build ErsatzTV Image / EF migration integrity (SQLite + MySql) (pull_request) Successful in 6m18s
Build ErsatzTV Image / Build & push image (amd64) (pull_request) Skipped
Build ErsatzTV Image / Functional E2E (curl + UI contracts) (pull_request) Successful in 6m1s
Build ErsatzTV Image / API docs in sync (OpenAPI + endpoint index) (pull_request) Successful in 7s
Build ErsatzTV Image / Formatting (changed .cs conform to .editorconfig) (pull_request) Successful in 5s
review-verdict/h10 Review-verdict: MERGEABLE @ 586577c (base: main)
CI's 'Script lint and tests' went red on `ruff format --check`. `ruff check` was clean and the suite was green throughout — this was purely formatting of lines this branch added, and it is a gap in MY local gate: I ran pytest and the decisions validator every round and never ran the formatter. Formatted with ruff 0.12.11, the version pr-checks.yml pins, rather than the local install — the pin exists precisely so the verdict is not a function of whoever ran it, and a different version could have reformatted lines this branch never touched. The diff is confined to blocks added here (a re.subn call, two assertion strings, two parametrize entries). Verified over the whole CI population, not just the file I edited: git ls-files '*.py' | xargs ruff check -> All checks passed git ls-files '*.py' | xargs ruff format --check -> 43 files already formatted scripts/tests: 1012 passed, 2 skipped.
This commit is contained in:
@@ -1339,8 +1339,12 @@ def _run_classify(
|
||||
# against a multi-entry value. Every other test runs the singleton `timothy`, under which a
|
||||
# loop that can only ever match its LAST entry is indistinguishable from a correct one — and
|
||||
# the workflow's own diagnostic tells operators to add a second entry.
|
||||
body, n = re.subn(r'^(\s*)H10_REVIEWERS="[^"]*"$', lambda m: f'{m.group(1)}H10_REVIEWERS="{reviewers}"',
|
||||
body, flags=re.MULTILINE)
|
||||
body, n = re.subn(
|
||||
r'^(\s*)H10_REVIEWERS="[^"]*"$',
|
||||
lambda m: f'{m.group(1)}H10_REVIEWERS="{reviewers}"',
|
||||
body,
|
||||
flags=re.MULTILINE,
|
||||
)
|
||||
assert n == 1, f"expected exactly one H10_REVIEWERS assignment to override, substituted {n}"
|
||||
script.write_text(body)
|
||||
r = subprocess.run(["bash", str(script)], cwd=tmp_path, env=env, capture_output=True, text=True)
|
||||
@@ -1763,8 +1767,7 @@ def test_a_verdict_shaped_SUCCESS_from_a_NON_allowlisted_account_is_RE_DERIVED(t
|
||||
# reaches, not on a separate annotation: the annotation that used to carry this was withdrawn
|
||||
# after cold review measured that deleting it left the whole suite green.
|
||||
assert creator in r.stdout, (
|
||||
"the diagnostic does not name the account whose verdict was discarded. "
|
||||
f"Log:\n{r.stdout[-1200:]}"
|
||||
f"the diagnostic does not name the account whose verdict was discarded. Log:\n{r.stdout[-1200:]}"
|
||||
)
|
||||
# The VALUE, not the word. An earlier draft asserted `"H10_REVIEWERS" in stdout`, which the
|
||||
# remediation sentence satisfies on its own — so deleting the allow-list from the diagnostic left
|
||||
@@ -2042,11 +2045,9 @@ def test_an_account_on_NEITHER_entry_is_still_re_derived(tmp_path):
|
||||
@pytest.mark.parametrize(
|
||||
"shape,creator,desc",
|
||||
[
|
||||
("a null creator (an Actions-token write)", None,
|
||||
"Review-verdict: BLOCKED @ a9e3e23 (base: main)"),
|
||||
("a null creator (an Actions-token write)", None, "Review-verdict: BLOCKED @ a9e3e23 (base: main)"),
|
||||
("a description that is not a verdict", "timothy", "blocked by hand"),
|
||||
("a verdict recorded against ANOTHER base", "timothy",
|
||||
"Review-verdict: BLOCKED @ a9e3e23 (base: other)"),
|
||||
("a verdict recorded against ANOTHER base", "timothy", "Review-verdict: BLOCKED @ a9e3e23 (base: other)"),
|
||||
],
|
||||
)
|
||||
def test_an_UNATTRIBUTABLE_failure_is_still_RE_DERIVED(tmp_path, shape, creator, desc):
|
||||
|
||||
Reference in New Issue
Block a user