timothy/ersatztv
1
0
Fork 0
Code Issues 51 Pull Requests 5 Actions Packages Projects Releases 9 Wiki Activity

fix(60): re-review fixups for channel preview
PR Gates / CI image pin matches docker/ci (pull_request) Successful in 10s
Details
Build ErsatzTV Image / Formatting (changed .cs conform to .editorconfig) (pull_request) Successful in 13s
Details
PR Gates / Docs update reminder (pull_request) Successful in 12s
Details
PR Gates / decisions lifecycle (pull_request) Successful in 18s
Details
Build ErsatzTV Image / API docs in sync (OpenAPI + endpoint index) (pull_request) Successful in 14m11s
Details
Build ErsatzTV Image / Functional E2E (curl contracts) (pull_request) Successful in 17m26s
Details
Build ErsatzTV Image / Build & test (.NET) (pull_request) Successful in 21m44s
Details
Build ErsatzTV Image / EF migration integrity (SQLite + MySql) (pull_request) Successful in 22m57s
Details
Build ErsatzTV Image / Build & push image (amd64) (pull_request) Has been skipped
Details

Browse Source 
- ChannelPreviewPanel: a manual play-button click on a video already
  showing a fatal error was clearing the error, silently hiding the
  fault the panel exists to reveal. onPlaying now ignores the event
  while a fatal error is showing (tracked via a ref, reset in an
  effect keyed on channel.id); Retry remains the only way to clear it.
- shell.css: .ctv-preview-facts spacing was dead — equal-specificity
  .ctv-detail-infogrid{margin:0} later in the file won. Raised
  specificity with a compound selector instead of touching
  .ctv-detail-infogrid, which MediaDetailScreen also relies on.
- ChannelPreviewTests: added two cases exercising two simultaneously-
  true Unavailable causes, so the documented guard precedence in
  Mapper.GetPreview is actually pinned by a test.
- design doc: fixed a garbled sentence describing which DTO gained
  the Preview field.
This commit is contained in:
timothy
2026-07-21 23:13:27 +02:00
parent 54610fe0af
commit 6838979780
5 changed files with 90 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files
web/src/shell.css
+4 -1
View File
@@ -1130,7 +1130,10 @@ body {
margin: 0 0 var(--space-6, 12px);
}
.ctv-preview-facts {
/* Two classes (higher specificity than .ctv-detail-infogrid alone) so this margin actually wins
over that shared rule's `margin: 0`, without weakening .ctv-detail-infogrid for its other
consumer (MediaDetailScreen), which relies on margin:0 there. */
.ctv-preview-facts.ctv-detail-infogrid {
margin-top: var(--space-6, 12px);
}