From 7cc12881de7252d6734aa8ee7f2a827924b7d77a Mon Sep 17 00:00:00 2001 From: Timothy Date: Sat, 25 Jul 2026 15:16:59 +0200 Subject: [PATCH] docs(484): correct the counted-enumeration counts on the api client interfaces Review follow-up. The comments still said three (Jellyfin) / two (Emby) library-level enumerations after the nested season and episode ones were counted, which understates the reach of the very safety property this branch establishes -- a future auditor reading them would conclude the nested sweeps are unprotected. --- ErsatzTV.Core/Interfaces/Emby/IEmbyApiClient.cs | 9 ++++++--- ErsatzTV.Core/Interfaces/Jellyfin/IJellyfinApiClient.cs | 9 ++++++--- 2 files changed, 12 insertions(+), 6 deletions(-) diff --git a/ErsatzTV.Core/Interfaces/Emby/IEmbyApiClient.cs b/ErsatzTV.Core/Interfaces/Emby/IEmbyApiClient.cs index 446176af5..7378b01b5 100644 --- a/ErsatzTV.Core/Interfaces/Emby/IEmbyApiClient.cs +++ b/ErsatzTV.Core/Interfaces/Emby/IEmbyApiClient.cs @@ -9,9 +9,12 @@ public interface IEmbyApiClient Task> GetServerInformation(string address, string apiKey); Task>> GetLibraries(string address, string apiKey); - // #484: the two library-level enumerations that feed a reconciliation sweep accept an optional - // per-enumeration counter. The caller creates one instance per enumeration and reads it only after - // the enumeration completes; passing null (the default) opts out and costs existing callers nothing. + // #484: the four enumerations that feed a reconciliation sweep accept an optional per-enumeration + // counter -- the two library-level ones (movies, shows) AND the two nested ones (seasons per show, + // episodes per season), which feed the per-parent sweeps in MediaServerTelevisionLibraryScanner. + // The caller creates one instance per enumeration, scoped to the parent it sweeps, and reads it + // only after that enumeration completes; passing null (the default) opts out and costs existing + // callers nothing. IAsyncEnumerable> GetMovieLibraryItems( string address, string apiKey, diff --git a/ErsatzTV.Core/Interfaces/Jellyfin/IJellyfinApiClient.cs b/ErsatzTV.Core/Interfaces/Jellyfin/IJellyfinApiClient.cs index 89f0802c3..8f2c94575 100644 --- a/ErsatzTV.Core/Interfaces/Jellyfin/IJellyfinApiClient.cs +++ b/ErsatzTV.Core/Interfaces/Jellyfin/IJellyfinApiClient.cs @@ -9,9 +9,12 @@ public interface IJellyfinApiClient Task> GetServerInformation(string address, string authorizationHeader); Task>> GetLibraries(string address, string authorizationHeader); - // #484: the three library-level enumerations that feed a reconciliation sweep accept an optional - // per-enumeration counter. The caller creates one instance per enumeration and reads it only after - // the enumeration completes; passing null (the default) opts out and costs existing callers nothing. + // #484: the six enumerations that feed a reconciliation sweep accept an optional per-enumeration + // counter -- the three library-level ones (movies, music videos, shows) AND the three nested ones + // (seasons per show, episodes per season, both episode variants), which feed the per-parent sweeps + // in MediaServerTelevisionLibraryScanner. The caller creates one instance per enumeration, scoped + // to the parent it sweeps, and reads it only after that enumeration completes; passing null (the + // default) opts out and costs existing callers nothing. IAsyncEnumerable> GetMovieLibraryItems( string address, string authorizationHeader,