async fixes (#128)

* refactor local metadata provider

* resolve async warnings

* more async fixes

ErsatzTV.Infrastructure/Data/DbInitializer.cs

@@ -1,6 +1,8 @@
 using System;
 using System.Collections.Generic;
 using System.Linq;
+using System.Threading;
+using System.Threading.Tasks;
 using ErsatzTV.Core.Domain;
 using LanguageExt;
 
@@ -8,7 +10,7 @@ namespace ErsatzTV.Infrastructure.Data
 {
     public static class DbInitializer
     {
-        public static Unit Initialize(TvContext context)
+        public static async Task<Unit> Initialize(TvContext context, CancellationToken cancellationToken)
         {
             if (context.Resolutions.Any())
             {
@@ -22,28 +24,28 @@ namespace ErsatzTV.Infrastructure.Data
                 new() { Id = 3, Name = "1920x1080", Width = 1920, Height = 1080 },
                 new() { Id = 4, Name = "3840x2160", Width = 3840, Height = 2160 }
             };
-            context.Resolutions.AddRange(resolutions);
-            context.SaveChanges();
+            await context.Resolutions.AddRangeAsync(resolutions, cancellationToken);
+            await context.SaveChangesAsync(cancellationToken);
 
             var resolutionConfig = new ConfigElement
             {
                 Key = ConfigElementKey.FFmpegDefaultResolutionId.Key,
                 Value = "3" // 1920x1080
             };
-            context.ConfigElements.Add(resolutionConfig);
-            context.SaveChanges();
+            await context.ConfigElements.AddAsync(resolutionConfig, cancellationToken);
+            await context.SaveChangesAsync(cancellationToken);
 
             var defaultProfile = FFmpegProfile.New("1920x1080 x264 ac3", resolutions[2]);
-            context.FFmpegProfiles.Add(defaultProfile);
-            context.SaveChanges();
+            await context.FFmpegProfiles.AddAsync(defaultProfile, cancellationToken);
+            await context.SaveChangesAsync(cancellationToken);
 
             var profileConfig = new ConfigElement
             {
                 Key = ConfigElementKey.FFmpegDefaultProfileId.Key,
                 Value = defaultProfile.Id.ToString()
             };
-            context.ConfigElements.Add(profileConfig);
-            context.SaveChanges();
+            await context.ConfigElements.AddAsync(profileConfig, cancellationToken);
+            await context.SaveChangesAsync(cancellationToken);
 
             var defaultChannel = new Channel(Guid.NewGuid())
             {
@@ -52,8 +54,8 @@ namespace ErsatzTV.Infrastructure.Data
                 FFmpegProfile = defaultProfile,
                 StreamingMode = StreamingMode.TransportStream
             };
-            context.Channels.Add(defaultChannel);
-            context.SaveChanges();
+            await context.Channels.AddAsync(defaultChannel, cancellationToken);
+            await context.SaveChangesAsync(cancellationToken);
 
             // TODO: create looping static image that mentions configuring via web
             return Unit.Default;

ErsatzTV.Infrastructure/Data/Repositories/ChannelRepository.cs

@@ -64,10 +64,10 @@ namespace ErsatzTV.Infrastructure.Data.Repositories
                 .ThenInclude(mm => mm.Artwork)
                 .ToListAsync();
 
-        public async Task Update(Channel channel)
+        public Task Update(Channel channel)
         {
             _dbContext.Channels.Update(channel);
-            await _dbContext.SaveChangesAsync();
+            return _dbContext.SaveChangesAsync();
         }
 
         public async Task Delete(int channelId)

ErsatzTV.Infrastructure/Data/Repositories/ConfigElementRepository.cs

@@ -31,16 +31,16 @@ namespace ErsatzTV.Infrastructure.Data.Repositories
         public Task<Option<T>> GetValue<T>(ConfigElementKey key) =>
             Get(key).MapT(ce => (T) Convert.ChangeType(ce.Value, typeof(T)));
 
-        public async Task Update(ConfigElement configElement)
+        public Task Update(ConfigElement configElement)
         {
             _dbContext.ConfigElements.Update(configElement);
-            await _dbContext.SaveChangesAsync();
+            return _dbContext.SaveChangesAsync();
         }
 
-        public async Task Delete(ConfigElement configElement)
+        public Task Delete(ConfigElement configElement)
         {
             _dbContext.ConfigElements.Remove(configElement);
-            await _dbContext.SaveChangesAsync();
+            return _dbContext.SaveChangesAsync();
         }
     }
 }

ErsatzTV.Infrastructure/Data/Repositories/FFmpegProfileRepository.cs

@@ -32,10 +32,10 @@ namespace ErsatzTV.Infrastructure.Data.Repositories
                 .Include(p => p.Resolution)
                 .ToListAsync();
 
-        public async Task Update(FFmpegProfile ffmpegProfile)
+        public Task Update(FFmpegProfile ffmpegProfile)
         {
             _dbContext.FFmpegProfiles.Update(ffmpegProfile);
-            await _dbContext.SaveChangesAsync();
+            return _dbContext.SaveChangesAsync();
         }
 
         public async Task Delete(int ffmpegProfileId)

ErsatzTV.Infrastructure/Data/Repositories/PlayoutRepository.cs

@@ -124,10 +124,10 @@ namespace ErsatzTV.Infrastructure.Data.Repositories
                 .ToListAsync();
         }
 
-        public async Task Update(Playout playout)
+        public Task Update(Playout playout)
         {
             _dbContext.Playouts.Update(playout);
-            await _dbContext.SaveChangesAsync();
+            return _dbContext.SaveChangesAsync();
         }
 
         public async Task Delete(int playoutId)

ErsatzTV.Infrastructure/ErsatzTV.Infrastructure.csproj

@@ -3,9 +3,14 @@
     <PropertyGroup>
         <TargetFramework>net5.0</TargetFramework>
         <GenerateRuntimeConfigurationFiles>true</GenerateRuntimeConfigurationFiles>
+        <NoWarn>VSTHRD200</NoWarn>
     </PropertyGroup>
 
     <ItemGroup>
+      <PackageReference Include="AsyncFixer" Version="1.5.1">
+        <PrivateAssets>all</PrivateAssets>
+        <IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
+      </PackageReference>
       <PackageReference Include="Dapper" Version="2.0.78" />
       <PackageReference Include="Lucene.Net" Version="4.8.0-beta00013" />
       <PackageReference Include="Lucene.Net.Analysis.Common" Version="4.8.0-beta00013" />
@@ -16,6 +21,10 @@
         <IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
       </PackageReference>
       <PackageReference Include="Microsoft.EntityFrameworkCore.Sqlite" Version="5.0.4" />
+      <PackageReference Include="Microsoft.VisualStudio.Threading.Analyzers" Version="16.9.60">
+        <PrivateAssets>all</PrivateAssets>
+        <IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
+      </PackageReference>
       <PackageReference Include="Refit" Version="6.0.38" />
       <PackageReference Include="SixLabors.ImageSharp" Version="1.0.3" />
     </ItemGroup>

ErsatzTV.Infrastructure/Images/ImageCache.cs

@@ -8,7 +8,6 @@ using ErsatzTV.Core.Domain;
 using ErsatzTV.Core.Interfaces.Images;
 using ErsatzTV.Core.Interfaces.Metadata;
 using LanguageExt;
-using Microsoft.Extensions.Logging;
 using SixLabors.ImageSharp;
 using SixLabors.ImageSharp.Formats.Jpeg;
 using SixLabors.ImageSharp.Processing;
@@ -19,15 +18,10 @@ namespace ErsatzTV.Infrastructure.Images
     {
         private static readonly SHA1CryptoServiceProvider Crypto;
         private readonly ILocalFileSystem _localFileSystem;
-        private readonly ILogger<ImageCache> _logger;
 
         static ImageCache() => Crypto = new SHA1CryptoServiceProvider();
 
-        public ImageCache(ILocalFileSystem localFileSystem, ILogger<ImageCache> logger)
-        {
-            _localFileSystem = localFileSystem;
-            _logger = logger;
-        }
+        public ImageCache(ILocalFileSystem localFileSystem) => _localFileSystem = localFileSystem;
 
         public async Task<Either<BaseError, byte[]>> ResizeImage(byte[] imageBuffer, int height)
         {