style(784): clear ruff check on both new python files
PR Gates / CI image pin matches docker/ci (pull_request) Successful in 12s
Build ErsatzTV Image / Delimiter ban (release path) (pull_request) Successful in 20s
PR Gates / Docs update reminder (pull_request) Successful in 30s
PR Gates / decisions lifecycle (pull_request) Successful in 33s
PR Gates / Fix proofs (Proves trailers) (pull_request) Successful in 27s
Review verdict / Set review-verdict status (pull_request_target) Successful in 17s
PR Gates / Script tests (pytest) (pull_request) Successful in 5m10s
Build ErsatzTV Image / Build & test (.NET) (pull_request) Successful in 8m48s
Build ErsatzTV Image / EF migration integrity (SQLite + MySql) (pull_request) Successful in 6m24s
Build ErsatzTV Image / Build & push image (amd64) (pull_request) Skipped
Build ErsatzTV Image / Functional E2E (curl + UI contracts) (pull_request) Successful in 6m38s
Build ErsatzTV Image / API docs in sync (OpenAPI + endpoint index) (pull_request) Successful in 10s
Build ErsatzTV Image / Formatting (changed .cs conform to .editorconfig) (pull_request) Successful in 6s
review-verdict/h10 Review-verdict: MERGEABLE @ d938493 (base: main)
PR Gates / CI image pin matches docker/ci (pull_request) Successful in 12s
Build ErsatzTV Image / Delimiter ban (release path) (pull_request) Successful in 20s
PR Gates / Docs update reminder (pull_request) Successful in 30s
PR Gates / decisions lifecycle (pull_request) Successful in 33s
PR Gates / Fix proofs (Proves trailers) (pull_request) Successful in 27s
Review verdict / Set review-verdict status (pull_request_target) Successful in 17s
PR Gates / Script tests (pytest) (pull_request) Successful in 5m10s
Build ErsatzTV Image / Build & test (.NET) (pull_request) Successful in 8m48s
Build ErsatzTV Image / EF migration integrity (SQLite + MySql) (pull_request) Successful in 6m24s
Build ErsatzTV Image / Build & push image (amd64) (pull_request) Skipped
Build ErsatzTV Image / Functional E2E (curl + UI contracts) (pull_request) Successful in 6m38s
Build ErsatzTV Image / API docs in sync (OpenAPI + endpoint index) (pull_request) Successful in 10s
Build ErsatzTV Image / Formatting (changed .cs conform to .editorconfig) (pull_request) Successful in 6s
review-verdict/h10 Review-verdict: MERGEABLE @ d938493 (base: main)
Round 7 verdict was MERGEABLE with one nit — an over-long comment line. Ruff found two more while I was there: UP031 (percent format) and S110 (a bare try/except/pass). The S110 is deliberate and stays: it guards the stdio reconfigure, which IS the never-fails invariant's own setup and so is the one place that must not raise. It is now noqa'd with that reason rather than left looking like an oversight. `ruff format` is deliberately NOT applied. This repo checks in no ruff config and 21 of its 35 tracked python files fail `ruff format --check`, so reformatting these two alone would diverge from every file around them — the deviation policy says match the established style. `ruff check` is clean, which is the half that finds defects. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This commit is contained in:
@@ -38,8 +38,8 @@ import sys
|
||||
try:
|
||||
sys.stdout.reconfigure(errors="replace") # type: ignore[union-attr]
|
||||
sys.stderr.reconfigure(errors="replace") # type: ignore[union-attr]
|
||||
except Exception: # noqa: BLE001 — a stdout that cannot be reconfigured is not a reason to fail
|
||||
pass
|
||||
except Exception: # noqa: BLE001, S110 — a stdout that cannot be reconfigured is not a reason to fail
|
||||
pass # deliberate: this is the never-fails invariant's own setup, so it cannot itself raise
|
||||
|
||||
# `docs/decisions/**` is exempt WHOLESALE — a decision record narrating how a rule was got wrong is
|
||||
# carrying the rationale it exists to carry, so a detector that flagged it would fight the
|
||||
@@ -124,7 +124,8 @@ def git(*args: str) -> tuple[int, str]:
|
||||
|
||||
def scan_line(path: str, lineno: int, text: str, out: list[str]) -> None:
|
||||
if PATTERNS.search(text):
|
||||
out.append("::warning file=%s::%s" % (path, WARNING.format(path=path, line=lineno, text=text[:160])))
|
||||
detail = WARNING.format(path=path, line=lineno, text=text[:160])
|
||||
out.append(f"::warning file={path}::{detail}")
|
||||
|
||||
|
||||
def added_lines(diff: str):
|
||||
|
||||
@@ -127,7 +127,8 @@ def test_a_DELETED_doc_is_not_reported_as_added_content(repo: Path) -> None:
|
||||
# `+++ w/f.md`. It is inert HERE for a reason worth stating exactly, because the obvious explanation
|
||||
# is the wrong one — not because `--dst-prefix=b/` beats it, though it does, but because git only
|
||||
# uses mnemonic prefixes when a diff side is the worktree or the index, and `run_diff` issues the
|
||||
# three-dot `base...HEAD` form, where git emits plain `a/`…`b/` either way. Measured, not reasoned.) Three of these were each demonstrated turning
|
||||
# three-dot `base...HEAD` form, where git emits plain `a/`…`b/` either way. Measured, not reasoned.)
|
||||
# Three of these were each demonstrated turning
|
||||
# a real hit into `scanned 0 file(s)`, one at a time, in three separate rounds — which is why the fix
|
||||
# stopped pinning variants and removed the surface. The table is here so the next knob someone finds
|
||||
# gets a row instead of a round.
|
||||
|
||||
Reference in New Issue
Block a user