From e7ae919959d4bc3dce1fd8ec9b73d4012db72088 Mon Sep 17 00:00:00 2001 From: Timothy Date: Sun, 26 Jul 2026 00:42:22 +0200 Subject: [PATCH] fix(617): correct two stale logo claims carried in from both copies MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Both copies still described pre-fix behavior: - "External URL logos work for M3U but NOT for watermark burn-in (code checks File.Exists())" — the WatermarkSelector File.Exists gate was removed in #502 (ffmpeg.external-logo-graphics-engine); logos are cached at save time (graphics.channel-logo-caching). - "M3U tvg-logo URLs hardcode http://localhost:8409" — #340 added the optional iptv.base_url advertised base URL (iptv.base-url). --- .claude/skills/ersatztv/SKILL.md | 14 ++++++++++++-- 1 file changed, 12 insertions(+), 2 deletions(-) diff --git a/.claude/skills/ersatztv/SKILL.md b/.claude/skills/ersatztv/SKILL.md index 7b4627449..c0bb5361e 100644 --- a/.claude/skills/ersatztv/SKILL.md +++ b/.claude/skills/ersatztv/SKILL.md @@ -421,8 +421,18 @@ Consumers reach ETV **only through Dispatcharr** (`ErsatzTV → Dispatcharr → 8. Run `fix_logos.py` to push logo to Jellyfin ### Logo System -- External URL logos work for M3U but NOT for watermark burn-in (code checks `File.Exists()`) -- M3U `tvg-logo` URLs hardcode `http://localhost:8409` — Jellyfin can't fetch these from inside its container. Fix by downloading logos from ETV and base64-uploading to Jellyfin (see `docs/Docker/ErsatzTV.md` for script) +- **External-URL logos now work for the on-screen bug too** — fixed in ersatztv#502 (2026-07-20, + `ffmpeg.external-logo-graphics-engine`). The old claim that they work for M3U but not watermark + burn-in described a `WatermarkSelector` `File.Exists()` gate that is gone; an external logo is + fetched, decode-budget-validated and stored in the image cache at **save** time + (`graphics.channel-logo-caching`), so the render path never fetches over HTTP and a bad URL fails + the save with a 422. +- **M3U/XMLTV absolute URLs are no longer stuck on the request-derived host.** They used to bake in + whatever host fetched the feed (the historical `http://localhost:8409` symptom, Gitea #1/#171), + which Jellyfin can't resolve from inside its container. Set the optional advertised base URL — + `GET`/`PUT /api/v1/settings/iptv` (`iptv.base_url`, ersatztv#340, `iptv.base-url`) — to pin them to + a fixed public origin; unset falls back byte-identical to the old behavior. The base64-upload + workaround in `docs/Docker/ErsatzTV.md` is only needed if that setting is left unset. - `logo_XX.png` files in the logos root dir are HTML garbage (broken downloads), not actual logos — ignore them ### Other