From ea0eb0ab76a1843d082d2f78d7b4d785ca58a2c9 Mon Sep 17 00:00:00 2001 From: Timothy Date: Sat, 11 Jul 2026 13:16:39 +0200 Subject: [PATCH] =?UTF-8?q?docs(handoff):=20lessons=20from=20#242=20?= =?UTF-8?q?=E2=80=94=20re-review=20the=20fix=20commit=20before=20closing;?= =?UTF-8?q?=20disabled=3D{saving}=20SchedulesScreen=20convention?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Co-Authored-By: Claude Fable 5 --- docs/handoffs/chicorytv-issue-queue.md | 13 +++++++++++++ 1 file changed, 13 insertions(+) diff --git a/docs/handoffs/chicorytv-issue-queue.md b/docs/handoffs/chicorytv-issue-queue.md index 879c02611..20148713f 100644 --- a/docs/handoffs/chicorytv-issue-queue.md +++ b/docs/handoffs/chicorytv-issue-queue.md @@ -162,3 +162,16 @@ HARD CONSTRAINTS: wholesale wedged the scan button disabled-until-reload for short scans; both fork + Codex caught it. Keep a bounded version, re-scoped honestly. When an issue says "delete X", enumerate every behavior X provided before deleting. +- **Re-review the FIX COMMIT, not just the initial PR diff, before closing** (2026-07-11, #242, + user-surfaced): the pre-fix review is only half the loop — the fix commit is new code no + independent reviewer has seen. Here the first fix (gate Edit on `saving`) only PARTIALLY closed + the in-flight-save clobber class; a Codex re-review of the fix commit caught that **Delete** was + the one schedule-switch path (`applySwitch`) still missing the guard. Fold a scoped re-review + (Codex if quota, else a fork) over the fix commit into the close protocol; loop until a clean + MERGEABLE verdict or an explicit acceptable-defer (file a tracked issue for the deferral, as #248 + here). Cheap relative to shipping a half-fix that reopens the issue. +- **`disabled={saving}` is the SchedulesScreen convention for "no schedule-switch/mutation mid-save"** + (2026-07-11, #242): the Select + `guardedSwitch` already guard `saving`; Edit and Delete must too + — Delete switches schedules via `applySwitch`, and a stale items PUT resolving after the switch + clobbers the next schedule's draft. When adding any control that can switch the active schedule or + reopen the editor, gate it on `saving` (and, for the editor, on the dirty draft).