4 Commits

Include renames

Author	SHA1	Message	Date
timothyandClaude Opus 4.8	70f357f8f9	feat(api): #288 ChannelDetailResponseModel for edit form + SPA repoints + final regen ... Mint ChannelDetailResponseModel (faithful detail DTO exposing the raw editable field set the channel editor reads: raw FFmpegProfileId/WatermarkId/FallbackFillerId ids, the mode enums, logo, playoutCount, id) and route GetById/Create/Update through it, replacing the lean list ChannelResponseModel that resolved the profile to a name and dropped the editable ids (a functional regression for draftFromChannel). The lean ChannelResponseModel stays unchanged for GET /api/channels. webEncodedName dropped (SPA never reads it). Logo is mirrored as a Core ChannelLogoResponseModel since the Application ArtworkContentTypeModel can't be referenced from Core. Repoint the hand-written SPA client aliases now that the VMs are gone from the schema: Channel -> ChannelDetailResponseModel, MediaCollection/SmartCollection -> *ResponseModel, ProgramSchedule -> ProgramScheduleResponseModel. Fix #288 honest-nullability test fallout in search.test.ts (null -> [] for now-non-null id arrays). Include the already-on-disk playouts.ts WithDayNames removal and regenerate v1.json + v1.d.ts + endpoint-index.md (authoritative final regen; the reset endpoint's {channelNumber}->{id} re-key surfaces in the generated docs and the OpenApi error-contract test). Refs #288 #197 Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>	2026-07-12 02:33:39 +02:00
timothyandClaude Fable 5	35206b2199	test(api): drop stale WatermarkViewModel serializer-contract case (#126) ... The flat ScheduleItemResponseModel removed the polymorphic ProgramScheduleItemViewModel from the API surface, which was the only path exposing the Application VMs (WatermarkViewModel, PlaylistViewModel, FillerPresetViewModel, collection VMs, etc.). WatermarkViewModel is no longer in v1.json, so its serializer-contract guard case is moot. ChannelViewModel still covers the schema transformer's VM path. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>	2026-07-10 23:57:13 +02:00
timothyandClaude Fable 5	e0d30c9b7b	test(api): cover [JsonProperty] path + fail loudly on rename collision (#198, review) ... Adversarial-review follow-ups: - OpenApiSerializerContractTests: add a fifth case, a fully-populated ChannelResponseModel — the only DTO with a [JsonProperty("ffmpegProfile")] override, i.e. the attribute path of NewtonsoftSchemaNamingTransformer that the existing four cases never exercised. - NewtonsoftSchemaNamingTransformer: a rename colliding with an existing schema key now throws InvalidOperationException (naming the type and keys) instead of silently overwriting/dropping a property — the generator must never emit a lossy spec. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>	2026-07-09 20:06:26 +02:00
timothyandClaude Fable 5	f26790aa35	fix(api): mirror runtime Newtonsoft JSON casing in OpenAPI spec (#198) ... The OpenAPI document is generated from System.Text.Json metadata, whose camelCase drifted from the runtime MVC serializer (Newtonsoft via CustomContractResolver/CustomNamingStrategy): the spec said "fFmpegProfileId" and "fFmpegProfile" while the wire emits "ffmpegProfileId" (naming-strategy special case) and "ffmpegProfile" (ChannelResponseModel's [JsonProperty] override). That fed the SPA the wrong keys. Add NewtonsoftSchemaNamingTransformer, an OpenAPI schema transformer registered on all three documents that renames each object schema's Properties (and Required) keys through the SAME Newtonsoft contract resolver the runtime uses, so the spec matches the wire format by construction. Regenerate v1.json. Guard with OpenApiSerializerContractTests: serializes fully-populated DTOs through the runtime Newtonsoft settings and pins the v1.json schema property sets to the emitted keys, failing if generation drifts again. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>	2026-07-09 20:00:23 +02:00