2 Commits

Include renames

Author	SHA1	Message	Date
timothyandClaude Opus 5.5	324dbdbca0	fix(913): scripted playout callbacks authenticate with a build-scoped token ... A scripted playout's program calls back into ScriptedScheduleController, which is under the fail-closed global ApiAuthorizationFilter, but was handed no credential. Reproduced 2026-10-29 on a live local instance at origin/main e919b925f (scripts/e2e-local.sh, port 8510): the program's GET .../context and POST .../add_collection both returned 401, and the playout's buildStatus still read success=true with no items, because a program that exits 0 after the failure (entrypoint.py catches ApiException and does) looks like a clean build. Fix: ScriptedPlayoutBuilderService.StartSession mints a 256-bit token per build, independent of the build id; ScriptedPlayoutBuilder passes it in ETV_SCRIPTED_BUILD_TOKEN (environment, not argv: argv is logged at INF and a fourth positional would shift the user's own arguments); ApiAuthorizationFilter accepts it as X-Scripted-Build-Token on endpoints carrying [AcceptsScriptedBuildToken] (ScriptedScheduleController only), for the build named by the buildId route value, until EndSession. entrypoint.py sends it as a default header. [SkipApiAuthorization] on the controller was rejected: it widens the auth-exempt set by a mutating controller whose only remaining gate would be a logged GUID, and the Startup host check does not make the endpoint localhost-only. Tests: ScriptedScheduleAuthorizationTests drives the real filter over the endpoint metadata MVC builds from the production Startup for all 28 actions; ScriptedBuildTokenTests covers minting/validation and the launch environment. Clause mutations, each rebuilt and run 2026-10-29: - drop [AcceptsScriptedBuildToken] from the controller -> red: Running_Builds_Own_Token_Is_Accepted..., Scripted_Controller_Is_Gated... - disarm the filter's token clause (no return) -> red: Running_Builds_Own_Token... - delete the filter's marker check -> red: Token_Opens_Nothing_Outside... - add [SkipApiAuthorization] to the controller -> red: No_Credential..., Scripted_Controller_Is_Gated..., Token_Of_Another..., Token_Is_A_401_Once..., Wrong_Or_Empty_Token (x2), ApiControllerSecurityTests.Only_Scanner_And_Auth... - token comparison always true -> red: Token_Of_Another..., Wrong_Or_Empty("not-the-token") - drop WithEnvironmentVariables from CreateCommand -> red: Launch_Hands_The_Token... - RouteValueName "buildId" -> "id" -> red: Token_Route_Value_Is_The_Controllers... Live E2E on the fixed build (port 8510, fresh config): the real entrypoint.py with the generated etv_client copied from the ersatztv-test image built 3 playout items from a scanned collection; as the program, own token -> 200 on GET context and POST add_collection; no header, wrong token, another build's id, and the token on GET /api/v1/channels and POST /api/v1/collections -> 401; the token after the build ended -> 401; token absent from the server log. Docs: new record api.scripted-build-token; testing.scripted-engine-in- process-net's 401 clause now records the outcome; api-conventions §9 and testing.md updated; catalog regenerated. OpenAPI regenerated: no drift. Fixes #913 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: f9ce6bc6-5b36-491a-8d72-89c1f70dd3e1	2026-10-30 00:34:50 +01:00
Jason Dove	03b4419f67	rework scripted schedules (#2367) ... * start to reorganize scripted playout building * add openapi * add all content fns * add playout instructions * add control instructions * add request models * prevent build loop * rename * update changelog * tweak changelog	2025-09-03 20:53:14 +00:00