4 Commits

Include renames

Author	SHA1	Message	Date
timothyandClaude Opus 4.8	94ebf34ccd	feat(api): optimistic-concurrency contract for replace-all PUTs — PR1 infra + Block reference (#253) ... Adds the shared optimistic-concurrency contract so a stale second tab can no longer silently overwrite a fresher edit. PR1 lands the infra + the Block reference aggregate; PRs 2–4 fan the same recipe across the other 8 roots (design: #253#issuecomment-8472). Contract - `IVersionedAggregate` (`int Version`) on all 9 replace-all roots (ProgramSchedule, Block, Template, DecoTemplate, Playlist, Collection, Playout, MultiCollection, RerunCollection), EF-mapped `.IsConcurrencyToken()`; one dual-provider migration `AddAggregateVersions` (nullable:false, default 0). - Strong `ETag` of `Version` on the aggregate GET; `If-Match` on the PUT; mismatch → 412 (distinct from the §3a 409 build-lock guard). Successful PUT returns the new ETag. - `PreconditionFailedError : BaseError` → 412 in `ApiResults.ToErrorResult`; `ConcurrencyHeaders.ParseIfMatch/SetETag`; malformed If-Match → 400; `*`/absent = Phase-1 force-write. Block reference wiring - Handler: standalone `Either` via `CheckVersion` AFTER validation (never through `Apply`, which Join()-flattens the subtype to 422), unconditional `Version++`, `SaveChangesWithConcurrencyGuard` backstop (DbUpdateConcurrencyException → 412). - `BlockViewModel.Version` (header-only, not echoed in the body); controller sets the ETag on GET items and on the successful PUT. - SPA: `client.requestWithMeta` seam; `blocks.getBlockItemsWithMeta` + `replaceBlock` If-Match/ETag round-trip; `BlockEditor` holds the ETag, sends If-Match, and on 412 opens a blocking "changed elsewhere — reload" dialog. Tests - Handler contract tests: stale-If-Match → 412 (no mutation), matching/absent → success + bump, no-op save still bumps, and a two-context racing save → 412; proven non-vacuous (drop `.IsConcurrencyToken()` → the race test fails). - Controller tests: malformed If-Match → 400, If-Match threaded to the command, ETag on GET/PUT, 412 passthrough. SPA: requestWithMeta ETag, replaceBlock If-Match, 412 dialog. Docs: api-conventions §7a, spa-conventions §4a, domain-model glossary, decisions log. Refs #253 Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>	2026-07-11 16:51:59 +02:00
timothyandClaude Fable 5	28910ff557	fix(api): gate playout mutations on EntityLocker build lock (409) + mirror lock state in SPA (fixes #215) ... Blazor disabled per-playout Reset/Erase/Delete/Edit while a BuildPlayout was in flight (EntityLocker.IsPlayoutLocked); the REST API had no equivalent, so a client could race an in-flight build with a destructive ExecuteDelete and leave a half-built playout. After Blazor removal this safety invariant would vanish entirely (adversarial-reviewer#18 removal gate). Server: - Add public ApiResults.ConflictProblem(title, detail) (409, mirrors NotFoundProblem). - Inject IEntityLocker into PlayoutController; guard every id-keyed mutation (PUT {id}, PUT .../deco, PUT .../alternate-schedules, PUT .../templates, POST .../erase-items, POST .../erase-items-and-history, DELETE {id}) → 409 when IsPlayoutLocked(id); add [ProducesResponseType(...409)] to each. - Guard ChannelController.ResetPlayout the same way after resolving the id. - reset-all stays 202 (ResetAllPlayoutsHandler already skips locked playouts). - Stamp IsLocked onto PlayoutListItemResponseModel from IsPlayoutLocked. SPA: - Disable Reset/Erase/Erase-and-history/Delete for a locked row + show a "Building…" Badge; on a 409 surface the error and refresh the list. Tests: controller-level 409 guard tests (delete/erase/PUT/deco/channel-reset) + IsLocked projection test; new OpenAPI contract + metadata 409 rows. Docs: api-conventions §3a, blazor-route-parity playouts verdict, decisions.md. Regenerated v1.json + web types. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>	2026-07-10 23:34:23 +02:00
timothy	c113142a3d	fix(api): standardize error response contract ... refs #46	2026-06-28 14:58:48 +02:00
timothyandClaude Opus 4.8	8f7d240fc8	feat(api): REST foundation + Channels CRUD (#34) ... First slice of the REST API (ersatztv#2). Idiomatic REST over existing MediatR handlers; design in docs/rest-api.md. Foundation: NotFoundError : BaseError (Core) to split 404 from 422; ApiResults mapping helpers (Either/Option -> 201+Location / 200 / 204 / 404 / 422), additive (existing *ToActionResult untouched); ApiKeyAuthorizationFilter (optional X-Api-Key on mutating actions, gated by Api:WriteKey, no-op when unset) — independent of the IPTV JWT toggle so Jellyfin/Dispatcharr reads are unaffected, applied at controller-class level so every mutating action incl. ResetPlayout is covered fail-safe. Channels: POST /api/channels (201+Location), PUT/{id} (200/404), DELETE/{id} (204/404), GET/{id} (200/404). Request DTOs -> existing commands; responses reuse ChannelViewModel. Ported page-only validations into handlers (ShowInEpg-when-disabled, external-logo-URL, Group NotEmpty) + FFmpegProfile/Watermark/Filler existence on update for create-parity. Fixed a latent 500: the .Filter(c>0) existence pattern threw TaskCanceledException on not-found; rewritten to AnyAsync. Tests (NUnit, TZ=UTC): handler success/404/422, ApiResults mapping, API-key filter, controller status/Location/mapping, a controller-security regression net, and a create->read->delete EF integration test on a new in-memory SQLite harness. ErsatzTV.Tests 46/46, Architecture 5/5. Refs #34 Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>	2026-06-27 15:51:06 +02:00