ersatztv

2,388 Commits 67 Branches 157 Tags

3 Commits

Include renames

Author	SHA1	Message	Date
timothyandClaude Fable 5	922bec4b24	refactor(api): throw on unmapped health status instead of silent NotApplicable fallthrough (#108 ) Build ErsatzTV Image / Build & test (.NET) (pull_request) Successful in 4m23s Details Build ErsatzTV Image / EF migration integrity (SQLite + MySql) (pull_request) Successful in 5m27s Details Build ErsatzTV Image / Build & push image (amd64) (pull_request) Has been skipped Details Review finding: NotApplicable is filtered by the handler before mapping, so a silent ->"info" arm would only mask a missing filter if the mapper is ever reused unfiltered. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>	2026-07-03 21:18:41 +02:00
timothyandClaude Fable 5	29407f637b	fix(api): align health endpoint with API conventions (#108 ) Fix the WIP health-check API slice to match established patterns: - HealthController: add Name="GetHealthChecks" route name and move [EndpointGroupName("general")] to method level, matching FillerPresetController/FFmpegProfileController exactly (the precedent for parameterless 200-only GET actions). - HealthCheckResponseModel: enable #nullable for the file and mark Link as string? since the mapper can emit null when HealthCheckResult.Link is None. - Mapper: fix a real bug - LanguageExt's Option.Match throws ResultIsNullException.ResultIsNull if either branch returns null (by design, to catch accidental nulls). The WIP's `Link.Match(l => l.Link, () => null)` crashed on every health check without a Link. Switch to MatchUnsafe, the LanguageExt- sanctioned way to intentionally produce a nullable result from Option<T>. - HealthControllerTests: add the idiomatic-route-assertion test (route template + Name) and empty-list case, matching FillerPresetControllerTests. Verified: GetAllHealthCheckResultsForApiHandler already matches the existing GetAllHealthCheckResultsHandler's cancellation handling (both swallow TaskCanceledException/OperationCanceledException), so no change was needed there. Confirmed no OpenApi contract test enumerates all endpoints for error-response metadata (it's an explicit TestCase allowlist), so the new GET needed no new entries. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>	2026-07-03 21:14:42 +02:00
timothyandClaude Fable 5	83c9122b6f	wip: partial implementation salvaged from interrupted workflow run Untrusted draft — no build/test had run yet. Review before building on it. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>	2026-07-03 21:07:21 +02:00

Author

SHA1

Message

Date

timothyandClaude Fable 5

922bec4b24

refactor(api): throw on unmapped health status instead of silent NotApplicable fallthrough (#108 )

Build ErsatzTV Image / Build & test (.NET) (pull_request) Successful in 4m23s

Details

Build ErsatzTV Image / EF migration integrity (SQLite + MySql) (pull_request) Successful in 5m27s

Details

Build ErsatzTV Image / Build & push image (amd64) (pull_request) Has been skipped

Details

Review finding: NotApplicable is filtered by the handler before mapping,
so a silent ->"info" arm would only mask a missing filter if the mapper
is ever reused unfiltered.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

2026-07-03 21:18:41 +02:00

timothyandClaude Fable 5

29407f637b

fix(api): align health endpoint with API conventions (#108 )

Fix the WIP health-check API slice to match established patterns:

- HealthController: add Name="GetHealthChecks" route name and move
  [EndpointGroupName("general")] to method level, matching
  FillerPresetController/FFmpegProfileController exactly (the
  precedent for parameterless 200-only GET actions).
- HealthCheckResponseModel: enable #nullable for the file and mark
  Link as string? since the mapper can emit null when
  HealthCheckResult.Link is None.
- Mapper: fix a real bug - LanguageExt's Option.Match throws
  ResultIsNullException.ResultIsNull if either branch returns null
  (by design, to catch accidental nulls). The WIP's
  `Link.Match(l => l.Link, () => null)` crashed on every health
  check without a Link. Switch to MatchUnsafe, the LanguageExt-
  sanctioned way to intentionally produce a nullable result from
  Option<T>.
- HealthControllerTests: add the idiomatic-route-assertion test
  (route template + Name) and empty-list case, matching
  FillerPresetControllerTests.

Verified: GetAllHealthCheckResultsForApiHandler already matches the
existing GetAllHealthCheckResultsHandler's cancellation handling
(both swallow TaskCanceledException/OperationCanceledException), so
no change was needed there. Confirmed no OpenApi contract test
enumerates all endpoints for error-response metadata (it's an
explicit TestCase allowlist), so the new GET needed no new entries.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

2026-07-03 21:14:42 +02:00

timothyandClaude Fable 5

83c9122b6f

wip: partial implementation salvaged from interrupted workflow run

Untrusted draft — no build/test had run yet. Review before building on it.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

2026-07-03 21:07:21 +02:00