4 Commits

Include renames

Author	SHA1	Message	Date
timothyandClaude Opus 4.8	8090e10408	fix(api): #265 — If-Match evaluates per RFC 7232 (valid-but-non-matching → 412, not 400) ... The shared optimistic-concurrency parser (ConcurrencyHeaders.ParseIfMatch) classified any non-canonical/weak/list If-Match value as Malformed → 400. Per RFC 7232 §3.1 a syntactically -valid entity-tag that simply doesn't strong-match must be 412; 400 is only for a genuine grammar violation. - Rewrite ParseIfMatch as a real RFC 7232 entity-tag/list parser: walks the comma-separated 1#entity-tag list, validates each [W/]DQUOTE *etagc DQUOTE member, and collects the strong members whose opaque text is our canonical decimal. Weak / empty / non-canonical / out-of-range tags are valid but contribute no version (→ empty set → 412); genuine grammar violations (unquoted, SP-in-tag, unterminated, garbage) → 400. - Reshape IfMatchCondition.ExpectedVersion : Option<int> → ExpectedVersions : Option<Seq<int>> and VersionedAggregateExtensions.CheckVersion → set membership (any strong match proceeds; empty set always 412). Threads through 10 replace/update commands + handlers + request mappers + 9 controllers. - No wire-contract change (400 + 412 already declared on every PUT; the field is header-derived and internal — no DTO/route/response-type/OpenAPI change). - Tests: ConcurrencyHeadersTests rewritten for the new classification (lists, weak, empty, non-canonical → Version/empty-set; grammar violations → Malformed) + new VersionedAggregateExtensionsTests for CheckVersion membership/empty-set/force-write. - Docs: api-conventions.md §7a rewritten; decisions.md entry appended. Refs #253 #197 fixes #265 Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>	2026-07-12 23:09:36 +02:00
timothyandClaude Opus 4.8	9e48aaefea	test(#259): cover id-mode subtype-change (delete+insert) with a same-type sibling ... Review-caught coverage gap: the existing Subtype_Change test runs the POSITIONAL path (id-less payload). Add a handler-level test for the id-mode branch — one id-matched item changes subtype (One->Duration: delete+insert, new id) while a sibling id-matched item keeps its subtype (Multiple: in place, id + fill-group state preserved) in the same payload. Proves the delete pass + match-pass Remove/Add don't double-handle and the survivor's state is retained. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>	2026-07-11 22:03:33 +02:00
timothyandClaude Opus 4.8	162b334e5d	test(#259): id-based reconcile matrix + docs (api-conventions §7c, decisions) ... Add the id-based reconcile tests to ReplaceProgramScheduleItemsReconcileTests: reorder moves state with the logical item (the non-vacuous core — proven to fail under forced-positional), insert-in-middle, delete-unreferenced, unknown-id→422, duplicate-id→422, and stale-version+unknown-id→412 (412 precedes 422, §7c). The GET→map→PUT lossless round-trip now round-trips r.Id so it exercises id-mode. Threads the new int? Id through all command/wire construction sites in tests. Docs: api-conventions §7c (stable child identity + the deliberate #2-#5 positional asymmetry) and a decisions.md entry. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>	2026-07-11 21:53:50 +02:00
timothyandClaude Opus 4.8	64473b136d	fix(scheduling): stop silently resetting fill-group state + invalidate deco edits (#251, #252) ... #252: ReplaceProgramScheduleItems deleted and re-inserted every item on every save (even a no-op PUT-back), and PlayoutScheduleItemFillGroupIndex.ProgramScheduleItemId is OnDelete(Cascade) — so every schedule save silently wiped persisted fill-group/shuffle enumerator progression for all playouts using the schedule. Switch to a positional in-place reconcile: for a same-typed slot, copy scalars via CurrentValues.SetValues (BuildItem stays the single source of item construction, so no field is dropped) and rebuild the watermark/graphics join rows, keeping the item id — and with it the fill-group index. Subtype change / surplus falls back to delete+insert for that slot only. The request DTO carries no stable item id, so position is the only key here; true content-aware stable identity is deferred to the shared concurrency/round-trip contract in #253. #251: deco / deco-template CONTENT edits (and default-deco assignment) only take effect on a playout Reset build — deco/break/default-filler content is applied during Reset, a Continue keeps the frozen filler items, and BlockKey change-detection has no deco dimension to self-heal. The editors enqueued nothing (a commented-out TODO in ReplaceDecoTemplateItemsHandler), so filler/break content stayed stale indefinitely until a manual Reset. Enqueue BuildPlayout(Reset) for exactly the affected playouts: - ReplaceDecoTemplateItemsHandler: playouts via PlayoutTemplate.DecoTemplateId - UpdateDecoHandler: playouts via Playout.DecoId and via deco-template items - UpdateDefaultDecoHandler: the reassigned playout (adjacent same-class fix) Post-commit enqueues use CancellationToken.None (audit #22 policy). Tests: DecoInvalidationTests + ReplaceProgramScheduleItemsReconcileTests, each proven non-vacuous against a negative control (inverted the primitive, verified 0 CS errors so the --no-build run used a fresh dll). Full ErsatzTV.Tests suite green (1067). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>	2026-07-11 15:08:58 +02:00