Missed by my own BOM check, which used `git diff origin/main...HEAD` and so
only saw COMMITTED files -- this one was still uncommitted at the time. Use
`git diff origin/main` (no ...HEAD) so the working tree is included. Caught by
the format gate: CHARSET error, .editorconfig sets charset=utf-8 (no BOM).
Zero content change.
Refs #489
Review verdict was MERGEABLE; these are the findings worth fixing before merge.
M1 (the one gating finding): LibraryMediaKind.Mixed was accepted by
POST /api/v1/libraries/local. That created a library with no scanner, which
then failed every scan forever and logged at ERROR on each scheduler tick.
The invariant was asserted in prose twice and enforced nowhere -- and hiding
it from the SPA dropdown is not enforcement, since machine clients are a
stated audience for /api/v1. Now validated in CreateLocalLibraryHandler.
M3: an empty or whitespace CollectionType did not match the `null` pattern
and fell through to None, so on Jellyfin versions that serialize it that way
the whole feature silently no-opped -- no library, no log line. Normalized
via IsNullOrWhiteSpace, covered by a TestCase for "" and " ".
L4: the cancellation test asserted IsLeft but not that ScanCanceled reaches
the caller's info-log branch. That is the fragile bit -- folding it into an
aggregate BaseError would silently demote a user cancellation to an ERROR
log (#410). Now pinned in both directions.
Nit: reverted the show-guard message to match the byte-identical Plex/Emby
guards; the original wording is still accurate since the guard only fires
when the kind is neither Shows nor Mixed.
Also documented three accepted limitations in decisions.md (progress bar
resets per kind, one failing kind forces the others to rescan, and the fact
that the music-video scanner does no reconciliation at all -- which is why it
cannot cross-delete, but also means removals never propagate).
Negative controls: reverting the M1 validation fails its test; reverting the
projection/dispatch fails theirs.
Refs #489
Adds LocalLibrariesController (L1-L7: list/get/create/update/delete/move-path/
path-exists) wrapping the existing local-library MediatR commands, mapping to
the shared S0 response DTOs. Per design #202 §A.1/§C5/§C6:
- 404 for L4/L5/L6 comes from a controller pre-check (GetLocalLibraryById is
None), not the handler -- .Apply/.ToEitherAsync both .Join() a NotFoundError
into a plain 422, so relying on the handler would be dead code. This is
check-then-act; a delete racing the pre-check falls through to the handler's
422, documented in the controller.
- L4/L5 409 via IEntityLocker.IsLibraryLocked(id); L6 resolves the source
library from the path id (new ILibraryRepository.GetLibraryIdForPath) before
its own lock check.
- MoveLocalLibraryPathHandler gains same-MediaKind and different-library
validation (finding 3) -- Blazor only filtered these client-side in the move
dialog, so an API/MCP client could bypass them.
- CreateLocalLibraryHandler/UpdateLocalLibraryHandler gain a shared
NewPathsMustExist validation (LocalLibraryHandlerBase) that Directory.Exists-
checks only new paths (Id < 1); existing rows stay exempt so an unmounted
share doesn't block a rename. L7 (path-exists) is a controller-local
IFileSystem check with no command.
Tests: controller route/mediator-arg tests incl. 404-pre-check vs
fall-through-422 and 409-lock cases; handler tests for the move-path
cross-kind/same-library 422s, new-path 422 (missing/mixed), and a lossless
round-trip proving local paths are identified by normalized path string, not
id. Full solution test suite (Scanner/Core/Architecture/Tests/Infrastructure)
green, 0 regressions.
Deviations: none from the S1 slice description. Did not touch
MediaSourceRepository.cs or any Plex/Jellyfin/Emby file (S2/S3 scope). Did not
run the OpenAPI regen scripts (separate gate after S1-S3 merge per design §E).
Scan queue handler now returns a QueueLibraryScanResult enum
(Queued|NotFound|SyncDisabled|AlreadyScanning) instead of a lying bool;
LibrariesController.ScanLibrary maps them to 202/404/422/409 with ProblemDetails.
Guard the lock->enqueue with the EnqueueWithTraktLock compensating-unlock pattern.
ScannerService now releases every library/collection lock in a finally so a handler
exception can't leak the lock. Plex "Shows" scheduler batch (one lock, two messages)
now has only the trailing SynchronizePlexNetworks carry the single release
(Unlock flag), mirroring the scheduler Trakt tail-token precedent.
Guard the other lock->enqueue producers (Create/UpdateLocalLibrary, UpdateTraktList)
with compensating unlock. SPA drops the PENDING_GRACE_TICKS heuristic now that the
POST reports 202/409/404/422 directly: 202 -> pending+poll, 409 -> reconcile (no
error toast), 404/422 -> surface error.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
* fix validation in new form layout
* pin mediatr to last oss version
* update dependencies
* cleanup code in core
* cleanup code in ffmpeg
* cleanup code in infra
* cleanup code in scanner
* cleanup code in application
* cleanup main code
* cleanup test code
* solution-wide code cleanup