e08df757e78255e0af58cd73af0077fb682badca
3
Commits
| Author | SHA1 | Message | Date | |
|---|---|---|---|---|
|
|
e08df757e7 |
fix(819): correct the fail-direction claim — residual (3) is BLIND, not noisy
Round 10 adjudicated the wiring disagreement in the previous commit's favour (round 9's proposed assertions are green against both mutations; the structural argument holds), found no blocker and no HIGH, and then found that the previous commit had introduced a measured falsehood while writing that argument down. "Both (3) and (4) are fail-noisy" is false for (3). MEASURED, and reproduced here before fixing: a union-preserving mispartition in the plugin — move `src/components/` out of `tracked` and append it to `others` — hides a planted `pageSize: 100` in `src/components/bugPreview.tsx` with the whole suite green (43/43), where the same plant without the mutation reddens with `UNREGISTERED (1)`. Round 7 had already measured this and I wrote the opposite anyway. Why it matters more than a wording slip: fail-DIRECTION is the entire argument for tolerating a residual rather than closing it. A reader deciding whether (3) deserves work would have read "cannot hide a call site" — which is exactly the inference this issue exists to prevent. Two neighbouring sentences contradicted it in the same file, which is how it survived my own read. The residual list now states five, with their directions separated: (1), (2), (4) and (5) are fail-noisy — they redden a checkout and cannot hide a call site — while (3) is blind, tolerated only because nothing a CONSUMER computes can see it (the union it compares is unchanged), and answered by testing the derivation directly. The real-git tests that answer it catch an unconditional mispartition, not one keyed on a path pattern, and now say so. Also from round 10: - The list said "Three residuals" and enumerated four; `ABSENT_FROM_DISK` was a fifth, documented only at its declaration. Five, listed. - "No assertion can tell which is passed" was broader than measured: a `listSourceFiles.toString()` assertion DOES redden one of the two mutations. It is rejected rather than impossible — a text snapshot of one's own source is the hand-written-mirror shape this file spent nine rounds removing, and it misses the other mutation. Both places now say "no assertion comparing the two populations", with the reason. - The cross-check message said the shortfall test is "above"; it is below. This branch's own sweep of stale directional pointers missed it. - "Excluded for DIFFERENT reasons" survived above the text retracting exactly that framing. The reasons OVERLAP — both files need the binary, one also needs a checkout — and reading them as separate is what produced the round-8 blocker. - `vite-env.d.ts` claimed a renamed field always fails loudly; true for `tracked` and `others`, silent for `absentFromDisk`. - The realgit non-repo test asserts a message the missing-binary path also emits, so it passes for the wrong reason where git is absent — recorded, since that is the environment the file is excluded from. - A blank line had made the guard-inventory scope list render loose. Refs: #819 |
||
|
|
366e9e9571 |
fix(819): state the wiring residual honestly, and correct the checkout/binary claim
Round 9 found no blocker and no HIGH. These are its mechanical findings, plus one
correction to the fix it proposed.
The proposed fix for its MEDIUM did NOT work, and I measured it rather than
taking it. Round 9 suggested two assertions to pin the population WIRING —
`TRACKED_SOURCE_PATHS` equals `trackedSources.tracked`, and `listSourceFiles()`
equals `listSourceFilesFrom(rawSourceModules, TRACKED_SOURCE_PATHS)` — reported
as reddening the two survivors. Written and measured: both mutations stayed green
with those assertions in place (44/44). The reason is structural. On a clean
checkout the walk set and the index set ARE the same set — every tracked file is
on disk, nothing untracked exists — so no comparison between the two populations
can tell which one is wired in. It is observable only on a tree that HAS an
untracked source file, which is precisely the tree CI never checks out.
So it is recorded as residual (4) with its measurement and its DIRECTION, rather
than papered over with an assertion that cannot fail. Direction is what makes it
a residual and not a defect: reverting the wiring is fail-NOISY — it reddens a
developer's checkout that has a scratch file, the original #819 complaint — and
cannot hide a call site from the registry. Every blind direction runs through the
population SOURCE, and those are pinned by the cross-check.
Also from round 9:
- The checkout-vs-binary distinction was stated as an either/or in
`docs/testing.md` and the Dockerfile. MEASURED: with `.git` PRESENT and git off
`PATH`, the guard still fails — it needs both. As written it would license a
future "just `COPY .git` and re-enable it", which is round 8's blocker in
reverse. Both now say so explicitly.
- `docs/guard-inventory.md` claimed the partition residual is "checked only by
the plugin's own real-git tests". They catch an unconditional mispartition, not
one keyed on a path pattern. Corrected, and the wiring residual added beside it.
- The file split left two comments pointing at the file the real-git tests are no
longer in, and one saying "every test above" where there is now nothing above.
- A drifting "1259 tests" figure — the class this PR already swept out once.
- The TS/C#-guards scope item had grown into "A, B and C and D and its sibling"
across four over-long lines; rewritten as a four-item list.
Rebased onto
|
||
|
|
157d16df67 |
fix(819): the Docker stage needs the git BINARY excluded too, not just the index
Round 8 found a BLOCKER, and it was my verification that was wrong rather than an argument. The previous commit re-armed `npm test` in the web-build stage and excluded the one file that needs a git CHECKOUT. It did not exclude the file added in round 6 that needs the git BINARY: `trackedSourceFiles`' real-repository tests shell out to `git` to prove the derivation by executing it, and `node:22-bookworm-slim` ships no git. So `docker build` would have failed on every push to `main` and every `v*` tag — no image ships. Why I did not catch it: every "gitless replica" I ran deleted `.git` and left the git binary on `PATH`. That reproduces one of the two preconditions. Re-measured with `PATH` stripped, the previous head gives `spawnSync git ENOENT`, `Test Files 1 failed | 116 passed`. The Dockerfile comment stated the right premise — "no `.git`, AND node:22-bookworm-slim ships no git binary" — two lines above the line that only acted on the first half. The real-git block is now its own file, `trackedSourceFiles.realgit.test.ts`, so excluding it costs two tests rather than the thirteen injected-runner ones that run fine with no git at all. Both exclusions are named in the Dockerfile with their DIFFERENT reasons, and with the instruction to verify any change there with the binary off `PATH`. MEASURED in a replica with neither `.git` nor `git`: 117 files / 1225 tests pass, lint, typecheck and build all exit 0. Also from round 8: - `docs/testing.md`'s row asserted the suite "cannot run against an exported tree with no index" and that the Dockerfile "no longer runs it" — both false at the previous head. It now distinguishes the checkout requirement from the binary requirement, which is the distinction the blocker turned on. - Two clauses this PR added had no proof and MEASURED green when disarmed: the trailing-slash restriction in `unaccountedWalkedPaths` (without it every `others` entry becomes a prefix mask) and the plugin's dedupe. Both now have fixtures, and both mutations redden by name. - The dedupe's stated rationale was wrong: duplicates appear on both sides of the ratio the floor computes, so they cancel. Re-stated as tidiness, with the measurement, and "three times" corrected to two-or-three (a both-added conflict has two stages). - Three JSDoc blocks were stacked above one function, so two of them documented functions defined 15 and 50 lines below and attached to the wrong ones. Pure reordering, plus the blank lines that were detaching them. - `vite-env.d.ts` named the wrong mechanism for its loud-failure claim: a renamed field yields an empty Set, caught by the anti-vacuity floor rather than by a throw at first read. - The Dockerfile no longer hardcodes a test-file count that nothing reddens on. Refs: #819 |