Closed
opened 2026-07-07 10:45:06 +02:00 by timothy
·
3 comments
No Branch/Tag Specified
main
renovate/dotnet-monorepo
renovate/meziantou.analyzer-3.x
renovate/lucene.net
renovate/sqlitepclraw.bundle_e_sqlite3-3.x
renovate/cliwrap-3.x
913-scripted-playout-401
release/v26.15.0-notes
issue-806-guard-populations
scratch/767b-poisoned
scratch/767b-control
release/v26.14.0-notes
release/v26.14.0
docs/510-skill-logo-bug-policy
fix/510-watermark-resolution-policy
fix/629-verdict-classifier-falseopens
fix/609-decisions-edit-token-scope
issue-135-clear-to-none
release/v26.12.0-notes
fix/409b-lastscan-api-parity
fix/401-updatechannel-mirror-422
fix/327-playlist-rename-validation
fix/410-scancancel-log-level
fix/409-447-librariesscreen-neverscanned
fix/338-zap-exit-code
fix/367-plex-budget-message
fix/310-debom-legacy-cs
ci/604-lane-rebalance
feat/388-design-mirror
feat/247-test-ownership
feat/247-primary-action
feat/357-player-owned-playback
feat/357-jellyfin-plugin-poc
fix/289-mcp-hardening
issue58-mcp
feat/244-channels-extract
ci/auto-bump-prod-compose
feat/multi-rerun-collections-api
feat/collections-api
feat/quick-wins
feat/185-docs-part2
feat/140-collections-screen
feat/146-channel-edit
feat/147-classic-ui-link
issue22-renovate-dashboard
feat/91-cutover
feat/63-composite-create
feat/65-library-browse
feat/85-epg
feat/86-schedule-editor
feat/109-dashboard-data
feat/99-session-tracking
fix/dockerfile-node-tag
feat/59-spa-foundation
docs/59-ui-redesign-brief
feat/102-json-guide
feat/111-schedule-durations
feat/104-artwork-upload
feat/103-media-sources-api
feat/playouts-read-api
feat/108-health-api
feat/105-picker-list-endpoints
issue-97-channel-state-api
issue42-jellyfin-musicvideos
issue46-rest-api-error-contract
dependabot/nuget/ErsatzTV.FFmpeg.Tests/multi-d307a2e06f
qsv-improvements
hdr-vulkan-cuda-test
v26.16.0
v26.15.0
v26.14.0
v26.13.0
v26.12.0
v26.11.0
v26.10.0
v26.9.0
v26.8.0
v26.7.0
blazor-final
v26.6.0
v26.5.0
v26.4.0
v26.3.1
v26.3.0
v26.2.0
v26.1.1
v26.1.0
v25.9.0
v25.8.0
v25.7.1
v25.7.0
v25.6.0
v25.5.0
v25.4.0
v25.3.1
v25.3.0
v25.2.0
v25.1.0
v0.8.8-beta
v0.8.7-beta
v0.8.6-beta
v0.8.5-beta
v0.8.4-beta
v0.8.3-beta
v0.8.2-beta
v0.8.1-beta
v0.8.0-beta
v0.7.9-beta
v0.7.8-beta
v0.7.7-beta
v0.7.6-beta
v0.7.5-beta
v0.7.4-beta
v0.7.3-beta
v0.7.2-beta
v0.7.1-beta
v0.7.0-beta
v0.6.9-beta
v0.6.8-beta
v0.6.7-beta
v0.6.6-beta
v0.6.5-beta
v0.6.4-beta
v0.6.3-beta
v0.6.2-beta
v0.6.1-beta
v0.6.0-beta
v0.5.8-beta
v0.5.7-beta
v0.5.6-beta
v0.5.5-beta
v0.5.4-beta
v0.5.3-beta
v0.5.2-beta
v0.5.1-beta
v0.5.0-beta
v0.4.5-alpha
v0.4.4-alpha
v0.4.3-alpha
v0.4.2-alpha
v0.4.1-alpha
v0.4.0-alpha
v0.3.8-alpha
v0.3.7-alpha
develop
v0.3.6-alpha
v0.3.5-alpha
v0.3.4-alpha
v0.3.3-alpha
v0.3.2-alpha
v0.3.1-alpha
v0.3.0-alpha
v0.2.5-alpha
v0.2.4-alpha
v0.2.3-alpha
v0.2.2-alpha
v0.2.1-alpha
v0.2.0-alpha
v0.1.5-alpha
v0.1.4-alpha
v0.1.3-alpha
v0.1.2-alpha
v0.1.1-alpha
v0.1.0-alpha
v0.0.62-alpha
v0.0.61-alpha
v0.0.60-alpha
v0.0.59-alpha
v0.0.58-alpha
v0.0.57-alpha
v0.0.56-alpha
v0.0.55-alpha
v0.0.54-alpha
v0.0.53-alpha
v0.0.52-alpha
v0.0.51-alpha
v0.0.50-alpha
v0.0.49-prealpha
v0.0.48-prealpha
v0.0.47-prealpha
v0.0.46-prealpha
v0.0.45-prealpha
v0.0.44-prealpha
v0.0.43-prealpha
v0.0.42-prealpha
v0.0.41-prealpha
v0.0.40-prealpha
v0.0.39-prealpha
v0.0.38-prealpha
v0.0.37-prealpha
v0.0.36-prealpha
v0.0.35-prealpha
v0.0.34-prealpha
v0.0.33-prealpha
v0.0.32-prealpha
v0.0.31-prealpha
v0.0.30-prealpha
v0.0.29-prealpha
v0.0.28-prealpha
v0.0.27-prealpha
v0.0.26-prealpha
v0.0.25-prealpha
v0.0.24-prealpha
v0.0.23-prealpha
v0.0.22-prealpha
v0.0.21-prealpha
v0.0.20-prealpha
v0.0.19-prealpha
v0.0.18-prealpha
v0.0.17-prealpha
v0.0.16-prealpha
v0.0.15-prealpha
v0.0.14-prealpha
v0.0.13-prealpha
v0.0.12-prealpha
v0.0.11-prealpha
v0.0.10-prealpha
v0.0.9-prealpha
v0.0.8-prealpha
v0.0.7-prealpha
v0.0.6-prealpha
v0.0.5-prealpha
v0.0.4-prealpha
v0.0.3-prealpha
v0.0.2-prealpha
v0.0.1-prealpha
Labels
Clear labels
ad-hoc
api
bug
ci-cd
content
dependencies
enhancement
frontend
in-progress
jellyfin
parked
priority: high
priority: low
priority: medium
review
security
One-off / ad-hoc work not tracked by a dedicated issue
REST API / HTTP endpoints
Something isn't working
Build, test, deploy pipeline
Channel content / schedules / playlists
Dependency updates (Renovate)
New feature or improvement
ChicoryTV React SPA frontend
Claimed by an active session — do not pick up
Jellyfin tuner / IPTV integration
Excluded from automatic queue pickup; work only when explicitly selected
Adversarial review finding
Security / vulnerability fix
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
No Assignees
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: timothy/ersatztv#146
Reference in New Issue
Block a user
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
Blocking sub-issue for #91 (Blazor retirement, phase b). Recon (2026-07-07) found this functionality exists only in the legacy Blazor UI — deleting Blazor before the SPA covers it would remove the feature. Part of epic #59.
Blazor routes covered:
/channels/{id}(full channel editor) and/channels/numbers(bulk renumbering). The SPA Channels screen lists/monitors and the builder creates; editing an existing channel end-to-end needs a home.UX review of the #91 root-flip PR found a live dead-end that makes this issue more urgent: the SPA Channels screen's edit pencil navigates to
/app/new-channel?edit={id}, butChannelBuilderScreennever reads theeditquery param — it silently opens a blank new-channel wizard. Once root redirects to the SPA this becomes the primary edit path users hit. Interim options: honoredit=in the builder, or repoint the pencil at Blazor's/channels/{id}until parity lands.Scope call (2026-07-07, pre-implementation): going with a dedicated ChannelEditScreen, not builder hydration.
Recon findings:
ChannelBuilder.tsxis a lineup-centric create-only workspace (~40 pieces ofuseState, submits the compositePOST /api/channels/from-lineup). It has no hydration path and its model doesn't map onto editing an existing channel's settings — retrofitting an edit mode would be invasive and risky.PUT /api/channels/{id}(UpdateChannelRequest) is exactlyGET /api/channels/{id}(ChannelViewModel) minus read-onlyId/PlayoutCount. Hydrate-then-PUT is trivial with a form screen./app/new-channel?edit={id}that nothing consumes — will repoint it at the new edit route.SettingsScreen(draft/saved state, section rail, save pill, existing form primitives) and cover the full BlazorChannelEditor.razorfield set.Gap found: Blazor's editor exposes
ExternalLogoUrl, which does NOT exist onChannelViewModel/UpdateChannelRequest— the JSON contract can't set an external logo URL today. Logo upload works via the artwork upload API (#104). Will note/file a follow-up rather than widen this PR to the backend contract./channels/numbers(bulk renumbering): the SPA already exposesbulkRenumberChannelsvia the Renumber toolbar action on selected channels (sequential from a starting number). That covers the core parity use-case; the Blazor drag-to-reorder screen is a nicer affordance but not required for #91 phase (b). Deferring drag-to-reorder to a follow-up unless review disagrees.Closed via PR #154 (merged to main).
Done: dedicated
ChannelEditScreenat/app/edit-channel/{id}(scope call above: builder hydration rejected). Hydrate-then-PUT on GET/PUT /api/channels/{id}; full ChannelEditor.razor field parity in a 6-section rail (identity, playout source/mode incl. Mirror conditionals + generated-with-playout lock, streaming/FFmpeg profile/watermark with HLS-Direct lock, stream selector default/custom branch, music video credits gating, logo preview+upload, fallback filler). Channel-table edit pencil repointed from the dead?edit=URL.Files: web/src/screens/ChannelEditScreen.tsx (+tests), web/src/api/channels.ts (getChannelById/updateChannel +tests), web/src/App.tsx (route + pencil).
Verification: 152 web tests green; tsc/eslint/vite build clean; live E2E against a real server (PUT/GET round-trip persisted + reverted, 404 path). Adversarial review SHIP; should-fixes applied in
1f3385a2(Enabled-off now forces ShowInEpg off — backend 422s otherwise; keyed edit route; full-body PUT assertion).Deferred:
/channels/numbersdrag-to-reorder — existing Renumber toolbar accepted as parity (see scope comment).ExternalLogoUrl— absent from the JSON contract (ChannelViewModel/UpdateChannelRequest); backend gap, not widened here.TimeSpan note: the SPA's playout-offset math uses total hours and round-trips the "c" format incl. days — fixing a latent Blazor display bug (
PlayoutOffset?.Hoursreads only the hours component).