Closed
opened 2026-07-07 18:51:47 +02:00 by timothy
·
2 comments
No Branch/Tag Specified
main
renovate/dotnet-monorepo
renovate/meziantou.analyzer-3.x
renovate/lucene.net
renovate/sqlitepclraw.bundle_e_sqlite3-3.x
renovate/cliwrap-3.x
913-scripted-playout-401
release/v26.15.0-notes
issue-806-guard-populations
scratch/767b-poisoned
scratch/767b-control
release/v26.14.0-notes
release/v26.14.0
docs/510-skill-logo-bug-policy
fix/510-watermark-resolution-policy
fix/629-verdict-classifier-falseopens
fix/609-decisions-edit-token-scope
issue-135-clear-to-none
release/v26.12.0-notes
fix/409b-lastscan-api-parity
fix/401-updatechannel-mirror-422
fix/327-playlist-rename-validation
fix/410-scancancel-log-level
fix/409-447-librariesscreen-neverscanned
fix/338-zap-exit-code
fix/367-plex-budget-message
fix/310-debom-legacy-cs
ci/604-lane-rebalance
feat/388-design-mirror
feat/247-test-ownership
feat/247-primary-action
feat/357-player-owned-playback
feat/357-jellyfin-plugin-poc
fix/289-mcp-hardening
issue58-mcp
feat/244-channels-extract
ci/auto-bump-prod-compose
feat/multi-rerun-collections-api
feat/collections-api
feat/quick-wins
feat/185-docs-part2
feat/140-collections-screen
feat/146-channel-edit
feat/147-classic-ui-link
issue22-renovate-dashboard
feat/91-cutover
feat/63-composite-create
feat/65-library-browse
feat/85-epg
feat/86-schedule-editor
feat/109-dashboard-data
feat/99-session-tracking
fix/dockerfile-node-tag
feat/59-spa-foundation
docs/59-ui-redesign-brief
feat/102-json-guide
feat/111-schedule-durations
feat/104-artwork-upload
feat/103-media-sources-api
feat/playouts-read-api
feat/108-health-api
feat/105-picker-list-endpoints
issue-97-channel-state-api
issue42-jellyfin-musicvideos
issue46-rest-api-error-contract
dependabot/nuget/ErsatzTV.FFmpeg.Tests/multi-d307a2e06f
qsv-improvements
hdr-vulkan-cuda-test
v26.16.0
v26.15.0
v26.14.0
v26.13.0
v26.12.0
v26.11.0
v26.10.0
v26.9.0
v26.8.0
v26.7.0
blazor-final
v26.6.0
v26.5.0
v26.4.0
v26.3.1
v26.3.0
v26.2.0
v26.1.1
v26.1.0
v25.9.0
v25.8.0
v25.7.1
v25.7.0
v25.6.0
v25.5.0
v25.4.0
v25.3.1
v25.3.0
v25.2.0
v25.1.0
v0.8.8-beta
v0.8.7-beta
v0.8.6-beta
v0.8.5-beta
v0.8.4-beta
v0.8.3-beta
v0.8.2-beta
v0.8.1-beta
v0.8.0-beta
v0.7.9-beta
v0.7.8-beta
v0.7.7-beta
v0.7.6-beta
v0.7.5-beta
v0.7.4-beta
v0.7.3-beta
v0.7.2-beta
v0.7.1-beta
v0.7.0-beta
v0.6.9-beta
v0.6.8-beta
v0.6.7-beta
v0.6.6-beta
v0.6.5-beta
v0.6.4-beta
v0.6.3-beta
v0.6.2-beta
v0.6.1-beta
v0.6.0-beta
v0.5.8-beta
v0.5.7-beta
v0.5.6-beta
v0.5.5-beta
v0.5.4-beta
v0.5.3-beta
v0.5.2-beta
v0.5.1-beta
v0.5.0-beta
v0.4.5-alpha
v0.4.4-alpha
v0.4.3-alpha
v0.4.2-alpha
v0.4.1-alpha
v0.4.0-alpha
v0.3.8-alpha
v0.3.7-alpha
develop
v0.3.6-alpha
v0.3.5-alpha
v0.3.4-alpha
v0.3.3-alpha
v0.3.2-alpha
v0.3.1-alpha
v0.3.0-alpha
v0.2.5-alpha
v0.2.4-alpha
v0.2.3-alpha
v0.2.2-alpha
v0.2.1-alpha
v0.2.0-alpha
v0.1.5-alpha
v0.1.4-alpha
v0.1.3-alpha
v0.1.2-alpha
v0.1.1-alpha
v0.1.0-alpha
v0.0.62-alpha
v0.0.61-alpha
v0.0.60-alpha
v0.0.59-alpha
v0.0.58-alpha
v0.0.57-alpha
v0.0.56-alpha
v0.0.55-alpha
v0.0.54-alpha
v0.0.53-alpha
v0.0.52-alpha
v0.0.51-alpha
v0.0.50-alpha
v0.0.49-prealpha
v0.0.48-prealpha
v0.0.47-prealpha
v0.0.46-prealpha
v0.0.45-prealpha
v0.0.44-prealpha
v0.0.43-prealpha
v0.0.42-prealpha
v0.0.41-prealpha
v0.0.40-prealpha
v0.0.39-prealpha
v0.0.38-prealpha
v0.0.37-prealpha
v0.0.36-prealpha
v0.0.35-prealpha
v0.0.34-prealpha
v0.0.33-prealpha
v0.0.32-prealpha
v0.0.31-prealpha
v0.0.30-prealpha
v0.0.29-prealpha
v0.0.28-prealpha
v0.0.27-prealpha
v0.0.26-prealpha
v0.0.25-prealpha
v0.0.24-prealpha
v0.0.23-prealpha
v0.0.22-prealpha
v0.0.21-prealpha
v0.0.20-prealpha
v0.0.19-prealpha
v0.0.18-prealpha
v0.0.17-prealpha
v0.0.16-prealpha
v0.0.15-prealpha
v0.0.14-prealpha
v0.0.13-prealpha
v0.0.12-prealpha
v0.0.11-prealpha
v0.0.10-prealpha
v0.0.9-prealpha
v0.0.8-prealpha
v0.0.7-prealpha
v0.0.6-prealpha
v0.0.5-prealpha
v0.0.4-prealpha
v0.0.3-prealpha
v0.0.2-prealpha
v0.0.1-prealpha
Labels
Clear labels
ad-hoc
api
bug
ci-cd
content
dependencies
enhancement
frontend
in-progress
jellyfin
parked
priority: high
priority: low
priority: medium
review
security
One-off / ad-hoc work not tracked by a dedicated issue
REST API / HTTP endpoints
Something isn't working
Build, test, deploy pipeline
Channel content / schedules / playlists
Dependency updates (Renovate)
New feature or improvement
ChicoryTV React SPA frontend
Claimed by an active session — do not pick up
Jellyfin tuner / IPTV integration
Excluded from automatic queue pickup; work only when explicitly selected
Adversarial review finding
Security / vulnerability fix
Milestone
No items
No Milestone
Projects
Clear projects
No projects
No Assignees
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: timothy/ersatztv#172
Reference in New Issue
Block a user
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
Non-blocking findings from the adversarial reviews of PRs #170/#171 and the S2 templates slice, consolidated so they don't get lost. None block #144 parity.
namein Create/Replace/Copy bodies → NRE → 500 across Block/Template (and likely future Deco) request DTOs: they lack#nullableso the spec marks strings nullable, and handlers dorequest.Name.Length. Fix class-wide:[property: Required]on the request records or IsNullOrEmpty guards in ToCommand.GetAllBlocksHandler/GetAllTemplatesHandlersynthesize a dummy row per empty group (id = −groupId, name "(none)", minutes 0) to drive the Blazor grouped table. TemplatesScreen filtersid > 0client-side; BlocksScreen doesn't. Prefer filtering at the controllers (SPA renders empty groups from the groups endpoint anyway).BlockTemplateItemis a record; the overlap loop skips on value-equality, so two identical rows (same blockId+startTime) both persist. SPA's index-based check catches it; API-only gap. Upstream-shared.ReplaceProgramScheduleItems).AnyAsync-style exists query family would cover all controllers.Name=missing on PlayoutController Create/Delete/Update (pre-existing) — align when touching.From earlier sessions (still relevant):
GET /api/searchdispatches its 10 per-kind queries serially (Task.WhenAll safe); Trakt matched-items link still points at classic /search;/api/logs+/api/troubleshoot/infounauthenticated GETs.Disposition (2026-07-13 session — verified against
main) — PR #325Most findings were resolved or ratified deliberate since 2026-07-07; three were genuinely live and are fixed:
UpdateFFmpegProfile) + 1 empty-name persist (CreatePlaylist, DTO coalesces null→"").OperationIdOpenApiTransformer(#197 Bundle C) synthesizes stable operationIds; addingName=risks renaming generated SPA client methods./api/logs+/api/troubleshoot/infonow[RequiresAuthentication]; Trakt link points at/app/search;/api/searchalreadyTask.WhenAll./api/v1versioning sweep) after it merged mid-session; create-group routes are now/api/v1/.../groups.Done-when
2e4e07a2)2e4e07a2— all jobs incl. Build & test, Formatting, EF migration, API docs)claiming — session started 2026-07-13. Picked as the highest-ranked pickable #197 gate-cluster item (
review+api+bug); it's the "other in-flight/apiwork" that should land before #286's route sweep (which is claimed but sequenced LAST by design).Heads-up on staleness: these findings are from 2026-07-07 and a lot of API hardening has landed since. On a first read of
docs/api-conventions.md, several are now ratified deliberate or already fixed:Name=) → moot:OperationIdOpenApiTransformer(#197 Bundle C) synthesizes stable operationIds for the ~90Name=-less ops./api/logs+/api/troubleshoot/infotail → fixed: §9 putsTroubleshoot/Logs/Settings/Maintenancebehind[RequiresAuthentication](#280–#285/#295).Verifying every finding against current
mainbefore implementing; will fix only what's genuinely live (candidate residue: #1 null-name→500, #3 duplicate-item overlap bypass, the Trakt matched-items link, cosmeticProducesResponseTypetrims) and close with a per-finding disposition.Coordination note for the #286 owner: this touches controllers/DTOs/handlers (Block/Template/Playout) but only method-body validation + attributes, not route strings — low overlap with your
/api/v1route-string sweep, and it's meant to precede it.Closed — PR #325 merged to
main(2e4e07a2, fast-forward)What was done. Cleared the still-live findings from this consolidated list; most had been resolved or ratified deliberate since 2026-07-07 (verified against
mainfirst, rather than fixing stale nits).Root cause (finding #1, the real bug). Request DTOs carry no
#nullablecontext (api-conventions §2), so astring Namebindsnullfromname: null/an omitted field; there's no implicit[Required], no FluentValidation validator for these commands, and no global exception filter — so a handler doingrequest.Name.Lengththrew an unguardedNullReferenceExceptionthat surfaced as HTTP 500. The group-create + copy handlers were already safe because they route the name through the null-safeNotEmpty/NotLongerThancombinator; the create/replace handlers used a raw.Lengthcheck. Fixed class-wide with astring.IsNullOrWhiteSpace(...) ||guard (minimal blast radius, preserves each handler's error message + 422 mapping).Fixed (3 live findings):
UpdateFFmpegProfile;CreatePlaylistwas an empty-name persist, not a 500). Now 422; also rejects empty/whitespace names.ProducesResponseTypetrimmed from all 4 create-group actions.Dispositioned (not fixed): #2, #4 → deliberate-documented (api-conventions §8/§3b); #7 → moot (
OperationIdOpenApiTransformer, #197 Bundle C); #5 → deferred perf nit; the auth/Trakt/search tail → already fixed onmain.Files changed. 10 handlers (
ErsatzTV.Application/{Scheduling,MediaCollections,FFmpegProfiles}/Commands/*Handler.cs); 4 controllers (Block/Template/Deco/DecoTemplate — 404 trims);ErsatzTV.Tests/Application/Scheduling/Issue172HardeningTests.cs(new, 19 cases),FFmpegProfileHandlerTests.cs,ApiErrorResponseMetadataTests.cs;docs/decisions.md,docs/api-conventions.md(§3b); regeneratedv1.json.Deferred / follow-ups. #327 (playlist rename does no name validation — pre-existing create/update asymmetry, backlog,
priority: low).Docs updated (same PR).
decisions.mdentry (2026-07-13) +api-conventions.md§3b handler-hardening bullet (dereferencing a requeststringis a latent 500).Review. Cold zero-context adversarial pass caught a real CI-red blocker (stale metadata-test assertions after the 404 trim) + confirmed the fixes; fix-commit re-reviewed → MERGEABLE. Rebased onto #286 (
/api/v1sweep) mid-session; final head2e4e07a2, full suite 1583/0, all CI green.