feat: quick wins — security-registry scan, Trakt SPA link, parallel search, dead "New Group" sweep #187

Merged
timothy merged 2 commits from feat/quick-wins into main 2026-07-08 08:03:25 +02:00
Owner

Four small independent improvements in one PR.

  • #184: ApiControllerSecurityTests now scans the ErsatzTV.Controllers.Api assembly (36 controllers) instead of a hand-maintained array — 9 were unlisted (ArtworkUploadController POST + ChannelTemplateController POST/PUT/DELETE were unchecked); both pass under the global ApiKey filter, no exemption needed. ScannerController (non-ControllerBase, deliberately exempt) correctly retained. docs/api-conventions.md §6 updated for the scan behavior.
  • Trakt matched-items link → SPA /app/search?query=trakt_list:{id} (was Classic UI new-tab), matching the ImageBrowser IconButton pattern.
  • GET /api/search runs its 10 per-kind queries in parallel via Task.WhenAll — each ForKind gets its own TvContext via IDbContextFactory, Lucene reads are concurrent-safe. Response contract unchanged (no OpenAPI drift).
  • Dead "New Group" buttons removed from blocks/templates/decos/deco-templates (the shared header button has no onClick; set primaryAction: ' like media/search/trash).

Verified: solution build, ErsatzTV.Tests 828/828, web typecheck+lint+build+vitest 330/330, no v1.json/v1.d.ts drift.

fixes #184

🤖 Generated with Claude Code

Four small independent improvements in one PR. - **#184**: `ApiControllerSecurityTests` now scans the `ErsatzTV.Controllers.Api` assembly (36 controllers) instead of a hand-maintained array — 9 were unlisted (`ArtworkUploadController` POST + `ChannelTemplateController` POST/PUT/DELETE were unchecked); both pass under the global ApiKey filter, no exemption needed. `ScannerController` (non-`ControllerBase`, deliberately exempt) correctly retained. `docs/api-conventions.md` §6 updated for the scan behavior. - **Trakt matched-items link** → SPA `/app/search?query=trakt_list:{id}` (was Classic UI new-tab), matching the ImageBrowser IconButton pattern. - **GET /api/search** runs its 10 per-kind queries in parallel via `Task.WhenAll` — each `ForKind` gets its own `TvContext` via `IDbContextFactory`, Lucene reads are concurrent-safe. Response contract unchanged (no OpenAPI drift). - **Dead "New Group" buttons** removed from blocks/templates/decos/deco-templates (the shared header button has no onClick; set `primaryAction: '` like media/search/trash). Verified: solution build, `ErsatzTV.Tests` 828/828, web typecheck+lint+build+vitest 330/330, no v1.json/v1.d.ts drift. fixes #184 🤖 Generated with [Claude Code](https://claude.com/claude-code)
timothy added 1 commit 2026-07-08 07:49:09 +02:00
feat: quick wins — security-registry scan, Trakt SPA link, parallel search, dead "New Group" sweep
Build ErsatzTV Image / Build & test (.NET) (pull_request) Successful in 4m25s
Build ErsatzTV Image / EF migration integrity (SQLite + MySql) (pull_request) Successful in 4m33s
Build ErsatzTV Image / Build & push image (amd64) (pull_request) Has been skipped
9f73542296
- #184: ApiControllerSecurityTests scans ErsatzTV.Controllers.Api assembly
  instead of a hand-maintained array (9 controllers were unlisted; 2 mutating)
- Trakt matched-items link now navigates to SPA /app/search (was Classic UI)
- GET /api/search runs its 10 per-kind queries in parallel (context-safe)
- Remove dead "New Group" header buttons from blocks/templates/decos/deco-templates
- docs/api-conventions.md §6 updated for the assembly-scan change

fixes #184

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
timothy added 1 commit 2026-07-08 07:51:09 +02:00
docs: correct §6 wording — scan matches controller classes, not ControllerBase subtypes (review)
Build ErsatzTV Image / Build & test (.NET) (pull_request) Successful in 4m31s
Build ErsatzTV Image / EF migration integrity (SQLite + MySql) (pull_request) Successful in 4m33s
Build ErsatzTV Image / Build & push image (amd64) (pull_request) Has been skipped
316b673c3b
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
timothy merged commit 311411fa38 into main 2026-07-08 08:03:25 +02:00
Sign in to join this conversation.