Refactor ChicoryTV App.tsx into screen-owned modules and a small app shell #243
Closed
opened 2026-07-11 12:49:19 +02:00 by timothy
·
5 comments
No Branch/Tag Specified
main
renovate/dotnet-monorepo
renovate/meziantou.analyzer-3.x
renovate/lucene.net
renovate/sqlitepclraw.bundle_e_sqlite3-3.x
renovate/cliwrap-3.x
913-scripted-playout-401
release/v26.15.0-notes
issue-806-guard-populations
scratch/767b-poisoned
scratch/767b-control
release/v26.14.0-notes
release/v26.14.0
docs/510-skill-logo-bug-policy
fix/510-watermark-resolution-policy
fix/629-verdict-classifier-falseopens
fix/609-decisions-edit-token-scope
issue-135-clear-to-none
release/v26.12.0-notes
fix/409b-lastscan-api-parity
fix/401-updatechannel-mirror-422
fix/327-playlist-rename-validation
fix/410-scancancel-log-level
fix/409-447-librariesscreen-neverscanned
fix/338-zap-exit-code
fix/367-plex-budget-message
fix/310-debom-legacy-cs
ci/604-lane-rebalance
feat/388-design-mirror
feat/247-test-ownership
feat/247-primary-action
feat/357-player-owned-playback
feat/357-jellyfin-plugin-poc
fix/289-mcp-hardening
issue58-mcp
feat/244-channels-extract
ci/auto-bump-prod-compose
feat/multi-rerun-collections-api
feat/collections-api
feat/quick-wins
feat/185-docs-part2
feat/140-collections-screen
feat/146-channel-edit
feat/147-classic-ui-link
issue22-renovate-dashboard
feat/91-cutover
feat/63-composite-create
feat/65-library-browse
feat/85-epg
feat/86-schedule-editor
feat/109-dashboard-data
feat/99-session-tracking
fix/dockerfile-node-tag
feat/59-spa-foundation
docs/59-ui-redesign-brief
feat/102-json-guide
feat/111-schedule-durations
feat/104-artwork-upload
feat/103-media-sources-api
feat/playouts-read-api
feat/108-health-api
feat/105-picker-list-endpoints
issue-97-channel-state-api
issue42-jellyfin-musicvideos
issue46-rest-api-error-contract
dependabot/nuget/ErsatzTV.FFmpeg.Tests/multi-d307a2e06f
qsv-improvements
hdr-vulkan-cuda-test
v26.16.0
v26.15.0
v26.14.0
v26.13.0
v26.12.0
v26.11.0
v26.10.0
v26.9.0
v26.8.0
v26.7.0
blazor-final
v26.6.0
v26.5.0
v26.4.0
v26.3.1
v26.3.0
v26.2.0
v26.1.1
v26.1.0
v25.9.0
v25.8.0
v25.7.1
v25.7.0
v25.6.0
v25.5.0
v25.4.0
v25.3.1
v25.3.0
v25.2.0
v25.1.0
v0.8.8-beta
v0.8.7-beta
v0.8.6-beta
v0.8.5-beta
v0.8.4-beta
v0.8.3-beta
v0.8.2-beta
v0.8.1-beta
v0.8.0-beta
v0.7.9-beta
v0.7.8-beta
v0.7.7-beta
v0.7.6-beta
v0.7.5-beta
v0.7.4-beta
v0.7.3-beta
v0.7.2-beta
v0.7.1-beta
v0.7.0-beta
v0.6.9-beta
v0.6.8-beta
v0.6.7-beta
v0.6.6-beta
v0.6.5-beta
v0.6.4-beta
v0.6.3-beta
v0.6.2-beta
v0.6.1-beta
v0.6.0-beta
v0.5.8-beta
v0.5.7-beta
v0.5.6-beta
v0.5.5-beta
v0.5.4-beta
v0.5.3-beta
v0.5.2-beta
v0.5.1-beta
v0.5.0-beta
v0.4.5-alpha
v0.4.4-alpha
v0.4.3-alpha
v0.4.2-alpha
v0.4.1-alpha
v0.4.0-alpha
v0.3.8-alpha
v0.3.7-alpha
develop
v0.3.6-alpha
v0.3.5-alpha
v0.3.4-alpha
v0.3.3-alpha
v0.3.2-alpha
v0.3.1-alpha
v0.3.0-alpha
v0.2.5-alpha
v0.2.4-alpha
v0.2.3-alpha
v0.2.2-alpha
v0.2.1-alpha
v0.2.0-alpha
v0.1.5-alpha
v0.1.4-alpha
v0.1.3-alpha
v0.1.2-alpha
v0.1.1-alpha
v0.1.0-alpha
v0.0.62-alpha
v0.0.61-alpha
v0.0.60-alpha
v0.0.59-alpha
v0.0.58-alpha
v0.0.57-alpha
v0.0.56-alpha
v0.0.55-alpha
v0.0.54-alpha
v0.0.53-alpha
v0.0.52-alpha
v0.0.51-alpha
v0.0.50-alpha
v0.0.49-prealpha
v0.0.48-prealpha
v0.0.47-prealpha
v0.0.46-prealpha
v0.0.45-prealpha
v0.0.44-prealpha
v0.0.43-prealpha
v0.0.42-prealpha
v0.0.41-prealpha
v0.0.40-prealpha
v0.0.39-prealpha
v0.0.38-prealpha
v0.0.37-prealpha
v0.0.36-prealpha
v0.0.35-prealpha
v0.0.34-prealpha
v0.0.33-prealpha
v0.0.32-prealpha
v0.0.31-prealpha
v0.0.30-prealpha
v0.0.29-prealpha
v0.0.28-prealpha
v0.0.27-prealpha
v0.0.26-prealpha
v0.0.25-prealpha
v0.0.24-prealpha
v0.0.23-prealpha
v0.0.22-prealpha
v0.0.21-prealpha
v0.0.20-prealpha
v0.0.19-prealpha
v0.0.18-prealpha
v0.0.17-prealpha
v0.0.16-prealpha
v0.0.15-prealpha
v0.0.14-prealpha
v0.0.13-prealpha
v0.0.12-prealpha
v0.0.11-prealpha
v0.0.10-prealpha
v0.0.9-prealpha
v0.0.8-prealpha
v0.0.7-prealpha
v0.0.6-prealpha
v0.0.5-prealpha
v0.0.4-prealpha
v0.0.3-prealpha
v0.0.2-prealpha
v0.0.1-prealpha
Labels
Clear labels
ad-hoc
api
bug
ci-cd
content
dependencies
enhancement
frontend
in-progress
jellyfin
parked
priority: high
priority: low
priority: medium
review
security
One-off / ad-hoc work not tracked by a dedicated issue
REST API / HTTP endpoints
Something isn't working
Build, test, deploy pipeline
Channel content / schedules / playlists
Dependency updates (Renovate)
New feature or improvement
ChicoryTV React SPA frontend
Claimed by an active session — do not pick up
Jellyfin tuner / IPTV integration
Excluded from automatic queue pickup; work only when explicitly selected
Adversarial review finding
Security / vulnerability fix
Milestone
No items
No Milestone
ChicoryTV modularization
Projects
Clear projects
No projects
No Assignees
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: timothy/ersatztv#243
Reference in New Issue
Block a user
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
Context
web/src/App.tsxis now ~3,500 lines andApp.test.tsx~4,250 lines. The file is no longer just the application root: it owns shell/navigation/theme/TopBar, route metadata and dispatch, Dashboard, Channels, Guide, Libraries, most Playouts behavior, and their helpers.The cost is behavioral coupling and review blind spots, not merely aesthetics. Recent examples:
ChannelsScreen, but an earlier empty-state return hid it on a zero-channel installation.primaryActionmetadata produced inert buttons; the partial window-event dispatch introduced for Schedules makes screen/shell ownership implicit.allowSubPathsscreens require local pathname listeners because App route state is object-reference keyed.App.test.tsxmixes shell/routing/screen behavior and one global API mock, making a local screen change expensive and easy to under-specify.Schedules and most newer screens already demonstrate the preferred pattern: one screen module with colocated tests and domain helpers.
Objective
Reduce
App.tsxto a small composition root that:Screen modules own their query hooks, mutations, helpers, state, and tests. Shell actions and navigation become explicit contracts rather than string-keyed global events.
Constraints
docs/spa-conventions.mdwhen the module/action convention is finalized.Child work
Create/track four phases under this epic:
Acceptance criteria
App.tsxcontains no domain-specific screen implementation.App.test.tsxcovers composition/routing/shell only; screen behavior is colocated.Rollback
No data or API changes. Each extraction must be independently revertible.
Tracking map
Suggested order is dependency-driven rather than numeric if active work changes: #244 once #212 is clean; #246's Dashboard/Guide portions may proceed independently but Libraries must avoid #202/#232/#235; #245 after playout lock/status work; #247 last.
Picking up the epic via phase 1 (#244). Children already filed: #244 Channels → #245 Playouts → #246 Dashboard/Guide/Libraries → #247 shell/routing. #244 extraction is held behind PR #242 (#212/#230 land on
App.tsxfirst); running read-only recon now to stage a turnkey Channels extraction. See #244 for detail.Phase 1 DONE: #244 merged (PR #249,
533c6c1e).ChannelsScreenextracted toweb/src/screens/ChannelsScreen.tsx(+ colocated test);App.tsxdown ~545 lines, retains only import + dispatch for Channels. Convention recorded in spa-conventions §6 + decisions.md (single-file screen, noweb/src/channels/sibling dir; extracted-screen own-fetch-mock test pattern). #238 (TopBar dead button) deliberately left to phase 4 (#247).Remaining: #245 Playouts (phase 2, largest/riskiest surface) → #246 Dashboard/Guide/Libraries (phase 3) → #247 shell/routing + primary-action coupling (phase 4). Each rebases off
533c6c1e.Epic refinements from the plan review (adversarial-reviewer#24, 2026-07-11) — verdict was PLAN SOUND, #244 proved the template; these two adjustments were applied to the child issues:
#246 split into two sequenced batches. Batch A (
DashboardScreen+GuideScreen) is eligible now — no #202 overlap. Batch B (LibrariesScreen) is hard-gated behind #202's merge: #202 is already in flight and churns the same App.tsx byte range (~1487-1710) +MediaSourceimports, so a concurrent Libraries extraction would conflict. (#246's original "before #202 starts or after it lands, not concurrently" now forces Libraries to wait, since #202 has started.) Source-collision only — the scan temporal logic is insulated inapi/libraries.ts.#238 promoted to a HARD prerequisite of #247 (and added to this milestone). #247's removal of the
ctv:primary-actionCustomEvent is only safe after #238 establishes a per-screen action contract — the event is the sole delivery path and only SchedulesScreen listens. #238 was drifting in backlog while gating the epic's final phase; it now needs to be scheduled before #247.Also folded into the child issues' bodies as explicit invariants (from the review): the #247 route-table must stay one stable module-level array of shared
ScreenRouteobject references (the §2allowSubPathsObject.is re-render bail depends on it) with a sub-path re-render regression test, and thenavigate/popstate/currentPathRef/activeRoutemachinery must stay co-located in the composition root (the #230 popstate re-push depends on it). #230 is confirmed settled in-code (PR #242); the heavy polling/current-guards already live inapi/*.tshooks, so #245/#246 move render code only (temporally low-risk). Suggested order unchanged: #245 (after the now-landed lock batch; coordinate vs open #235) → #246 Batch A → #246 Batch B (post-#202) → #238 → #247.Done
What was done: all four bounded phases are complete: Channels (#244), Playouts (#245), Dashboard/Guide/Libraries (#246), and final shell/routing/primary-action ownership (#247 via PR #361).
App.tsxis a small composition root, screen behavior/tests are colocated, and the documented route, guard, subpath, and primary-action contracts are explicit and regression-tested.Root cause: n/a — planned modularization epic.
Files changed: delivered across child issues #244–#247, including extracted screen modules/tests, the final
web/src/app/shell/routing modules,web/src/primaryAction.ts, and SPA architecture docs.Verification: every child issue is closed. The final integration passed 90 web files / 775 tests, lint, typecheck/build, API sync, full .NET restore/build/test, hosted-SPA live E2E, cold adversarial review, and green CI run 648.
Deferred: none.
Follow-up issues: none.
Docs updated:
docs/spa-conventions.mdand append-onlydocs/decisions.mddescribe the final architecture and deliberate non-goals. The epic remained behavior-preserving and did not block Blazor-removal work.