TroubleshootController playback segment-wait loop doesn't check notifier.IsFailed (spins until client cancel if ffmpeg dies) #320
Closed
opened 2026-07-12 21:06:14 +02:00 by timothy
·
2 comments
No Branch/Tag Specified
main
renovate/dotnet-monorepo
renovate/meziantou.analyzer-3.x
renovate/lucene.net
renovate/sqlitepclraw.bundle_e_sqlite3-3.x
renovate/cliwrap-3.x
913-scripted-playout-401
release/v26.15.0-notes
issue-806-guard-populations
scratch/767b-poisoned
scratch/767b-control
release/v26.14.0-notes
release/v26.14.0
docs/510-skill-logo-bug-policy
fix/510-watermark-resolution-policy
fix/629-verdict-classifier-falseopens
fix/609-decisions-edit-token-scope
issue-135-clear-to-none
release/v26.12.0-notes
fix/409b-lastscan-api-parity
fix/401-updatechannel-mirror-422
fix/327-playlist-rename-validation
fix/410-scancancel-log-level
fix/409-447-librariesscreen-neverscanned
fix/338-zap-exit-code
fix/367-plex-budget-message
fix/310-debom-legacy-cs
ci/604-lane-rebalance
feat/388-design-mirror
feat/247-test-ownership
feat/247-primary-action
feat/357-player-owned-playback
feat/357-jellyfin-plugin-poc
fix/289-mcp-hardening
issue58-mcp
feat/244-channels-extract
ci/auto-bump-prod-compose
feat/multi-rerun-collections-api
feat/collections-api
feat/quick-wins
feat/185-docs-part2
feat/140-collections-screen
feat/146-channel-edit
feat/147-classic-ui-link
issue22-renovate-dashboard
feat/91-cutover
feat/63-composite-create
feat/65-library-browse
feat/85-epg
feat/86-schedule-editor
feat/109-dashboard-data
feat/99-session-tracking
fix/dockerfile-node-tag
feat/59-spa-foundation
docs/59-ui-redesign-brief
feat/102-json-guide
feat/111-schedule-durations
feat/104-artwork-upload
feat/103-media-sources-api
feat/playouts-read-api
feat/108-health-api
feat/105-picker-list-endpoints
issue-97-channel-state-api
issue42-jellyfin-musicvideos
issue46-rest-api-error-contract
dependabot/nuget/ErsatzTV.FFmpeg.Tests/multi-d307a2e06f
qsv-improvements
hdr-vulkan-cuda-test
v26.16.0
v26.15.0
v26.14.0
v26.13.0
v26.12.0
v26.11.0
v26.10.0
v26.9.0
v26.8.0
v26.7.0
blazor-final
v26.6.0
v26.5.0
v26.4.0
v26.3.1
v26.3.0
v26.2.0
v26.1.1
v26.1.0
v25.9.0
v25.8.0
v25.7.1
v25.7.0
v25.6.0
v25.5.0
v25.4.0
v25.3.1
v25.3.0
v25.2.0
v25.1.0
v0.8.8-beta
v0.8.7-beta
v0.8.6-beta
v0.8.5-beta
v0.8.4-beta
v0.8.3-beta
v0.8.2-beta
v0.8.1-beta
v0.8.0-beta
v0.7.9-beta
v0.7.8-beta
v0.7.7-beta
v0.7.6-beta
v0.7.5-beta
v0.7.4-beta
v0.7.3-beta
v0.7.2-beta
v0.7.1-beta
v0.7.0-beta
v0.6.9-beta
v0.6.8-beta
v0.6.7-beta
v0.6.6-beta
v0.6.5-beta
v0.6.4-beta
v0.6.3-beta
v0.6.2-beta
v0.6.1-beta
v0.6.0-beta
v0.5.8-beta
v0.5.7-beta
v0.5.6-beta
v0.5.5-beta
v0.5.4-beta
v0.5.3-beta
v0.5.2-beta
v0.5.1-beta
v0.5.0-beta
v0.4.5-alpha
v0.4.4-alpha
v0.4.3-alpha
v0.4.2-alpha
v0.4.1-alpha
v0.4.0-alpha
v0.3.8-alpha
v0.3.7-alpha
develop
v0.3.6-alpha
v0.3.5-alpha
v0.3.4-alpha
v0.3.3-alpha
v0.3.2-alpha
v0.3.1-alpha
v0.3.0-alpha
v0.2.5-alpha
v0.2.4-alpha
v0.2.3-alpha
v0.2.2-alpha
v0.2.1-alpha
v0.2.0-alpha
v0.1.5-alpha
v0.1.4-alpha
v0.1.3-alpha
v0.1.2-alpha
v0.1.1-alpha
v0.1.0-alpha
v0.0.62-alpha
v0.0.61-alpha
v0.0.60-alpha
v0.0.59-alpha
v0.0.58-alpha
v0.0.57-alpha
v0.0.56-alpha
v0.0.55-alpha
v0.0.54-alpha
v0.0.53-alpha
v0.0.52-alpha
v0.0.51-alpha
v0.0.50-alpha
v0.0.49-prealpha
v0.0.48-prealpha
v0.0.47-prealpha
v0.0.46-prealpha
v0.0.45-prealpha
v0.0.44-prealpha
v0.0.43-prealpha
v0.0.42-prealpha
v0.0.41-prealpha
v0.0.40-prealpha
v0.0.39-prealpha
v0.0.38-prealpha
v0.0.37-prealpha
v0.0.36-prealpha
v0.0.35-prealpha
v0.0.34-prealpha
v0.0.33-prealpha
v0.0.32-prealpha
v0.0.31-prealpha
v0.0.30-prealpha
v0.0.29-prealpha
v0.0.28-prealpha
v0.0.27-prealpha
v0.0.26-prealpha
v0.0.25-prealpha
v0.0.24-prealpha
v0.0.23-prealpha
v0.0.22-prealpha
v0.0.21-prealpha
v0.0.20-prealpha
v0.0.19-prealpha
v0.0.18-prealpha
v0.0.17-prealpha
v0.0.16-prealpha
v0.0.15-prealpha
v0.0.14-prealpha
v0.0.13-prealpha
v0.0.12-prealpha
v0.0.11-prealpha
v0.0.10-prealpha
v0.0.9-prealpha
v0.0.8-prealpha
v0.0.7-prealpha
v0.0.6-prealpha
v0.0.5-prealpha
v0.0.4-prealpha
v0.0.3-prealpha
v0.0.2-prealpha
v0.0.1-prealpha
Labels
Clear labels
ad-hoc
api
bug
ci-cd
content
dependencies
enhancement
frontend
in-progress
jellyfin
parked
priority: high
priority: low
priority: medium
review
security
One-off / ad-hoc work not tracked by a dedicated issue
REST API / HTTP endpoints
Something isn't working
Build, test, deploy pipeline
Channel content / schedules / playlists
Dependency updates (Renovate)
New feature or improvement
ChicoryTV React SPA frontend
Claimed by an active session — do not pick up
Jellyfin tuner / IPTV integration
Excluded from automatic queue pickup; work only when explicitly selected
Adversarial review finding
Security / vulnerability fix
Milestone
No items
No Milestone
Projects
Clear projects
No projects
No Assignees
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: timothy/ersatztv#320
Reference in New Issue
Block a user
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
Split out of PR #316 review (fork nit 4, ratified by Fable as a real-but-pre-existing defect, out of scope for #316).
What
In
ErsatzTV/Controllers/Api/TroubleshootController.cs, the second segment-readiness wait loop (around lines 237-253, thewhile (!hasSegments)poll) does not checknotifier.IsFailed. If ffmpeg dies after writing the HLS playlist but before the first segments appear, the loop spins until the client cancels the request.Why it matters more after #316
Pre-existing and unchanged by #316 — but #301 turned the manifest fetch into
POST /api/troubleshoot/playback/start, which now holds the request open server-side during this wait (previously hls.js held it client-side). So a hung wait ties up the request thread + keeps the troubleshooting lock until the client gives up.Fix direction
Add a
notifier.IsFailed(or exit-code) check to the loop's exit condition so a dead ffmpeg breaks the wait and returns a 422/500 (or the existing error path) promptly, releasing the lock.Priority: low (needs ffmpeg to die in a narrow window; self-heals on client cancel). Refs #316 #301.
Done-when
notifier.IsFailed/ cancellation check added to the segment-wait loop so a dead ffmpeg breaks the wait🔧 Claiming — clean self-contained Tier-5 bug pickup. Milestone tier was re-checked (selector had misread #385 as still blocked by #70, which merged today); operator opted for a clean bug instead. Fix direction is exactly as the issue states: add the missing
notifier.IsFailed(sessionId)/ cancellation check to the second (segment-wait) poll loop so a dead ffmpeg breaks the wait instead of spinning until client-cancel (holding the request thread + troubleshooting lock). Will add a regression test + a## Done-whensection, and run a cold independent review (API write-path handler touching the lock-hold window).Done — merged to main (PR #423,
de63603a)What was done: Added the missing failure/exit check to the second (segment-readiness) poll loop in
POST /api/v1/troubleshoot/playback/start. It now breaks onnotifier.IsFailed(sessionId), mirroring the first (playlist-existence) wait loop above it.Root cause: The loop's only exit condition was
!hasSegments. If ffmpeg died after writing the HLS playlist but before the first segments appeared, nothing sethasSegments, so the loop spun until the client cancelled — and since #301 moved the manifest fetch server-side, that hung request held the request thread + the troubleshooting lock the whole time. The first loop already had theIsFailed/cancellation check; the second was simply missing it (an omission, not a design choice).Files changed:
ErsatzTV/Controllers/Api/TroubleshootController.cs— break the segment-wait loop onIsFailed; the existingif (!IsFailed)gate then falls through to the terminalNotFoundProblem, releasing the thread + lock.ErsatzTV.Tests/Controllers/TroubleshootControllerTests.cs— regression testTroubleshootPlayback_Should_Return_404_And_Not_Spin_When_Ffmpeg_Fails_Before_Segments.Deliberate detail (from review): the break checks
IsFailedonly, notcancellationToken.IsCancellationRequested— theTask.Delay(ct)already throws on cancel (→ 404), and adding the cancel term would let a cancelled request fall into the Ok gate and return a spurious 200.Testing: Non-vacuous regression test with a bounded 10s cancellation deadline — negative-control-verified (removing the
IsFailedbreak makes it fail in ~10s, proving it catches the spin). Full local suite + CI green. Two cold independent review passes; all findings addressed (see PR #423Review-verdict).Docs: none required — internal behavior of an existing endpoint; route and response codes unchanged.
Deferred / follow-ups: none.