Queue selector skips milestone work and repicks completed reviewer audits #347

Closed
opened 2026-07-13 23:20:15 +02:00 by timothy · 2 comments
Owner

Problem

The low-cost ChicoryTV queue selector failed in two ways:

  1. It ranked timothy/adversarial-reviewer#20–#24 as unclaimed because those issues remained open, although each had a comment claim and posted deliverable.
  2. After those were excluded, it chose unmilestoned priority: high backlog (#344/#345) without enumerating the OPEN “ChicoryTV modularization” milestone. Live #245/#246/#247 are milestone-bound priority: medium work and therefore outrank unmilestoned backlog under #237.

Root cause

The protocol said reviewer audits were “claimed by comment only” but did not define claim lifetime or explicitly exclude posted deliverables. Its selector input also mentioned generic live milestone state without requiring enumeration of every OPEN milestone and its OPEN issues. Equal milestone/priority ordering and epic-container exclusion were not explicit, letting the selector invent fix-size/recency relevance.

Done-when

  • Canonical #237 says reviewer comment claims persist until explicit release/abandonment and posted deliverables are excluded.
  • Canonical #237 requires enumeration of every OPEN milestone and its OPEN issues plus OPEN review issues.
  • Canonical #237 ranks OPEN milestone/review work ahead of unmilestoned backlog, then by priority:.
  • Canonical #237 excludes umbrella/epic containers when eligible children are named and defines deterministic equal-tier ordering.
  • docs/handoffs/chicorytv-issue-queue.md carries the same candidate-discovery, ranking, claim, and tie-break rules.
  • Corrected live evidence makes #245 the next picker result: it is the first explicitly eligible child, OPEN, priority: medium, in the OPEN “ChicoryTV modularization” milestone; unmilestoned #345 cannot outrank it.
  • The docs-only change is reviewed or carries an explicit review exemption.
## Problem The low-cost ChicoryTV queue selector failed in two ways: 1. It ranked `timothy/adversarial-reviewer#20`–`#24` as unclaimed because those issues remained open, although each had a comment claim and posted deliverable. 2. After those were excluded, it chose unmilestoned `priority: high` backlog (#344/#345) without enumerating the OPEN “ChicoryTV modularization” milestone. Live #245/#246/#247 are milestone-bound `priority: medium` work and therefore outrank unmilestoned backlog under #237. ## Root cause The protocol said reviewer audits were “claimed by comment only” but did not define claim lifetime or explicitly exclude posted deliverables. Its selector input also mentioned generic live milestone state without requiring enumeration of every OPEN milestone and its OPEN issues. Equal milestone/priority ordering and epic-container exclusion were not explicit, letting the selector invent fix-size/recency relevance. ## Done-when - [x] Canonical #237 says reviewer comment claims persist until explicit release/abandonment and posted deliverables are excluded. - [x] Canonical #237 requires enumeration of every OPEN milestone and its OPEN issues plus OPEN `review` issues. - [x] Canonical #237 ranks OPEN milestone/review work ahead of unmilestoned backlog, then by `priority:`. - [x] Canonical #237 excludes umbrella/epic containers when eligible children are named and defines deterministic equal-tier ordering. - [x] `docs/handoffs/chicorytv-issue-queue.md` carries the same candidate-discovery, ranking, claim, and tie-break rules. - [x] Corrected live evidence makes #245 the next picker result: it is the first explicitly eligible child, OPEN, `priority: medium`, in the OPEN “ChicoryTV modularization” milestone; unmilestoned #345 cannot outrank it. - [x] The docs-only change is reviewed or carries an explicit review exemption.
timothy added the bugpriority: highin-progress labels 2026-07-13 23:20:15 +02:00
Author
Owner

Claiming this process bug. Canonical #237 wording is already corrected; the dedicated docs worktree carries the matching static handoff fix. This is a docs-only workflow change with no runtime/server-state effect, so I will record the independent-review exemption after diff verification.

Claiming this process bug. Canonical #237 wording is already corrected; the dedicated docs worktree carries the matching static handoff fix. This is a docs-only workflow change with no runtime/server-state effect, so I will record the independent-review exemption after diff verification.
timothy changed title from Queue selector mistakes claimed reviewer audits for unclaimed work to Queue selector skips milestone work and repicks completed reviewer audits 2026-07-13 23:30:51 +02:00
Author
Owner

Done

What was done: Corrected canonical #237 and docs/handoffs/chicorytv-issue-queue.md so queue discovery enumerates every open milestone/open issue and open review issue; reviewer comment claims persist until explicit release/abandonment; posted audit deliverables stay excluded; milestone/review work outranks unmilestoned backlog; epic containers and equal-tier ties are deterministic.

Root cause: The selector input did not require complete open-milestone enumeration, reviewer comment claims had no defined lifetime, posted deliverables were not explicitly excluded, and equal-tier/epic rules were underspecified. That let a cheap selector repick completed audits and then prefer unmilestoned high-priority backlog over live milestone work.

Files changed: docs/handoffs/chicorytv-issue-queue.md; canonical workflow text in issue #237 was updated to match.

Verification: git diff --check; pre-push check:api, lint, typecheck, and production build passed; all seven CI contexts green/skipped-as-designed at e280e9072c676d6ea255dc5e211ba62930c9dc7a. Live recheck confirms #245 is open, priority: medium, and in the open “ChicoryTV modularization” milestone; #345 is open, priority: high, but unmilestoned, so #245 wins under the corrected rules. Pure-docs/workflow exact-diff review exemption recorded; live E2E is n/a.

Deferred: None.

Follow-up issues: None.

Docs updated: Queue handoff and canonical #237 pickup protocol.

## Done **What was done**: Corrected canonical #237 and `docs/handoffs/chicorytv-issue-queue.md` so queue discovery enumerates every open milestone/open issue and open review issue; reviewer comment claims persist until explicit release/abandonment; posted audit deliverables stay excluded; milestone/review work outranks unmilestoned backlog; epic containers and equal-tier ties are deterministic. **Root cause**: The selector input did not require complete open-milestone enumeration, reviewer comment claims had no defined lifetime, posted deliverables were not explicitly excluded, and equal-tier/epic rules were underspecified. That let a cheap selector repick completed audits and then prefer unmilestoned high-priority backlog over live milestone work. **Files changed**: `docs/handoffs/chicorytv-issue-queue.md`; canonical workflow text in issue #237 was updated to match. **Verification**: `git diff --check`; pre-push check:api, lint, typecheck, and production build passed; all seven CI contexts green/skipped-as-designed at `e280e9072c676d6ea255dc5e211ba62930c9dc7a`. Live recheck confirms #245 is open, `priority: medium`, and in the open “ChicoryTV modularization” milestone; #345 is open, `priority: high`, but unmilestoned, so #245 wins under the corrected rules. Pure-docs/workflow exact-diff review exemption recorded; live E2E is n/a. **Deferred**: None. **Follow-up issues**: None. **Docs updated**: Queue handoff and canonical #237 pickup protocol.
timothy removed the in-progress label 2026-07-14 08:03:56 +02:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: timothy/ersatztv#347