extract Guide rendering, helpers, and the mount-owned 60-second now timer into GuideScreen.tsx
move detailed Guide coverage beside the screen while keeping a thin App composition smoke
retain polling ownership in useGuideScreenQuery
preserve the landed Dashboard extraction while rebasing onto current main
preserve API, routes, CSS, server state, and behavior
Verification
On rebased head 3876809a83088b5c6f3393cb56d00cd296cf5efe:
npm test — 86 files, 762 tests passed
npm run lint
npm run typecheck
npm run build
npm run check:api
This is a pure SPA leaf refactor, so live E2E was not required.
Review and docs posture
No docs update is needed because no route or convention changed. A fresh current-head cold-review verdict will be posted separately.
Refs #246
## Summary
- extract Guide rendering, helpers, and the mount-owned 60-second now timer into `GuideScreen.tsx`
- move detailed Guide coverage beside the screen while keeping a thin App composition smoke
- retain polling ownership in `useGuideScreenQuery`
- preserve the landed Dashboard extraction while rebasing onto current `main`
- preserve API, routes, CSS, server state, and behavior
## Verification
On rebased head `3876809a83088b5c6f3393cb56d00cd296cf5efe`:
- `npm test` — 86 files, 762 tests passed
- `npm run lint`
- `npm run typecheck`
- `npm run build`
- `npm run check:api`
This is a pure SPA leaf refactor, so live E2E was not required.
## Review and docs posture
No docs update is needed because no route or convention changed. A fresh current-head cold-review verdict will be posted separately.
Fresh cold-context adversarial review of the rebased diff found no issues. The manual conflict resolution retains the landed Dashboard wiring, removes both former inline implementations, preserves Guide timer/query/polling ownership, and leaves API, route, CSS, and behavior unchanged. The follow-up commit removes only stale imports.
Fresh cold-context adversarial review of the rebased diff found no issues. The manual conflict resolution retains the landed Dashboard wiring, removes both former inline implementations, preserves Guide timer/query/polling ownership, and leaves API, route, CSS, and behavior unchanged. The follow-up commit removes only stale imports.
Review-verdict: MERGEABLE @ 3876809a83088b5c6f3393cb56d00cd296cf5efe
timothy
merged commit 3876809a83 into main2026-07-15 21:59:16 +02:00
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
Refs #246
Summary
GuideScreen.tsxuseGuideScreenQuerymainVerification
On rebased head
3876809a83088b5c6f3393cb56d00cd296cf5efe:npm test— 86 files, 762 tests passednpm run lintnpm run typechecknpm run buildnpm run check:apiThis is a pure SPA leaf refactor, so live E2E was not required.
Review and docs posture
No docs update is needed because no route or convention changed. A fresh current-head cold-review verdict will be posted separately.
Independent cold-context adversarial review found no issues. Guide route/composition, query polling ownership, mount-owned minute timer cleanup, temporal helpers, scoped endpoint mocks, API surface, routes, and CSS are preserved.
Review-verdict: MERGEABLE @ 95c12d1471b6c3bfbc992d0b5a23584bf7f61a0a
95c12d1471to3876809a83Fresh cold-context adversarial review of the rebased diff found no issues. The manual conflict resolution retains the landed Dashboard wiring, removes both former inline implementations, preserves Guide timer/query/polling ownership, and leaves API, route, CSS, and behavior unchanged. The follow-up commit removes only stale imports.
Review-verdict: MERGEABLE @
3876809a83