make GET /api/v1/channels/state report onAir when either the segmenter registry or the direct-stream tracker is active for a channel
add handler regression coverage for direct-only activity while preserving the existing segmenter-active and inactive cases
update the channel-state design record from its former segmenter-only limitation to the completed universal semantics
Root cause
The direct streaming paths gained IDirectStreamSessionTracker in the first #99 slice, but GetChannelStatesForApiHandler still consulted only IFFmpegSegmenterService.IsActive. MPEG-TS direct and HLS-Direct viewers therefore remained invisible to the channel-state API despite being tracked.
TZ=UTC dotnet test ErsatzTV.sln --no-build -v minimal — all six test projects green
pre-push check:api, lint, typecheck, and production web build green
live-E2E not required: this changes a read-only handler and no API write path
Review
Cold adversarial review passed on d1a52eaa8bd82d63d7622c039b10bbae814d2ca6. Its initial low-severity documentation finding was fixed and the fix commit was re-reviewed cleanly.
## Summary
- make `GET /api/v1/channels/state` report `onAir` when either the segmenter registry or the direct-stream tracker is active for a channel
- add handler regression coverage for direct-only activity while preserving the existing segmenter-active and inactive cases
- update the channel-state design record from its former segmenter-only limitation to the completed universal semantics
## Root cause
The direct streaming paths gained `IDirectStreamSessionTracker` in the first #99 slice, but `GetChannelStatesForApiHandler` still consulted only `IFFmpegSegmenterService.IsActive`. MPEG-TS direct and HLS-Direct viewers therefore remained invisible to the channel-state API despite being tracked.
## Verification
- `TZ=UTC dotnet restore ErsatzTV.sln -v minimal`
- `TZ=UTC dotnet build ErsatzTV.sln --no-restore -v minimal` — 0 warnings, 0 errors
- `TZ=UTC dotnet test ErsatzTV.sln --no-build -v minimal` — all six test projects green
- pre-push `check:api`, lint, typecheck, and production web build green
- live-E2E not required: this changes a read-only handler and no API write path
## Review
Cold adversarial review passed on `d1a52eaa8bd82d63d7622c039b10bbae814d2ca6`. Its initial low-severity documentation finding was fixed and the fix commit was re-reviewed cleanly.
Fixes #99
Cold, review-only pass found no code correctness, dependency-injection, session-keying, lifecycle, short-circuit, or test-vacuity defects. The initial low-severity documentation finding (stale unversioned channel routes) was fixed in d1a52eaa and the fix commit was re-reviewed cleanly.
Review-verdict: MERGEABLE @ d1a52eaa8bd82d63d7622c039b10bbae814d2ca6
Cold, review-only pass found no code correctness, dependency-injection, session-keying, lifecycle, short-circuit, or test-vacuity defects. The initial low-severity documentation finding (stale unversioned channel routes) was fixed in d1a52eaa and the fix commit was re-reviewed cleanly.
timothy
merged commit ca5ac94466 into main2026-07-16 15:14:32 +02:00
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
Summary
GET /api/v1/channels/statereportonAirwhen either the segmenter registry or the direct-stream tracker is active for a channelRoot cause
The direct streaming paths gained
IDirectStreamSessionTrackerin the first #99 slice, butGetChannelStatesForApiHandlerstill consulted onlyIFFmpegSegmenterService.IsActive. MPEG-TS direct and HLS-Direct viewers therefore remained invisible to the channel-state API despite being tracked.Verification
TZ=UTC dotnet restore ErsatzTV.sln -v minimalTZ=UTC dotnet build ErsatzTV.sln --no-restore -v minimal— 0 warnings, 0 errorsTZ=UTC dotnet test ErsatzTV.sln --no-build -v minimal— all six test projects greencheck:api, lint, typecheck, and production web build greenReview
Cold adversarial review passed on
d1a52eaa8bd82d63d7622c039b10bbae814d2ca6. Its initial low-severity documentation finding was fixed and the fix commit was re-reviewed cleanly.Fixes #99
Review-verdict: MERGEABLE @
d1a52eaa8bCold, review-only pass found no code correctness, dependency-injection, session-keying, lifecycle, short-circuit, or test-vacuity defects. The initial low-severity documentation finding (stale unversioned channel routes) was fixed in
d1a52eaaand the fix commit was re-reviewed cleanly.