feat(api): add collections REST endpoints #45

2026-06-27T21:44:03+02:00

timothy commented

2026-06-27 21:44:03 +02:00

Closes #35

Summary

Add idiomatic REST Collections CRUD endpoints plus collection item add/remove routes.
Retrofit SmartCollectionController to REST-style routes and class-level API key authorization.
Preserve NotFoundError from collection/smart-collection handlers so ApiResults maps missing entities to 404 instead of 422.
Validate collection item mutations so invalid add requests return 422 and missing item associations return 404.
Stabilize culture-sensitive CustomStreamSelectorTests by pinning Sunday-first expectations to en-US and adding Monday-first coverage.

Tests

dotnet restore ErsatzTV.sln --disable-parallel -v normal
dotnet build ErsatzTV.sln -v normal
TZ=UTC dotnet test ErsatzTV.sln -v normal

Review Notes

Addressed adversarial review findings around POST /api/collections/{id}/items invalid IDs and DELETE /api/collections/{id}/items/{mediaItemId} missing associations.
No docs changes needed beyond the existing REST design; implementation follows the #2a controller/API conventions.

Closes #35 ## Summary - Add idiomatic REST Collections CRUD endpoints plus collection item add/remove routes. - Retrofit `SmartCollectionController` to REST-style routes and class-level API key authorization. - Preserve `NotFoundError` from collection/smart-collection handlers so `ApiResults` maps missing entities to 404 instead of 422. - Validate collection item mutations so invalid add requests return 422 and missing item associations return 404. - Stabilize culture-sensitive `CustomStreamSelectorTests` by pinning Sunday-first expectations to `en-US` and adding Monday-first coverage. ## Tests - `dotnet restore ErsatzTV.sln --disable-parallel -v normal` - `dotnet build ErsatzTV.sln -v normal` - `TZ=UTC dotnet test ErsatzTV.sln -v normal` ## Review Notes - Addressed adversarial review findings around `POST /api/collections/{id}/items` invalid IDs and `DELETE /api/collections/{id}/items/{mediaItemId}` missing associations. - No docs changes needed beyond the existing REST design; implementation follows the #2a controller/API conventions.

timothy added 1 commit 2026-06-27 21:44:03 +02:00

feat(api): add collections REST endpoints

Build ErsatzTV Image / Build & test (.NET) (pull_request) Successful in 4m5s

Details

Build ErsatzTV Image / EF migration integrity (SQLite + MySql) (pull_request) Successful in 5m9s

Details

Build ErsatzTV Image / Build & push image (amd64) (pull_request) Has been skipped

Details

fb3f2856da