Release-tag builds: small-lane PR-only gate jobs run + fail on v* tag pushes
#535
Closed
opened 2026-07-21 17:36:02 +02:00 by timothy
·
2 comments
No Branch/Tag Specified
main
renovate/dotnet-monorepo
renovate/meziantou.analyzer-3.x
renovate/lucene.net
renovate/sqlitepclraw.bundle_e_sqlite3-3.x
renovate/cliwrap-3.x
913-scripted-playout-401
release/v26.15.0-notes
issue-806-guard-populations
scratch/767b-poisoned
scratch/767b-control
release/v26.14.0-notes
release/v26.14.0
docs/510-skill-logo-bug-policy
fix/510-watermark-resolution-policy
fix/629-verdict-classifier-falseopens
fix/609-decisions-edit-token-scope
issue-135-clear-to-none
release/v26.12.0-notes
fix/409b-lastscan-api-parity
fix/401-updatechannel-mirror-422
fix/327-playlist-rename-validation
fix/410-scancancel-log-level
fix/409-447-librariesscreen-neverscanned
fix/338-zap-exit-code
fix/367-plex-budget-message
fix/310-debom-legacy-cs
ci/604-lane-rebalance
feat/388-design-mirror
feat/247-test-ownership
feat/247-primary-action
feat/357-player-owned-playback
feat/357-jellyfin-plugin-poc
fix/289-mcp-hardening
issue58-mcp
feat/244-channels-extract
ci/auto-bump-prod-compose
feat/multi-rerun-collections-api
feat/collections-api
feat/quick-wins
feat/185-docs-part2
feat/140-collections-screen
feat/146-channel-edit
feat/147-classic-ui-link
issue22-renovate-dashboard
feat/91-cutover
feat/63-composite-create
feat/65-library-browse
feat/85-epg
feat/86-schedule-editor
feat/109-dashboard-data
feat/99-session-tracking
fix/dockerfile-node-tag
feat/59-spa-foundation
docs/59-ui-redesign-brief
feat/102-json-guide
feat/111-schedule-durations
feat/104-artwork-upload
feat/103-media-sources-api
feat/playouts-read-api
feat/108-health-api
feat/105-picker-list-endpoints
issue-97-channel-state-api
issue42-jellyfin-musicvideos
issue46-rest-api-error-contract
dependabot/nuget/ErsatzTV.FFmpeg.Tests/multi-d307a2e06f
qsv-improvements
hdr-vulkan-cuda-test
v26.16.0
v26.15.0
v26.14.0
v26.13.0
v26.12.0
v26.11.0
v26.10.0
v26.9.0
v26.8.0
v26.7.0
blazor-final
v26.6.0
v26.5.0
v26.4.0
v26.3.1
v26.3.0
v26.2.0
v26.1.1
v26.1.0
v25.9.0
v25.8.0
v25.7.1
v25.7.0
v25.6.0
v25.5.0
v25.4.0
v25.3.1
v25.3.0
v25.2.0
v25.1.0
v0.8.8-beta
v0.8.7-beta
v0.8.6-beta
v0.8.5-beta
v0.8.4-beta
v0.8.3-beta
v0.8.2-beta
v0.8.1-beta
v0.8.0-beta
v0.7.9-beta
v0.7.8-beta
v0.7.7-beta
v0.7.6-beta
v0.7.5-beta
v0.7.4-beta
v0.7.3-beta
v0.7.2-beta
v0.7.1-beta
v0.7.0-beta
v0.6.9-beta
v0.6.8-beta
v0.6.7-beta
v0.6.6-beta
v0.6.5-beta
v0.6.4-beta
v0.6.3-beta
v0.6.2-beta
v0.6.1-beta
v0.6.0-beta
v0.5.8-beta
v0.5.7-beta
v0.5.6-beta
v0.5.5-beta
v0.5.4-beta
v0.5.3-beta
v0.5.2-beta
v0.5.1-beta
v0.5.0-beta
v0.4.5-alpha
v0.4.4-alpha
v0.4.3-alpha
v0.4.2-alpha
v0.4.1-alpha
v0.4.0-alpha
v0.3.8-alpha
v0.3.7-alpha
develop
v0.3.6-alpha
v0.3.5-alpha
v0.3.4-alpha
v0.3.3-alpha
v0.3.2-alpha
v0.3.1-alpha
v0.3.0-alpha
v0.2.5-alpha
v0.2.4-alpha
v0.2.3-alpha
v0.2.2-alpha
v0.2.1-alpha
v0.2.0-alpha
v0.1.5-alpha
v0.1.4-alpha
v0.1.3-alpha
v0.1.2-alpha
v0.1.1-alpha
v0.1.0-alpha
v0.0.62-alpha
v0.0.61-alpha
v0.0.60-alpha
v0.0.59-alpha
v0.0.58-alpha
v0.0.57-alpha
v0.0.56-alpha
v0.0.55-alpha
v0.0.54-alpha
v0.0.53-alpha
v0.0.52-alpha
v0.0.51-alpha
v0.0.50-alpha
v0.0.49-prealpha
v0.0.48-prealpha
v0.0.47-prealpha
v0.0.46-prealpha
v0.0.45-prealpha
v0.0.44-prealpha
v0.0.43-prealpha
v0.0.42-prealpha
v0.0.41-prealpha
v0.0.40-prealpha
v0.0.39-prealpha
v0.0.38-prealpha
v0.0.37-prealpha
v0.0.36-prealpha
v0.0.35-prealpha
v0.0.34-prealpha
v0.0.33-prealpha
v0.0.32-prealpha
v0.0.31-prealpha
v0.0.30-prealpha
v0.0.29-prealpha
v0.0.28-prealpha
v0.0.27-prealpha
v0.0.26-prealpha
v0.0.25-prealpha
v0.0.24-prealpha
v0.0.23-prealpha
v0.0.22-prealpha
v0.0.21-prealpha
v0.0.20-prealpha
v0.0.19-prealpha
v0.0.18-prealpha
v0.0.17-prealpha
v0.0.16-prealpha
v0.0.15-prealpha
v0.0.14-prealpha
v0.0.13-prealpha
v0.0.12-prealpha
v0.0.11-prealpha
v0.0.10-prealpha
v0.0.9-prealpha
v0.0.8-prealpha
v0.0.7-prealpha
v0.0.6-prealpha
v0.0.5-prealpha
v0.0.4-prealpha
v0.0.3-prealpha
v0.0.2-prealpha
v0.0.1-prealpha
Labels
Clear labels
ad-hoc
api
bug
ci-cd
content
dependencies
enhancement
frontend
in-progress
jellyfin
parked
priority: high
priority: low
priority: medium
review
security
One-off / ad-hoc work not tracked by a dedicated issue
REST API / HTTP endpoints
Something isn't working
Build, test, deploy pipeline
Channel content / schedules / playlists
Dependency updates (Renovate)
New feature or improvement
ChicoryTV React SPA frontend
Claimed by an active session — do not pick up
Jellyfin tuner / IPTV integration
Excluded from automatic queue pickup; work only when explicitly selected
Adversarial review finding
Security / vulnerability fix
No labels
priority: medium
Milestone
No items
No Milestone
Projects
Clear projects
No projects
No Assignees
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: timothy/ersatztv#535
Reference in New Issue
Block a user
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
Observed (v26.12.0 tag, run 952 /
b52c9388)Three gate jobs reported failure on the release-tag build, turning the tag's overall commit status red even though the release built fine:
CI image pin matches docker/ci(job id 5289)Docs update reminder(job id 5290)decisions lifecycle(job id 5291)All three: started ~14:51–14:52, completed at the identical timestamp 15:05:55, and their job logs do not exist (
dbfs open … file does not exist) — the killed-job signature (runner restart mid-run), not a code failure.Root pattern
All five PR-only jobs carry the same
if: github.event_name == 'pull_request'. On the tag push:api-docs,format— bothruns-on: ubuntu-latestci-image-pin,docs-reminder,decisions-guard— allruns-on: smallThe only difference is the runner label. The
smalllane did not honour theif:skip on a tag ref (the jobs dispatched to a runner and ran ~13 min instead of skipping). #508 recently reworked the small lane, which fits the timing — v26.11.0's tag (601d855b) showed none of these jobs at all.Even absent the kill,
docs-reminder/decisions-guardwould fail on a tag anyway: they diff againstorigin/${{ github.base_ref }}, andbase_refis empty on a tag push.Impact
build(the image push)needs: [test, migrations]only, so:prod+:<version>still ship. Confirmed: v26.12.0 built, scanned clean, and deployed to prod.Fix directions
if: github.event_name == 'pull_request'→ keep, but investigate why thesmalllane ignores it (likely the small-runner config after #508). Root-cause the small-laneif:handling first.small-lane gate jobs with an additional&& !startsWith(github.ref, 'refs/tags/').decisions-guard/docs-reminderno-op safely whenbase_refis empty.Start at (1): the discriminator is the runner lane, not the job logic.
Done-when
.gitea/workflows/pr-checks.ymlcreated (on: pull_request);ci-image-pin,docs-reminder,decisions-guardremoved fromdocker-build.yml(byte-identical relocation)PR Gates /status context on this PR (live proof the split works)docs/ci-cd.mdupdated in the same PR (new "PR gates workflow" section + cross-refs)Post-merge verification (not a merge gate — unsatisfiable pre-merge): the next
v*release tag shows no spuriousci-image-pin/docs-reminder/decisions lifecyclefailures on its overall commit status.Claiming. Run-952 forensics confirm the mechanism: all 5 PR-only jobs get dispatched on the tag push;
api-docs/format(ubuntu-latest, identicalif:) resolved toskippedcleanly, while the 3small-lane git-diff gates (ci-image-pin,docs-reminder,decisions-guard) wedged in act setup and were killed by a runner restart → spuriousfailure. So the job logic is fine; the kill happens in the dispatch window before anyif:/step runs, and #508 (already in the tag) did not prevent it.Fix: relocate exactly those 3 pure git-diff gates into a dedicated
on: pull_requestworkflow. Gitea evaluates workflow triggers before creating any jobs, so on a tag/main push they are never created → zero dispatch → zero spurious red, permanently. They carry nocontainer:/image pin, soci-image-pin’s grep ofdocker-build.yml(which keeps all pin-bearing jobs) stays correct. None are required checks, so branch protection is unaffected.Done — fixed in #537 (merged to
mainasc21d2271).Root cause. The three gates are pure
checkout + git diffjobs on thesmalllane withif: github.event_name == 'pull_request'. They lived indocker-build.yml, which also triggers on push tomainandv*tags. Gitea dispatches a job as a runner task even when itsifskips it (documented small-lane behavior indocs/ci-cd.md), evaluating the skip only after dispatch. On the v26.12.0 tag those dispatched skip-tasks wedged in act's setup phase and were killed by a runner restart mid-setup →failurewith no logs → red overall commit status on a release that built, scanned, and deployed fine. The two PR-only jobs onubuntu-latest(api-docs,format) carry the identicalif:and skipped cleanly — the job logic was never the problem, so the issue's options 2/3 (tweakif:/step logic) could not have fixed it; the kill lands in the dispatch window before any step or skip runs. #508 (already in the tag) widened the lane but did not close that window.Fix. Relocated exactly those three gates verbatim into a new
.gitea/workflows/pr-checks.ymlthat triggerson: pull_requestonly. Gitea evaluates a workflow's trigger before creating any job, so on a tag/main push the workflow produces zero jobs — no dispatch, no kill, no spurious red, for the whole class permanently.Live proof. PR #537's own CI ran all three under the new context and passed:
PR Gates / CI image pin matches docker/ci,PR Gates / Docs update reminder,PR Gates / decisions lifecycle— all green, alongside the sixdocker-build.ymljobs.Files changed.
.gitea/workflows/pr-checks.yml(new) — the three relocated gates +defaults: run: shell: bash(ci-image-pin usesmapfile)..gitea/workflows/docker-build.yml— removed the three jobs; added a pointer comment.docs/ci-cd.md— new "PR gates workflow" section + cross-references (same PR).Why it's safe.
ci-image-pincarries no image pin and still grepsdocker-build.yml, where all five pin-bearing jobs remain → validation unchanged. None of the three are required checks (onlyBuild & test (.NET)+EF migration integrityare), and the merge-consent hook reads the prefix-agnostic combined status, so the context-prefix change (Build ErsatzTV Image / …→PR Gates / …) doesn't affect merges.Deferred / not done.
api-docs/formatwere intentionally left indocker-build.yml: they carry the sharedcontainer:image pin (ci-image-pin's grep target) and run on the healthyubuntu-latestlane where they skipped correctly — moving them would split the pin across two files for no observed benefit. Residual (low-probability) risk that they could be killed on a future tag if the ubuntu-latest runner restarts during their skip window; not worth the entanglement now.Review. Cold adversarial review over the diff: MERGEABLE, zero Blocker/High/Medium/Low findings.
Post-merge verification (tracked in Done-when, not a merge gate): the next
v*release tag should show no spuriousci-image-pin/docs-reminder/decisions lifecyclefailures on its overall commit status.