H13: session-end must leave the shared checkout fresh — a stale tree serves stale FILES, which no HEAD-reading rule catches #541
Closed
opened 2026-07-21 19:19:11 +02:00 by timothy
·
1 comment
No Branch/Tag Specified
main
renovate/dotnet-monorepo
renovate/meziantou.analyzer-3.x
renovate/lucene.net
renovate/sqlitepclraw.bundle_e_sqlite3-3.x
renovate/cliwrap-3.x
913-scripted-playout-401
release/v26.15.0-notes
issue-806-guard-populations
scratch/767b-poisoned
scratch/767b-control
release/v26.14.0-notes
release/v26.14.0
docs/510-skill-logo-bug-policy
fix/510-watermark-resolution-policy
fix/629-verdict-classifier-falseopens
fix/609-decisions-edit-token-scope
issue-135-clear-to-none
release/v26.12.0-notes
fix/409b-lastscan-api-parity
fix/401-updatechannel-mirror-422
fix/327-playlist-rename-validation
fix/410-scancancel-log-level
fix/409-447-librariesscreen-neverscanned
fix/338-zap-exit-code
fix/367-plex-budget-message
fix/310-debom-legacy-cs
ci/604-lane-rebalance
feat/388-design-mirror
feat/247-test-ownership
feat/247-primary-action
feat/357-player-owned-playback
feat/357-jellyfin-plugin-poc
fix/289-mcp-hardening
issue58-mcp
feat/244-channels-extract
ci/auto-bump-prod-compose
feat/multi-rerun-collections-api
feat/collections-api
feat/quick-wins
feat/185-docs-part2
feat/140-collections-screen
feat/146-channel-edit
feat/147-classic-ui-link
issue22-renovate-dashboard
feat/91-cutover
feat/63-composite-create
feat/65-library-browse
feat/85-epg
feat/86-schedule-editor
feat/109-dashboard-data
feat/99-session-tracking
fix/dockerfile-node-tag
feat/59-spa-foundation
docs/59-ui-redesign-brief
feat/102-json-guide
feat/111-schedule-durations
feat/104-artwork-upload
feat/103-media-sources-api
feat/playouts-read-api
feat/108-health-api
feat/105-picker-list-endpoints
issue-97-channel-state-api
issue42-jellyfin-musicvideos
issue46-rest-api-error-contract
dependabot/nuget/ErsatzTV.FFmpeg.Tests/multi-d307a2e06f
qsv-improvements
hdr-vulkan-cuda-test
v26.16.0
v26.15.0
v26.14.0
v26.13.0
v26.12.0
v26.11.0
v26.10.0
v26.9.0
v26.8.0
v26.7.0
blazor-final
v26.6.0
v26.5.0
v26.4.0
v26.3.1
v26.3.0
v26.2.0
v26.1.1
v26.1.0
v25.9.0
v25.8.0
v25.7.1
v25.7.0
v25.6.0
v25.5.0
v25.4.0
v25.3.1
v25.3.0
v25.2.0
v25.1.0
v0.8.8-beta
v0.8.7-beta
v0.8.6-beta
v0.8.5-beta
v0.8.4-beta
v0.8.3-beta
v0.8.2-beta
v0.8.1-beta
v0.8.0-beta
v0.7.9-beta
v0.7.8-beta
v0.7.7-beta
v0.7.6-beta
v0.7.5-beta
v0.7.4-beta
v0.7.3-beta
v0.7.2-beta
v0.7.1-beta
v0.7.0-beta
v0.6.9-beta
v0.6.8-beta
v0.6.7-beta
v0.6.6-beta
v0.6.5-beta
v0.6.4-beta
v0.6.3-beta
v0.6.2-beta
v0.6.1-beta
v0.6.0-beta
v0.5.8-beta
v0.5.7-beta
v0.5.6-beta
v0.5.5-beta
v0.5.4-beta
v0.5.3-beta
v0.5.2-beta
v0.5.1-beta
v0.5.0-beta
v0.4.5-alpha
v0.4.4-alpha
v0.4.3-alpha
v0.4.2-alpha
v0.4.1-alpha
v0.4.0-alpha
v0.3.8-alpha
v0.3.7-alpha
develop
v0.3.6-alpha
v0.3.5-alpha
v0.3.4-alpha
v0.3.3-alpha
v0.3.2-alpha
v0.3.1-alpha
v0.3.0-alpha
v0.2.5-alpha
v0.2.4-alpha
v0.2.3-alpha
v0.2.2-alpha
v0.2.1-alpha
v0.2.0-alpha
v0.1.5-alpha
v0.1.4-alpha
v0.1.3-alpha
v0.1.2-alpha
v0.1.1-alpha
v0.1.0-alpha
v0.0.62-alpha
v0.0.61-alpha
v0.0.60-alpha
v0.0.59-alpha
v0.0.58-alpha
v0.0.57-alpha
v0.0.56-alpha
v0.0.55-alpha
v0.0.54-alpha
v0.0.53-alpha
v0.0.52-alpha
v0.0.51-alpha
v0.0.50-alpha
v0.0.49-prealpha
v0.0.48-prealpha
v0.0.47-prealpha
v0.0.46-prealpha
v0.0.45-prealpha
v0.0.44-prealpha
v0.0.43-prealpha
v0.0.42-prealpha
v0.0.41-prealpha
v0.0.40-prealpha
v0.0.39-prealpha
v0.0.38-prealpha
v0.0.37-prealpha
v0.0.36-prealpha
v0.0.35-prealpha
v0.0.34-prealpha
v0.0.33-prealpha
v0.0.32-prealpha
v0.0.31-prealpha
v0.0.30-prealpha
v0.0.29-prealpha
v0.0.28-prealpha
v0.0.27-prealpha
v0.0.26-prealpha
v0.0.25-prealpha
v0.0.24-prealpha
v0.0.23-prealpha
v0.0.22-prealpha
v0.0.21-prealpha
v0.0.20-prealpha
v0.0.19-prealpha
v0.0.18-prealpha
v0.0.17-prealpha
v0.0.16-prealpha
v0.0.15-prealpha
v0.0.14-prealpha
v0.0.13-prealpha
v0.0.12-prealpha
v0.0.11-prealpha
v0.0.10-prealpha
v0.0.9-prealpha
v0.0.8-prealpha
v0.0.7-prealpha
v0.0.6-prealpha
v0.0.5-prealpha
v0.0.4-prealpha
v0.0.3-prealpha
v0.0.2-prealpha
v0.0.1-prealpha
Labels
Clear labels
ad-hoc
api
bug
ci-cd
content
dependencies
enhancement
frontend
in-progress
jellyfin
parked
priority: high
priority: low
priority: medium
review
security
One-off / ad-hoc work not tracked by a dedicated issue
REST API / HTTP endpoints
Something isn't working
Build, test, deploy pipeline
Channel content / schedules / playlists
Dependency updates (Renovate)
New feature or improvement
ChicoryTV React SPA frontend
Claimed by an active session — do not pick up
Jellyfin tuner / IPTV integration
Excluded from automatic queue pickup; work only when explicitly selected
Adversarial review finding
Security / vulnerability fix
Milestone
No items
No Milestone
Projects
Clear projects
No projects
No Assignees
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: timothy/ersatztv#541
Reference in New Issue
Block a user
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
What happened (2026-07-21, during #536)
The session kickoff was given
docs/handoffs/chicorytv-issue-queue.mdpasted from/Users/timothy/ersatztv, which was sitting 81 commits behindorigin/mainon a cleanmain. That copy still described the retired queue protocol — "the selector reads the pinned tracker ersatztv#237", "read #237's last ~6 session comments" — which #520 had superseded the day before. The version onmainsays the opposite in as many words: #237 is closed and must not be read for queue state.Nothing broke, because selection went through
scripts/select-queue.shand never touched #237. But that was luck of routing, not a control.Why the existing rule does not cover this
The standing lore is emphatic that the shared tree is not a
mainmirror and that itsHEAD/git log/git statusmust never be read as truth aboutmain. Every failure it describes is a session reading git state. This one read a file — nogitcommand was ever run against that tree, so no amount of "check harder" would have fired. A stale checkout silently serves stale content, and the docs in it are exactly the content a kickoff depends on.That lore bullet already concedes the shape of the fix: "This is a design flaw, not a discipline failure — do not 'fix' it by telling sessions to check harder. A check does not stay true." The tree being stale is the root condition; the fix is to stop it being stale.
Fix
scripts/refresh-shared-checkout.sh, run at session end (idempotent, so session start works too). It fast-forwards the shared tree toorigin/mainand reinstallsweb/node_moduleswhen the lockfile moved.Deliberately timid, because the tree is shared and another session may be mid-flight in it. It refuses and changes nothing — loudly, exit 0 — when the tree is not on
main, is dirty, has local commits, or is mid-rebase/merge. It never switches branches, never stashes, never discards. A refusal is a normal outcome.Two details worth keeping:
npm ci, notnpm install—installcan rewritepackage-lock.json, which would leave the shared tree dirty, and a dirty tree is exactly what the next run refuses on. Caught in testing when the first version did precisely that.Done-when
scripts/refresh-shared-checkout.shexists, is executable, and refuses safely on every unsafe state (not-main, dirty, ahead, mid-rebase, missing)node_modulesonly when the lockfile moveddocs/handoffs/chicorytv-issue-queue.mddocs/decisions.mdRefs #520, #311, #312.
Closing record
Outcome:
scripts/refresh-shared-checkout.sh+ session-end step 6. PR #543, merged asdc130f25. Dogfooded immediately after merge: it fast-forwarded the shared tree 87 commits to9713bae4and left it clean — the staleness that caused this issue is gone.Root cause: Every existing guard on the shared tree is written for a session reading git state ("never read its HEAD/
git log"). This session's kickoff never rangitthere — it was handed a file pasted out of that tree while it was 81 commits behind, still describing the queue protocol #520 retired the day before. A stale checkout serves stale content silently, so no discipline check could fire. Nothing broke only because selection went throughscripts/select-queue.sh— routing luck, not a control.Decisions/conventions changed: added
session.shared-checkout-refresh.Reusable knowledge:
npm ci, nevernpm install, in any script that touches a shared tree.installrewrotepackage-lock.jsonand left the tree dirty — the exact state the next run refuses on, so the tool would have disabled itself after one use. Caught by running the script twice in testing, not by reading it.[ -d "$dir/.git" ]is not proof$diris a repo root. With an invalid.gitand any ancestor repo, git walks up and every subsequent command operates on the ancestor. For a script that fast-forwards and reinstalls, that is the worst possible outcome; assertgit rev-parse --show-toplevelequals the resolved cwd.Verification: executed against 18 scratch-repo states by the reviewer plus my own 7 (never the real tree), confirming clean-at-exit and correct refusal in each; full CI green; then the live run above.
Deferred: none.
Docs updated:
docs/decisions.md(new record, catalog regenerated),docs/handoffs/chicorytv-issue-queue.md(session-end step 6). The narrative deliberately stayed out of the handoff doc — which became #542.