feat(297): add channelId to PlayoutListItemResponseModel; SPA reset keys directly #562
No Assignees
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: timothy/ersatztv#562
Reference in New Issue
Block a user
Fixes #297.
What
Adds
channelIdto the playout list DTO so the SPA reset button keys directly on the immutable channel id, instead of the indirectchannelStateslookup left behind by #288/#296.How
int ChannelIdthroughPlayoutNameViewModel(inserted afterChannelNumber) and every one of its construction sites:Mapper.ProjectToViewModel,GetPlayoutByIdHandler, and the fourUpdate*PlayoutHandlers (all already.Include(p => p.Channel)).int ChannelIdtoPlayoutListItemResponseModel(afterChannelName) and set it inPlayoutController.ToListItemResponse.v1.json) + TS client (v1.d.ts) viascripts/update-openapi.sh+npm run generate:api.docs/endpoint-index.mdis unchanged (this adds a field to an existing model, not an endpoint/operation).PlayoutsScreen.resetSelectedChanneltoresetChannelPlayout(selectedSummary.channelId); the generated type is non-nullable (PlayoutListItemResponseModel.cshas#nullable enable), so the old null-guard was dropped.channelStatesis still used elsewhere in the file, so the destructure is intact.Tests
PlayoutControllerTests,ChannelControllerTests) constructPlayoutNameViewModelpositionally — added theChannelIdarg so the solution compiles. 180 controller tests pass.PlayoutsScreen.test.tsx: the reset test relied on the oldchannelStatesresolution; setchannelIdon the fixture/reset row so it still asserts the correct/api/v1/channels/{id}/playout/resetcall. 46 SPA tests pass.Verification
dotnet build ErsatzTV.slnclean (0 warnings/errors); rebuilt + re-ranupdate-openapi.shpost-rebase → no artifact drift.npm run typecheckclean, PlayoutsScreen vitest 46/46. BOM-check clean on the 6 touched.csfiles.Docs
api-conventions.mdchecklist followed (additive response field, OpenAPI regenerated in-PR).endpoint-index.mdregenerated (no change). No new decision record — additive, no convention reversed.Added ChannelId to PlayoutNameViewModel and all 6 construction sites (Mapper, GetPlayoutByIdHandler, and the Update{,Scripted,ExternalJson,Sequential} PlayoutHandler commands), plus the list DTO PlayoutListItemResponseModel and the PlayoutController list projection. Regenerated OpenAPI (v1.json) and the TS client (v1.d.ts); endpoint-index.md unchanged (no endpoint/operation delta). Simplified PlayoutsScreen resetSelectedChannel to key directly on selectedSummary.channelId instead of resolving via channelStates. Updated controller + SPA tests. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>Cold author review of the diff (additive read-DTO field; not a write-path handler change; ~12 substantive lines → leaf carve-out of the independent-review rubric).
ChannelIdinserted at the correct positional slot inPlayoutNameViewModel(afterChannelNumber) and inPlayoutListItemResponseModel(afterChannelName); all 6 VM construction sites updated (solution compiles → none missed); every handler already.IncludesChannel, so.Idis loaded (no extra query). SPA reset simplified correctly against the non-nullable generated type. OpenAPI/TS regenerated with no post-rebase drift;endpoint-index.mdcorrectly unchanged (field, not operation). Controller tests 180/180, SPA 46/46.Review-verdict: MERGEABLE @
1a3c8e27