timothy/ersatztv
1
0
Fork 0
Code Issues 51 Pull Requests 5 Actions Packages Projects Releases 9 Wiki Activity

feat(74): per-channel On Now/Next transient overlay #569

Merged
timothy merged 10 commits from feat/74-on-now-next-overlay into main 2026-07-22 22:36:42 +02:00
Conversation 1 Commits 10 Files Changed 45
+16530 -43
timothy commented 2026-07-22 22:13:47 +02:00
Owner
Copy Link
Copy Source

Implements #74 — a per-channel "On Now / Next" transient EPG overlay burned onto the transcoded stream at each program change, reusing the existing SkiaSharp graphics engine.

What shipped

  • ChannelGraphicsElement join (5th, mirrors DecoGraphicsElement) + dual-provider migration — the first channel-level graphics-element attachment (previously only Playout/ProgramScheduleItem/BlockItem/Deco).
  • Selector base layer: GraphicsElementSelector appends channel elements at the fall-through; a deco in Override/Disable (and Merge/Override during filler without UseGraphicsElementsDuringFiller) suppresses them; HLS-Direct renders none. Eager-loaded in FFmpegProcessHandler.
  • Seeded built-in on-now-next.yml text element — materialized once (marker graphics.on_now_next_seeded, adopt-not-clobber à la #67); row created by the existing refresh.
  • REST: channel graphicsElementIds: int[] (full-replace, reconciled) + server-derived builtIn on GraphicsElementResponseModel (filename discriminator, not name).
  • SPA: Branding-tab "Show On Now / Next overlay" toggle mirroring the logo-bug switch; draft round-trips graphicsElementIds.
  • Docs + decision record graphics.channel-level-attachment.

Verification

  • .NET suite 182/182; web tests 25/25 (4 new toggle tests, incl. round-trip); decisions_validate OK; format + BOM gates clean.
  • Whole-branch adversarial review (Opus): MERGEABLE, 0 Critical/Important; 5 Minors deferred to follow-up #568.
  • Live-E2E (running instance): seed builtIn:true + channel PUT graphicsElementIds attach/detach round-trip. Visual pixel render deferred to post-merge on a content-bearing instance (see Done-when).

Design + plan: docs/superpowers/{specs,plans}/2026-07-22-on-now-next-overlay*.

fixes #74

🤖 Generated with Claude Code

Implements #74 — a per-channel "On Now / Next" transient EPG overlay burned onto the transcoded stream at each program change, reusing the existing SkiaSharp graphics engine. ## What shipped - **`ChannelGraphicsElement` join** (5th, mirrors `DecoGraphicsElement`) + dual-provider migration — the first *channel-level* graphics-element attachment (previously only Playout/ProgramScheduleItem/BlockItem/Deco). - **Selector base layer**: `GraphicsElementSelector` appends channel elements at the fall-through; a deco in Override/Disable (and Merge/Override during filler without `UseGraphicsElementsDuringFiller`) suppresses them; HLS-Direct renders none. Eager-loaded in `FFmpegProcessHandler`. - **Seeded built-in `on-now-next.yml`** text element — materialized once (marker `graphics.on_now_next_seeded`, adopt-not-clobber à la #67); row created by the existing refresh. - **REST**: channel `graphicsElementIds: int[]` (full-replace, reconciled) + server-derived `builtIn` on `GraphicsElementResponseModel` (filename discriminator, not name). - **SPA**: Branding-tab "Show On Now / Next overlay" toggle mirroring the logo-bug switch; draft round-trips `graphicsElementIds`. - **Docs + decision record** `graphics.channel-level-attachment`. ## Verification - .NET suite 182/182; web tests 25/25 (4 new toggle tests, incl. round-trip); `decisions_validate` OK; format + BOM gates clean. - Whole-branch adversarial review (Opus): **MERGEABLE**, 0 Critical/Important; 5 Minors deferred to follow-up #568. - Live-E2E (running instance): seed `builtIn:true` + channel PUT `graphicsElementIds` attach/detach round-trip. Visual pixel render deferred to post-merge on a content-bearing instance (see Done-when). Design + plan: `docs/superpowers/{specs,plans}/2026-07-22-on-now-next-overlay*`. fixes #74 🤖 Generated with [Claude Code](https://claude.com/claude-code)
timothy added 10 commits 2026-07-22 22:13:47 +02:00
docs(74): design spec for per-channel On Now/Next transient overlay 2901b5293a 
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
docs(74): implementation plan for On Now/Next overlay 6ad2f83ea6 
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
docs(74): fix Task 3 test to Testably MockFileSystem API ed3acb931c
feat(74): seed built-in on-now-next.yml text element (file + marker) 9c6b524aed
feat(74): add ChannelGraphicsElement join + dual-provider migration fe0a273aad 
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
feat(74): selector emits channel-level graphics elements as a base layer d6652dbe13
feat(74): channel graphicsElementIds + graphics builtIn; regen OpenAPI 7757814766
feat(74): channel Branding-tab On Now/Next overlay toggle b139921691
docs(74): channel-level graphics attachment + On Now/Next overlay c80839b338
docs(74): tighten overlay suppression rule (Merge-during-filler also clears)
PR Gates / CI image pin matches docker/ci (pull_request) Successful in 15s
Details
Build ErsatzTV Image / Formatting (changed .cs conform to .editorconfig) (pull_request) Successful in 17s
Details
PR Gates / Docs update reminder (pull_request) Successful in 20s
Details
PR Gates / decisions lifecycle (pull_request) Successful in 22s
Details
Build ErsatzTV Image / API docs in sync (OpenAPI + endpoint index) (pull_request) Successful in 14m25s
Details
Build ErsatzTV Image / EF migration integrity (SQLite + MySql) (pull_request) Successful in 16m45s
Details
Build ErsatzTV Image / Functional E2E (curl contracts) (pull_request) Successful in 16m51s
Details
Build ErsatzTV Image / Build & test (.NET) (pull_request) Successful in 21m18s
Details
Build ErsatzTV Image / Build & push image (amd64) (pull_request) Has been skipped
Details
b7d58bbf32 
Folds whole-branch review finding #2.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
timothy commented 2026-07-22 22:13:58 +02:00
Author
Owner
Copy Link
Copy Source

Review-verdict: MERGEABLE @ b7d58bbf

Whole-branch adversarial review (Opus) over the full branch diff: 0 Critical/Important, 5 deferrable Minors (follow-up #568). Precedence, reconcile, seed lifecycle, migration parity, and security all traced clean. Write-path live-E2E confirmed. Visual pixel render deferred to post-merge (Done-when).

Review-verdict: MERGEABLE @ b7d58bbf Whole-branch adversarial review (Opus) over the full branch diff: 0 Critical/Important, 5 deferrable Minors (follow-up #568). Precedence, reconcile, seed lifecycle, migration parity, and security all traced clean. Write-path live-E2E confirmed. Visual pixel render deferred to post-merge (Done-when).
timothy merged commit 7080f63ebe into main 2026-07-22 22:36:42 +02:00
timothy deleted branch feat/74-on-now-next-overlay 2026-07-22 22:36:42 +02:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
ad-hoc
One-off / ad-hoc work not tracked by a dedicated issue
 api
REST API / HTTP endpoints
 bug
Something isn't working
 ci-cd
Build, test, deploy pipeline
 content
Channel content / schedules / playlists
 dependencies
Dependency updates (Renovate)
 enhancement
New feature or improvement
 frontend
ChicoryTV React SPA frontend
 in-progress
Claimed by an active session — do not pick up
 jellyfin
Jellyfin tuner / IPTV integration
 parked
Excluded from automatic queue pickup; work only when explicitly selected
 priority: high
priority: low
priority: medium
review
Adversarial review finding
 security
Security / vulnerability fix
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
renovate timothy (Timothy)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: timothy/ersatztv#569