CI monitors: record that skipped is not red (build skips on every PR)
#592
Closed
opened 2026-07-25 11:53:17 +02:00 by timothy
·
1 comment
No Branch/Tag Specified
main
renovate/dotnet-monorepo
renovate/meziantou.analyzer-3.x
renovate/lucene.net
renovate/sqlitepclraw.bundle_e_sqlite3-3.x
renovate/cliwrap-3.x
913-scripted-playout-401
release/v26.15.0-notes
issue-806-guard-populations
scratch/767b-poisoned
scratch/767b-control
release/v26.14.0-notes
release/v26.14.0
docs/510-skill-logo-bug-policy
fix/510-watermark-resolution-policy
fix/629-verdict-classifier-falseopens
fix/609-decisions-edit-token-scope
issue-135-clear-to-none
release/v26.12.0-notes
fix/409b-lastscan-api-parity
fix/401-updatechannel-mirror-422
fix/327-playlist-rename-validation
fix/410-scancancel-log-level
fix/409-447-librariesscreen-neverscanned
fix/338-zap-exit-code
fix/367-plex-budget-message
fix/310-debom-legacy-cs
ci/604-lane-rebalance
feat/388-design-mirror
feat/247-test-ownership
feat/247-primary-action
feat/357-player-owned-playback
feat/357-jellyfin-plugin-poc
fix/289-mcp-hardening
issue58-mcp
feat/244-channels-extract
ci/auto-bump-prod-compose
feat/multi-rerun-collections-api
feat/collections-api
feat/quick-wins
feat/185-docs-part2
feat/140-collections-screen
feat/146-channel-edit
feat/147-classic-ui-link
issue22-renovate-dashboard
feat/91-cutover
feat/63-composite-create
feat/65-library-browse
feat/85-epg
feat/86-schedule-editor
feat/109-dashboard-data
feat/99-session-tracking
fix/dockerfile-node-tag
feat/59-spa-foundation
docs/59-ui-redesign-brief
feat/102-json-guide
feat/111-schedule-durations
feat/104-artwork-upload
feat/103-media-sources-api
feat/playouts-read-api
feat/108-health-api
feat/105-picker-list-endpoints
issue-97-channel-state-api
issue42-jellyfin-musicvideos
issue46-rest-api-error-contract
dependabot/nuget/ErsatzTV.FFmpeg.Tests/multi-d307a2e06f
qsv-improvements
hdr-vulkan-cuda-test
v26.16.0
v26.15.0
v26.14.0
v26.13.0
v26.12.0
v26.11.0
v26.10.0
v26.9.0
v26.8.0
v26.7.0
blazor-final
v26.6.0
v26.5.0
v26.4.0
v26.3.1
v26.3.0
v26.2.0
v26.1.1
v26.1.0
v25.9.0
v25.8.0
v25.7.1
v25.7.0
v25.6.0
v25.5.0
v25.4.0
v25.3.1
v25.3.0
v25.2.0
v25.1.0
v0.8.8-beta
v0.8.7-beta
v0.8.6-beta
v0.8.5-beta
v0.8.4-beta
v0.8.3-beta
v0.8.2-beta
v0.8.1-beta
v0.8.0-beta
v0.7.9-beta
v0.7.8-beta
v0.7.7-beta
v0.7.6-beta
v0.7.5-beta
v0.7.4-beta
v0.7.3-beta
v0.7.2-beta
v0.7.1-beta
v0.7.0-beta
v0.6.9-beta
v0.6.8-beta
v0.6.7-beta
v0.6.6-beta
v0.6.5-beta
v0.6.4-beta
v0.6.3-beta
v0.6.2-beta
v0.6.1-beta
v0.6.0-beta
v0.5.8-beta
v0.5.7-beta
v0.5.6-beta
v0.5.5-beta
v0.5.4-beta
v0.5.3-beta
v0.5.2-beta
v0.5.1-beta
v0.5.0-beta
v0.4.5-alpha
v0.4.4-alpha
v0.4.3-alpha
v0.4.2-alpha
v0.4.1-alpha
v0.4.0-alpha
v0.3.8-alpha
v0.3.7-alpha
develop
v0.3.6-alpha
v0.3.5-alpha
v0.3.4-alpha
v0.3.3-alpha
v0.3.2-alpha
v0.3.1-alpha
v0.3.0-alpha
v0.2.5-alpha
v0.2.4-alpha
v0.2.3-alpha
v0.2.2-alpha
v0.2.1-alpha
v0.2.0-alpha
v0.1.5-alpha
v0.1.4-alpha
v0.1.3-alpha
v0.1.2-alpha
v0.1.1-alpha
v0.1.0-alpha
v0.0.62-alpha
v0.0.61-alpha
v0.0.60-alpha
v0.0.59-alpha
v0.0.58-alpha
v0.0.57-alpha
v0.0.56-alpha
v0.0.55-alpha
v0.0.54-alpha
v0.0.53-alpha
v0.0.52-alpha
v0.0.51-alpha
v0.0.50-alpha
v0.0.49-prealpha
v0.0.48-prealpha
v0.0.47-prealpha
v0.0.46-prealpha
v0.0.45-prealpha
v0.0.44-prealpha
v0.0.43-prealpha
v0.0.42-prealpha
v0.0.41-prealpha
v0.0.40-prealpha
v0.0.39-prealpha
v0.0.38-prealpha
v0.0.37-prealpha
v0.0.36-prealpha
v0.0.35-prealpha
v0.0.34-prealpha
v0.0.33-prealpha
v0.0.32-prealpha
v0.0.31-prealpha
v0.0.30-prealpha
v0.0.29-prealpha
v0.0.28-prealpha
v0.0.27-prealpha
v0.0.26-prealpha
v0.0.25-prealpha
v0.0.24-prealpha
v0.0.23-prealpha
v0.0.22-prealpha
v0.0.21-prealpha
v0.0.20-prealpha
v0.0.19-prealpha
v0.0.18-prealpha
v0.0.17-prealpha
v0.0.16-prealpha
v0.0.15-prealpha
v0.0.14-prealpha
v0.0.13-prealpha
v0.0.12-prealpha
v0.0.11-prealpha
v0.0.10-prealpha
v0.0.9-prealpha
v0.0.8-prealpha
v0.0.7-prealpha
v0.0.6-prealpha
v0.0.5-prealpha
v0.0.4-prealpha
v0.0.3-prealpha
v0.0.2-prealpha
v0.0.1-prealpha
Labels
Clear labels
ad-hoc
api
bug
ci-cd
content
dependencies
enhancement
frontend
in-progress
jellyfin
parked
priority: high
priority: low
priority: medium
review
security
One-off / ad-hoc work not tracked by a dedicated issue
REST API / HTTP endpoints
Something isn't working
Build, test, deploy pipeline
Channel content / schedules / playlists
Dependency updates (Renovate)
New feature or improvement
ChicoryTV React SPA frontend
Claimed by an active session — do not pick up
Jellyfin tuner / IPTV integration
Excluded from automatic queue pickup; work only when explicitly selected
Adversarial review finding
Security / vulnerability fix
Milestone
No items
No Milestone
Projects
Clear projects
No projects
No Assignees
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: timothy/ersatztv#592
Reference in New Issue
Block a user
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
Surfaced while landing #436/#583 on 2026-07-25.
What happened
My CI monitor enumerated per-context statuses and treated anything
!= "success"as red. On two fully green PRs it announced "NOT all green" becauseBuild & push image (amd64)reportsskipped.Nothing was blocked — Gitea's combined
/statusendpoint already treatsskippedas non-blocking and reportedoverall=success, and both PRs merged cleanly through the consent gate. But the monitor is the thing an agent reads to decide whether to investigate, so a false red costs a diagnosis cycle every time.Two corrections worth recording
if:-gated at the JOB level ongithub.event_name != 'pull_request'— images are built only on push-to-main and tags. I initially misattributed the skip to #416's docs-only mechanism, which is a plausible-sounding wrong diagnosis: docs-only deliberately gates individual STEPS precisely so required jobs still reportsuccess(ci.docs-only-skip-steps).decisions.mdalready states "buildisskippedon every PR" from the branch-protection angle; what was missing is the monitor-authoring consequence.skipped/failure/cancelledare three different things.skipped= deliberately not applicable, settled, not red.failure= a real red (checkci.killed-job-triagefirst).cancelled= no verdict (ci.cancelled-is-not-a-verdict). A monitor that collapses them misreports.Change
Amended
ci.monitor-armed-at-pr-open(docs/decisions/workflow-process.md) — the record that already tells you to arm a monitor — with the classification rules, a preference for gating on the combined.state, and a working enumeration filter.The snippet needed fixing during authoring, which is itself the lesson: my first draft used
select(.status != …)after the jq pipeline had renamed.statusto.st, so it compared againstnull, passed everything, and reported a green PR as nine failures. The committed version is verified in both directions — silent on a green PR with a skippedbuild, and still dirty on a genuinely pending run (perprocess.bom-format-detection-recipe's "verify your detector" rule).Also noticed
decisions_validate.pynow emits::warning:: aggregate active-corpus is 5606 lines (budget 5600) — schedule a consolidation. Non-blocking, but the budget is crossed; worth its own consolidation pass.Done-when
ci.monitor-armed-at-pr-openamended with skipped/failure/cancelled classification + verified filterdecisions-validate: OKClosing record
Outcome: Shipped via PR #593 (merged,
2fee3f0b).ci.monitor-armed-at-pr-opennow carries the monitor-classification rules: prefer gating on the combined/status.state, and if you enumerate per-context, treatskippedas settled-not-red. Prose +Signals:only — heading,key:and lifecycle fields unchanged,[decisions-edit]in the commit, so thedecisions lifecyclejob saw an edit rather than an unlogged removal.Root cause: My CI monitor filtered per-context statuses on
!= "success"and so reportedskippedas red on two fully green PRs. The underlying CI fact was already recorded (ci.docs-only-skip-stepsstates "buildisskippedon every PR") — the gap was that no record connected it to writing a monitor, andci.monitor-armed-at-pr-opentold you to arm one without saying how to classify what comes back.Decisions/conventions changed:
ci.monitor-armed-at-pr-openamended (no supersession, no new key).Reusable knowledge:
skipped≠failure≠cancelled. Settled-not-applicable; a real red; no verdict at all. Gitea's combined.statealready gets this right — a PR with a skippedbuildreportsoverall=success— which is why gating on the combined endpoint is safer than hand-rolling per-context logic.Build & push image (amd64)is skipped on EVERY PR — job-levelif: github.event_name != 'pull_request'; images build only on push-to-main and tags. Do not attribute that skip to the docs-only mechanism: docs-only gates individual steps precisely so required jobs still reportsuccessin seconds. I made exactly that misattribution first, and it is the kind of wrong-but-coherent explanation that survives because it sounds right.select(.status != …)after the pipeline had renamed.statusto.st— it compared againstnull, passed everything, and reported a green PR as nine failures. Caught only by running it. The committed version is proven silent on a green PR carrying a skippedbuildand proven to still report a genuinely pending run.Verification: Bounded independent fact-check (cheapest tier, capped scope — proportionate to a docs leaf, but run rather than skipped because the record asserts things about CI wiring). All six claims TRUE: the job-level
if:atdocker-build.yml:518; docs-only gating steps at :534/557/565/573;ci.docs-only-skip-stepsactive and containing the quoted phrase; no dangling key references among the four cross-referenced keys; the record header byte-identical toorigin/main; and the documented jq filter emitting onlypending/failureon a synthetic[success, skipped, pending, failure]payload.decisions-validate: OK, catalog regenerated, CI green on2fee3f0b.Deferred:
decisions_validate.pynow warns the aggregate active corpus is 5606 lines against a 5600 budget — non-blocking, but the budget is crossed and wants its own consolidation pass. Not filed as a separate issue yet; flagging here so the next session sees it.Docs updated:
docs/decisions/workflow-process.md(ci.monitor-armed-at-pr-openamended),docs/decisions/README.md(regenerated).