Selection-id boundary: ScheduleItemInspector is unguarded, and list-backed pickers drop malformed options silently #677
Open
opened 2026-07-27 04:23:26 +02:00 by timothy
·
1 comment
No Branch/Tag Specified
main
renovate/dotnet-monorepo
renovate/meziantou.analyzer-3.x
renovate/lucene.net
renovate/sqlitepclraw.bundle_e_sqlite3-3.x
renovate/cliwrap-3.x
913-scripted-playout-401
release/v26.15.0-notes
issue-806-guard-populations
scratch/767b-poisoned
scratch/767b-control
release/v26.14.0-notes
release/v26.14.0
docs/510-skill-logo-bug-policy
fix/510-watermark-resolution-policy
fix/629-verdict-classifier-falseopens
fix/609-decisions-edit-token-scope
issue-135-clear-to-none
release/v26.12.0-notes
fix/409b-lastscan-api-parity
fix/401-updatechannel-mirror-422
fix/327-playlist-rename-validation
fix/410-scancancel-log-level
fix/409-447-librariesscreen-neverscanned
fix/338-zap-exit-code
fix/367-plex-budget-message
fix/310-debom-legacy-cs
ci/604-lane-rebalance
feat/388-design-mirror
feat/247-test-ownership
feat/247-primary-action
feat/357-player-owned-playback
feat/357-jellyfin-plugin-poc
fix/289-mcp-hardening
issue58-mcp
feat/244-channels-extract
ci/auto-bump-prod-compose
feat/multi-rerun-collections-api
feat/collections-api
feat/quick-wins
feat/185-docs-part2
feat/140-collections-screen
feat/146-channel-edit
feat/147-classic-ui-link
issue22-renovate-dashboard
feat/91-cutover
feat/63-composite-create
feat/65-library-browse
feat/85-epg
feat/86-schedule-editor
feat/109-dashboard-data
feat/99-session-tracking
fix/dockerfile-node-tag
feat/59-spa-foundation
docs/59-ui-redesign-brief
feat/102-json-guide
feat/111-schedule-durations
feat/104-artwork-upload
feat/103-media-sources-api
feat/playouts-read-api
feat/108-health-api
feat/105-picker-list-endpoints
issue-97-channel-state-api
issue42-jellyfin-musicvideos
issue46-rest-api-error-contract
dependabot/nuget/ErsatzTV.FFmpeg.Tests/multi-d307a2e06f
qsv-improvements
hdr-vulkan-cuda-test
v26.16.0
v26.15.0
v26.14.0
v26.13.0
v26.12.0
v26.11.0
v26.10.0
v26.9.0
v26.8.0
v26.7.0
blazor-final
v26.6.0
v26.5.0
v26.4.0
v26.3.1
v26.3.0
v26.2.0
v26.1.1
v26.1.0
v25.9.0
v25.8.0
v25.7.1
v25.7.0
v25.6.0
v25.5.0
v25.4.0
v25.3.1
v25.3.0
v25.2.0
v25.1.0
v0.8.8-beta
v0.8.7-beta
v0.8.6-beta
v0.8.5-beta
v0.8.4-beta
v0.8.3-beta
v0.8.2-beta
v0.8.1-beta
v0.8.0-beta
v0.7.9-beta
v0.7.8-beta
v0.7.7-beta
v0.7.6-beta
v0.7.5-beta
v0.7.4-beta
v0.7.3-beta
v0.7.2-beta
v0.7.1-beta
v0.7.0-beta
v0.6.9-beta
v0.6.8-beta
v0.6.7-beta
v0.6.6-beta
v0.6.5-beta
v0.6.4-beta
v0.6.3-beta
v0.6.2-beta
v0.6.1-beta
v0.6.0-beta
v0.5.8-beta
v0.5.7-beta
v0.5.6-beta
v0.5.5-beta
v0.5.4-beta
v0.5.3-beta
v0.5.2-beta
v0.5.1-beta
v0.5.0-beta
v0.4.5-alpha
v0.4.4-alpha
v0.4.3-alpha
v0.4.2-alpha
v0.4.1-alpha
v0.4.0-alpha
v0.3.8-alpha
v0.3.7-alpha
develop
v0.3.6-alpha
v0.3.5-alpha
v0.3.4-alpha
v0.3.3-alpha
v0.3.2-alpha
v0.3.1-alpha
v0.3.0-alpha
v0.2.5-alpha
v0.2.4-alpha
v0.2.3-alpha
v0.2.2-alpha
v0.2.1-alpha
v0.2.0-alpha
v0.1.5-alpha
v0.1.4-alpha
v0.1.3-alpha
v0.1.2-alpha
v0.1.1-alpha
v0.1.0-alpha
v0.0.62-alpha
v0.0.61-alpha
v0.0.60-alpha
v0.0.59-alpha
v0.0.58-alpha
v0.0.57-alpha
v0.0.56-alpha
v0.0.55-alpha
v0.0.54-alpha
v0.0.53-alpha
v0.0.52-alpha
v0.0.51-alpha
v0.0.50-alpha
v0.0.49-prealpha
v0.0.48-prealpha
v0.0.47-prealpha
v0.0.46-prealpha
v0.0.45-prealpha
v0.0.44-prealpha
v0.0.43-prealpha
v0.0.42-prealpha
v0.0.41-prealpha
v0.0.40-prealpha
v0.0.39-prealpha
v0.0.38-prealpha
v0.0.37-prealpha
v0.0.36-prealpha
v0.0.35-prealpha
v0.0.34-prealpha
v0.0.33-prealpha
v0.0.32-prealpha
v0.0.31-prealpha
v0.0.30-prealpha
v0.0.29-prealpha
v0.0.28-prealpha
v0.0.27-prealpha
v0.0.26-prealpha
v0.0.25-prealpha
v0.0.24-prealpha
v0.0.23-prealpha
v0.0.22-prealpha
v0.0.21-prealpha
v0.0.20-prealpha
v0.0.19-prealpha
v0.0.18-prealpha
v0.0.17-prealpha
v0.0.16-prealpha
v0.0.15-prealpha
v0.0.14-prealpha
v0.0.13-prealpha
v0.0.12-prealpha
v0.0.11-prealpha
v0.0.10-prealpha
v0.0.9-prealpha
v0.0.8-prealpha
v0.0.7-prealpha
v0.0.6-prealpha
v0.0.5-prealpha
v0.0.4-prealpha
v0.0.3-prealpha
v0.0.2-prealpha
v0.0.1-prealpha
Labels
Clear labels
ad-hoc
api
bug
ci-cd
content
dependencies
enhancement
frontend
in-progress
jellyfin
parked
priority: high
priority: low
priority: medium
review
security
One-off / ad-hoc work not tracked by a dedicated issue
REST API / HTTP endpoints
Something isn't working
Build, test, deploy pipeline
Channel content / schedules / playlists
Dependency updates (Renovate)
New feature or improvement
ChicoryTV React SPA frontend
Claimed by an active session — do not pick up
Jellyfin tuner / IPTV integration
Excluded from automatic queue pickup; work only when explicitly selected
Adversarial review finding
Security / vulnerability fix
Milestone
No items
No Milestone
Projects
Clear projects
No projects
No Assignees
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: timothy/ersatztv#677
Reference in New Issue
Block a user
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
Split out of the #651 final review. Two items, both extensions of the boundary rule that branch established (
docs/spa-conventions.md§3b → "Put a validity predicate at the BOUNDARY the class crosses"). Neither is data loss; both are the same class arriving somewhere #651 did not reach.1.
ScheduleItemInspectorstores and submits raw wire idsweb/src/schedules/ScheduleItemInspector.tsx:403-428,490-501readscollectionId/mediaItemId/multiCollectionId/smartCollectionId/playlistId/playlistGroupIdstraight out of the API response into editor state and submits them unchanged. That is exactly the classweb/src/api/selectionId.tsexists for: the API binds each as a 32-bitint, so a malformed successful response carrying1.5or2147483648renders as a normal selection and then fails on write.#651 centralized the predicate and applied it to every ingress on
RerunCollectionsScreen,PlaylistsScreenandFillerPresetsScreen. This screen was outside its scope and is unchanged by that branch — but "the boundary, not the site" is the whole point of the rule, so it should be tracked rather than left silent.Fix: route every id through
selectionIdOrNullon the way in, andisSelectionIdwhen building options. Treat an unbindable id as absent (never coerce — rounding1.5to1submits a different record), clear any label alongside a dropped id, and make sure the screen's save gate actually refuses to write without a selection. #651's round-9 finding was that the analogous gate did not exist onPlaylistsScreen, so check rather than assume.2. List-backed pickers drop malformed options silently
RerunCollectionsScreen.toPickerOptions,PlaylistsScreen.toPickerOptionsandFillerPresetsScreen's collection-family option mapping allflatMapaway any element whose id failsisSelectionId. Dropping one bad option among good ones is right. But a wholly malformed page yields an empty picker with no explanation, which contradicts the convention rounds 6/7 established forSearchPicker:So the same defect now exists in the other direction: "there is nothing to pick" and "we threw your options away" look identical.
SearchPickeralready distinguishes these (resultsFor.ok→ a "Search failed" alert instead of "No matches"); the list-backed path has no equivalent.Related, same area:
FillerPresetsScreen.tsx:688computes its truncation hint (Showing the first N of M) from the unfiltered page length, so after filtering, N can exceed the number of options actually rendered.Fix: surface a distinct "some options could not be loaded" / "failed to load options" state when the filter drops elements (or when it drops all of them), and derive the truncation hint from the filtered list.
Not in scope
The #651 screens' own ingresses are closed and covered by regressions; this is the surface beyond them.
Done-when
ScheduleItemInspectorpasses through the sharedselectionIdpredicate, with unbindable ids treated as absent and their labels clearedFillerPresetsScreen's truncation hint counts the options actually rendereddocs/spa-conventions.md§3b updated in the same PR if the convention movesnpm run lint,npm run typecheck(nottsc --noEmit— the root tsconfig is solution-style and checks nothing),npx vitest rungreenTwo more items from the final cold review of #651, both on
PlaylistsScreenand both left unfixed there deliberately (one pre-existing, one unreachable today). Same class as the rest of this issue: an id and its label disagreeing, or a disabled control with no stated reason.3. The item row says "(no X selected)" for a valid id with a null name
web/src/screens/PlaylistsScreen.tsx:750:The fallback is keyed on
selectedNamealone, regardless ofselectedId. The generated types make the namenull | string, so a response carrying a valid id with a null/empty name renders "(no movie selected)" while Save is enabled and no validation badge appears.That is the mirror image of the bug #651 round 9 fixed (there the name survived a dropped id; here the id survives a missing name), and it violates the same rule that branch wrote into
docs/spa-conventions.md§3b — a row must not make two contradictory statements about the same item. The picker already gets this right (selectedName || \#${selectedId}``); the row does not.Fix: fall back to
#${item.selectedId}when an id is present, and reserve "(no X selected)" forselectedId == null— matchingSearchPicker.4. An all-unbindable group list disables Create with no reason
web/src/screens/PlaylistsScreen.tsx:367-371,398: if every group id failedisSelectionId,bindableGroupsis empty, theSelectrenders no options and no placeholder, and Create is disabled with nothing explaining why. Contrast thegroups.length === 0path, which disables "Add playlist" up front so the dialog is never reachable in that state.Unreachable with identity PKs — filed for completeness, because "always explain a disabled state" is exactly the property #651 round 9 established for this screen's Save button, and this is the one place it does not hold.
Fix: when the group list is non-empty but nothing in it is bindable, say so (or disable the entry point, as the empty case does).
Both are additions to the existing
## Done-when; suggested extra boxes:selectedIdwith a null/empty name renders#<id>, not "(no X selected)"