Closed
opened 2026-08-26 17:41:00 +02:00 by timothy
·
2 comments
No Branch/Tag Specified
main
renovate/dotnet-monorepo
renovate/meziantou.analyzer-3.x
renovate/lucene.net
renovate/sqlitepclraw.bundle_e_sqlite3-3.x
renovate/cliwrap-3.x
913-scripted-playout-401
release/v26.15.0-notes
issue-806-guard-populations
scratch/767b-poisoned
scratch/767b-control
release/v26.14.0-notes
release/v26.14.0
docs/510-skill-logo-bug-policy
fix/510-watermark-resolution-policy
fix/629-verdict-classifier-falseopens
fix/609-decisions-edit-token-scope
issue-135-clear-to-none
release/v26.12.0-notes
fix/409b-lastscan-api-parity
fix/401-updatechannel-mirror-422
fix/327-playlist-rename-validation
fix/410-scancancel-log-level
fix/409-447-librariesscreen-neverscanned
fix/338-zap-exit-code
fix/367-plex-budget-message
fix/310-debom-legacy-cs
ci/604-lane-rebalance
feat/388-design-mirror
feat/247-test-ownership
feat/247-primary-action
feat/357-player-owned-playback
feat/357-jellyfin-plugin-poc
fix/289-mcp-hardening
issue58-mcp
feat/244-channels-extract
ci/auto-bump-prod-compose
feat/multi-rerun-collections-api
feat/collections-api
feat/quick-wins
feat/185-docs-part2
feat/140-collections-screen
feat/146-channel-edit
feat/147-classic-ui-link
issue22-renovate-dashboard
feat/91-cutover
feat/63-composite-create
feat/65-library-browse
feat/85-epg
feat/86-schedule-editor
feat/109-dashboard-data
feat/99-session-tracking
fix/dockerfile-node-tag
feat/59-spa-foundation
docs/59-ui-redesign-brief
feat/102-json-guide
feat/111-schedule-durations
feat/104-artwork-upload
feat/103-media-sources-api
feat/playouts-read-api
feat/108-health-api
feat/105-picker-list-endpoints
issue-97-channel-state-api
issue42-jellyfin-musicvideos
issue46-rest-api-error-contract
dependabot/nuget/ErsatzTV.FFmpeg.Tests/multi-d307a2e06f
qsv-improvements
hdr-vulkan-cuda-test
v26.16.0
v26.15.0
v26.14.0
v26.13.0
v26.12.0
v26.11.0
v26.10.0
v26.9.0
v26.8.0
v26.7.0
blazor-final
v26.6.0
v26.5.0
v26.4.0
v26.3.1
v26.3.0
v26.2.0
v26.1.1
v26.1.0
v25.9.0
v25.8.0
v25.7.1
v25.7.0
v25.6.0
v25.5.0
v25.4.0
v25.3.1
v25.3.0
v25.2.0
v25.1.0
v0.8.8-beta
v0.8.7-beta
v0.8.6-beta
v0.8.5-beta
v0.8.4-beta
v0.8.3-beta
v0.8.2-beta
v0.8.1-beta
v0.8.0-beta
v0.7.9-beta
v0.7.8-beta
v0.7.7-beta
v0.7.6-beta
v0.7.5-beta
v0.7.4-beta
v0.7.3-beta
v0.7.2-beta
v0.7.1-beta
v0.7.0-beta
v0.6.9-beta
v0.6.8-beta
v0.6.7-beta
v0.6.6-beta
v0.6.5-beta
v0.6.4-beta
v0.6.3-beta
v0.6.2-beta
v0.6.1-beta
v0.6.0-beta
v0.5.8-beta
v0.5.7-beta
v0.5.6-beta
v0.5.5-beta
v0.5.4-beta
v0.5.3-beta
v0.5.2-beta
v0.5.1-beta
v0.5.0-beta
v0.4.5-alpha
v0.4.4-alpha
v0.4.3-alpha
v0.4.2-alpha
v0.4.1-alpha
v0.4.0-alpha
v0.3.8-alpha
v0.3.7-alpha
develop
v0.3.6-alpha
v0.3.5-alpha
v0.3.4-alpha
v0.3.3-alpha
v0.3.2-alpha
v0.3.1-alpha
v0.3.0-alpha
v0.2.5-alpha
v0.2.4-alpha
v0.2.3-alpha
v0.2.2-alpha
v0.2.1-alpha
v0.2.0-alpha
v0.1.5-alpha
v0.1.4-alpha
v0.1.3-alpha
v0.1.2-alpha
v0.1.1-alpha
v0.1.0-alpha
v0.0.62-alpha
v0.0.61-alpha
v0.0.60-alpha
v0.0.59-alpha
v0.0.58-alpha
v0.0.57-alpha
v0.0.56-alpha
v0.0.55-alpha
v0.0.54-alpha
v0.0.53-alpha
v0.0.52-alpha
v0.0.51-alpha
v0.0.50-alpha
v0.0.49-prealpha
v0.0.48-prealpha
v0.0.47-prealpha
v0.0.46-prealpha
v0.0.45-prealpha
v0.0.44-prealpha
v0.0.43-prealpha
v0.0.42-prealpha
v0.0.41-prealpha
v0.0.40-prealpha
v0.0.39-prealpha
v0.0.38-prealpha
v0.0.37-prealpha
v0.0.36-prealpha
v0.0.35-prealpha
v0.0.34-prealpha
v0.0.33-prealpha
v0.0.32-prealpha
v0.0.31-prealpha
v0.0.30-prealpha
v0.0.29-prealpha
v0.0.28-prealpha
v0.0.27-prealpha
v0.0.26-prealpha
v0.0.25-prealpha
v0.0.24-prealpha
v0.0.23-prealpha
v0.0.22-prealpha
v0.0.21-prealpha
v0.0.20-prealpha
v0.0.19-prealpha
v0.0.18-prealpha
v0.0.17-prealpha
v0.0.16-prealpha
v0.0.15-prealpha
v0.0.14-prealpha
v0.0.13-prealpha
v0.0.12-prealpha
v0.0.11-prealpha
v0.0.10-prealpha
v0.0.9-prealpha
v0.0.8-prealpha
v0.0.7-prealpha
v0.0.6-prealpha
v0.0.5-prealpha
v0.0.4-prealpha
v0.0.3-prealpha
v0.0.2-prealpha
v0.0.1-prealpha
Labels
Clear labels
ad-hoc
api
bug
ci-cd
content
dependencies
enhancement
frontend
in-progress
jellyfin
parked
priority: high
priority: low
priority: medium
review
security
One-off / ad-hoc work not tracked by a dedicated issue
REST API / HTTP endpoints
Something isn't working
Build, test, deploy pipeline
Channel content / schedules / playlists
Dependency updates (Renovate)
New feature or improvement
ChicoryTV React SPA frontend
Claimed by an active session — do not pick up
Jellyfin tuner / IPTV integration
Excluded from automatic queue pickup; work only when explicitly selected
Adversarial review finding
Security / vulnerability fix
Milestone
No items
No Milestone
Projects
Clear projects
No projects
No Assignees
Notifications
Due Date
No due date set.
Depends on
Reference: timothy/ersatztv#835
Reference in New Issue
Block a user
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
Deferred from #746, which set
persist-credentials: falseon all 14actions/checkoutsteps indocker-build.yml,pr-checks.ymlanddependency-scan.yml(review-verdict.ymlalready had it) and unmasked the five base-ref fetches that fed changed-file skip logic.What is missing
Nothing mechanically holds the convention. A new job added tomorrow gets a checkout without the flag and nothing goes red — the failure is silent by construction, which is the class
docs/defect-shapes-773.md§4 exists to catch.The obvious guard is a
scripts/tests/case that derives its population fromgit ls-files '.gitea/workflows/*.yml', parses each file, and asserts everyactions/checkoutstep setspersist-credentials: false(testing.guard-derives-population-from-source).Why it was NOT written in #746
.gitea/workflows/ci-image.ymlis the one checkout left unset, and it has to stay unset until #744 lands: any commit touching that file re-pointsci-image-pin'sexpectedat itself and reddens a blocking job, and its unfilteredpushtrigger publishes a toolchain image from whatever branch the edit lands on.So writing the guard now means shipping it with a hardcoded
ci-image.ymlexemption — a one-entry exception list whose only justification is a temporary condition in another issue. That entry outlives its reason silently: once #744 sets the flag there, the exemption still passes and the guard is permanently blind to that file. That is the rot shape, not a lint nit.Do this instead
Land it with or after #744, with no exemption list at all: #744 sets
persist-credentials: falseonci-image.yml's checkout as part of the same change that fixes its trigger, and then the guard's assertion is universal over the derived population.Done-when
ci-image.yml's checkout also setspersist-credentials: falsescripts/tests/case derives the workflow population fromgit ls-filesand asserts the flag on EVERYactions/checkout, with no exemption listtesting.guard-ships-with-mutation-proof,testing.mutation-claims-are-executed) and a row indocs/guard-inventory.mdClaiming alongside #744 in the same PR — this issue's own "Do this instead" says the guard should ride with #744 so it needs no exemption list. Same session, same branch.
Closing record
Outcome: Shipped in PR #857, riding with #744 exactly as this issue's "Do this instead" prescribed.
ci-image.yml's checkout takespersist-credentials: false(16 of 16), andscripts/tests/test_workflow_persist_credentials.pyasserts the flag on everyactions/checkoutin every tracked workflow with no exemption list.Root cause: N/A — a missing guard. #746 set the flag on 15 of 16 checkouts and nothing held the convention afterwards; a job added later would get a checkout without it and nothing would go red.
Decisions/conventions changed: None added. The guard row and the appendix population row are in
docs/guard-inventory.md; the declared clause mutation is inscripts/tests/mutation_manifest.py.Reusable knowledge:
actions/checkouthas far more valid spellings than it looks. Three review rounds found seven that escaped successive versions of the canonicaliser: a full URL, a host with NO dot (http://your-git-server/actions/checkout@v4is the documented self-hosted form), any letter case (the forge is case-insensitive on owner/repo), a.gitsuffix (how Gitea writes the clone URL),@-userinfo before the host (splitting on the FIRST@strips the host, not the version), and a doubled slash. Canonicalise by taking the last two path segments — no host heuristic to get wrong — and compare lowercase..github/workflowsor a nested subdirectory — both halves see zero and agree, so the check stays silent. Those four are covered by explicit ABSENCE tests instead, so the boundary reports itself rather than going blind.Verification:
scripts/testsfull suite 1026 passed / 2 skipped.test_mutation_harness.pyexecutes the declared clause mutation againstci-image.ymland confirms the named proof reddens with the declared diagnostic.test_guard_inventory.pyandtest_guard_populations_derive_from_git.pyboth pass, so the new file is in the derived guard population and its derivation is registered.Deferred: None for this issue. (#855, filed from the same PR, is about a different missing coupling.)
Docs updated:
docs/guard-inventory.md(main table row, appendix population row, summary counts 40/18/6/16), and the persist-credentials section ofdocs/ci-cd.md.