From 67547d998a0100a996aac033ed9d959e5c4390b2 Mon Sep 17 00:00:00 2001 From: Timothy Date: Sat, 11 Jul 2026 11:49:40 +0200 Subject: [PATCH] test(api): locked-path 409 guard tests for ReplaceAlternateSchedules + ReplaceTemplates (fixes #215) Closes the reviewer-verification gap from adversarial-reviewer#18: the locked-path 409 guard tests already existed for Delete, EraseItems, EraseItemsAndHistory, Update, and UpdateDefaultDeco, but were missing for PlayoutController.ReplaceAlternateSchedules and .ReplaceTemplates even though their production guards (entityLocker.IsPlayoutLocked) were in place. Added two tests mirroring the existing pattern exactly (409 ConflictObjectResult + ProblemDetails + DidNotReceive() on the mediator command). ApiErrorResponseMetadataTests and OpenApiErrorResponseContractTests already carried 409 rows for both PUT endpoints, so no changes were needed there. Co-Authored-By: Claude Fable 5 --- .../Controllers/PlayoutControllerTests.cs | 31 +++++++++++++++++++ 1 file changed, 31 insertions(+) diff --git a/ErsatzTV.Tests/Controllers/PlayoutControllerTests.cs b/ErsatzTV.Tests/Controllers/PlayoutControllerTests.cs index 2f8a85930..69b5171ef 100644 --- a/ErsatzTV.Tests/Controllers/PlayoutControllerTests.cs +++ b/ErsatzTV.Tests/Controllers/PlayoutControllerTests.cs @@ -744,6 +744,22 @@ public class PlayoutControllerTests list[1].ProgramScheduleId.ShouldBe(8); } + [Test] + public async Task ReplaceAlternateSchedules_Should_Return_409_When_Playout_Locked() + { + _entityLocker.IsPlayoutLocked(9).Returns(true); + + IActionResult result = await _controller.ReplaceAlternateSchedules( + 9, + new ReplacePlayoutAlternateSchedulesRequest([MakeAltRequest(7)]), + CancellationToken.None); + + var conflict = result.ShouldBeOfType(); + conflict.Value.ShouldBeOfType().Status.ShouldBe(409); + await _mediator.DidNotReceive() + .Send(Arg.Any(), Arg.Any()); + } + [Test] public async Task ReplaceAlternateSchedules_Should_Return_404_When_Playout_Missing() { @@ -954,6 +970,21 @@ public class PlayoutControllerTests list[1].DecoTemplateId.ShouldBe(5); } + [Test] + public async Task ReplaceTemplates_Should_Return_409_When_Playout_Locked() + { + _entityLocker.IsPlayoutLocked(9).Returns(true); + + IActionResult result = await _controller.ReplaceTemplates( + 9, + new ReplacePlayoutTemplatesRequest([MakeTemplateRequest(7, null)]), + CancellationToken.None); + + var conflict = result.ShouldBeOfType(); + conflict.Value.ShouldBeOfType().Status.ShouldBe(409); + await _mediator.DidNotReceive().Send(Arg.Any(), Arg.Any()); + } + [Test] public async Task ReplaceTemplates_Should_Return_404_When_Playout_Missing() { -- 2.47.3