Build ErsatzTV Image / Docs update reminder (pull_request) Successful in 6s
Build ErsatzTV Image / EF migration integrity (SQLite + MySql) (pull_request) Failing after 18m17s
Build ErsatzTV Image / Build & test (.NET) (pull_request) Failing after 18m41s
Build ErsatzTV Image / Build & push image (amd64) (pull_request) Has been cancelled
Backend mutation-hardening cluster from the 2026-07-11 mutation-safety audit sweep (adversarial-reviewer #22/#23), the parallel-safe backend-isolated slice. audit#22 F4 — standardize post-commit enqueues on CancellationToken.None: 20 command handlers under MediaCollections/, ProgramSchedules/, Playouts/, Channels/ threaded the request cancellationToken into work that runs AFTER SaveChangesAsync commits (WriteAsync rebuild/refresh enqueues, mediator.Publish, reindex, cache Refresh, and post-commit lookups that gate an enqueue). A late client-disconnect then turns an already-durable commit into a thrown request AND drops the side effect. Generalizes the #251 deco-handler fix. Excludes BuildPlayoutHandler (worker/background token, not a client-disconnect token), the config/FFmpeg multi-upsert handlers (partial-commit case, separate follow-up), and response-projection reloads (correctly keep the request token). audit#22 F2 — DeleteChannelHandler/DeletePlayoutHandler now delete the channel guide {number}.xml through IFileSystem.File.Delete (observable under MockFileSystem) and BEFORE the commit (a post-commit delete orphans the xml on a crash; the xml is regenerable on demand, so pre-commit delete is the safe order). audit#23 F4 — ReplacePlayoutAlternateScheduleItemsHandler rejects an empty item list in the handler (not only the controller pre-guard) so a direct caller can't trip the Max()-on-empty crash. Docs: api-conventions.md §7a (post-commit token convention + boundaries), decisions.md entry (rationale, sweep scope, #253 PR2-4 coordination note). Tests: guide-cache-delete-through-FS for both delete handlers, empty-list guard. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
65 lines
2.3 KiB
C#
65 lines
2.3 KiB
C#
using ErsatzTV.Application.Channels;
|
|
using ErsatzTV.Core;
|
|
using LanguageExt;
|
|
using ErsatzTV.Core.Errors;
|
|
using ErsatzTV.Infrastructure.Data;
|
|
using ErsatzTV.Tests.Support;
|
|
using Microsoft.EntityFrameworkCore;
|
|
using NUnit.Framework;
|
|
using Shouldly;
|
|
using Testably.Abstractions.Testing;
|
|
|
|
namespace ErsatzTV.Tests.Application.Channels;
|
|
|
|
[TestFixture]
|
|
public class DeleteChannelHandlerTests : ChannelHandlerTestBase
|
|
{
|
|
private DeleteChannelHandler MakeHandler(MockFileSystem? fileSystem = null) =>
|
|
new(Worker, Db.Factory, fileSystem ?? new MockFileSystem(), SearchTargets);
|
|
|
|
[Test]
|
|
public async Task Should_Return_NotFoundError_When_Channel_Missing()
|
|
{
|
|
Either<BaseError, Unit> result = await MakeHandler().Handle(new DeleteChannel(999), CancellationToken.None);
|
|
|
|
BaseError error = LeftOf(result);
|
|
error.ShouldBeOfType<NotFoundError>();
|
|
}
|
|
|
|
[Test]
|
|
public async Task Should_Delete_Existing_Channel()
|
|
{
|
|
await SeedChannel(1, "5");
|
|
|
|
Either<BaseError, Unit> result = await MakeHandler().Handle(new DeleteChannel(1), CancellationToken.None);
|
|
|
|
result.IsRight.ShouldBeTrue();
|
|
|
|
await using TvContext context = Db.CreateContext();
|
|
bool exists = await context.Channels.AnyAsync(c => c.Id == 1);
|
|
exists.ShouldBeFalse();
|
|
}
|
|
|
|
[Test]
|
|
public async Task Should_Delete_Guide_Cache_File_Through_FileSystem_Abstraction()
|
|
{
|
|
await SeedChannel(1, "5");
|
|
|
|
var fileSystem = new MockFileSystem();
|
|
string cacheFile = fileSystem.Path.Combine(FileSystemLayout.ChannelGuideCacheFolder, "5.xml");
|
|
fileSystem.Directory.CreateDirectory(FileSystemLayout.ChannelGuideCacheFolder);
|
|
await fileSystem.File.WriteAllTextAsync(cacheFile, "<tv/>");
|
|
fileSystem.File.Exists(cacheFile).ShouldBeTrue();
|
|
|
|
Either<BaseError, Unit> result =
|
|
await MakeHandler(fileSystem).Handle(new DeleteChannel(1), CancellationToken.None);
|
|
|
|
result.IsRight.ShouldBeTrue();
|
|
// routed through the abstraction (not static File.Delete), so the MockFileSystem observes the removal
|
|
fileSystem.File.Exists(cacheFile).ShouldBeFalse();
|
|
}
|
|
|
|
private static BaseError LeftOf<TR>(Either<BaseError, TR> either) =>
|
|
either.Match(Left: e => e, Right: _ => throw new AssertionException("Expected a Left result"));
|
|
}
|