Files
ersatztv/scripts
timothy 05d3e01fe0
Build ErsatzTV Image / CI toolchain image resolves (pull_request) Successful in 15s
PR Gates / CI image pin matches docker/ci (pull_request) Successful in 14s
PR Gates / Docs update reminder (pull_request) Successful in 20s
Build ErsatzTV Image / Delimiter ban (release path) (pull_request) Successful in 20s
PR Gates / Fix proofs (Proves trailers) (pull_request) Successful in 10s
PR Gates / decisions lifecycle (pull_request) Successful in 20s
review-verdict/h10 Awaiting review verdict for 05d3e01
Review verdict / Set review-verdict status (pull_request_target) Successful in 29s
PR Gates / Script lint and tests (ruff + pytest) (pull_request) Successful in 8m23s
Build ErsatzTV Image / Build & test (.NET) (pull_request) Successful in 8m58s
Build ErsatzTV Image / EF migration integrity (SQLite + MySql) (pull_request) Successful in 6m16s
Build ErsatzTV Image / Build & push image (amd64) (pull_request) Skipped
Build ErsatzTV Image / Functional E2E (curl + UI contracts) (pull_request) Successful in 7m56s
Build ErsatzTV Image / API docs in sync (OpenAPI + endpoint index) (pull_request) Successful in 10s
Build ErsatzTV Image / Formatting (changed .cs conform to .editorconfig) (pull_request) Successful in 9s
fix(803,664): round 9 — drop the fold's rstrip(); it was the one way the guard could LOSE a jq
Seventh cold review returned MERGEABLE and independently reproduced round 8's central result:
it verified the bash semantics from scratch (an indented continuation prints `- e X` and
`jq -\` + indented `e` exits 3; only a column-0 continuation re-forms the flag), and confirmed
by its own mutant table that reverting to the space-joining fold lets the reachable evasion
through. It also confirmed the shipped CI behaviour is untouched by rounds 7-9.

It left one Low and one surviving mutation, which are the same thing, so both close together.

`_fold_continuations` used `ln.rstrip()` to spot a continuation. Bash does not: a backslash
followed by whitespace escapes the SPACE, so the line does not continue. Tolerating it was the
ONLY route by which this fold could DESTROY a token rather than fabricate one — every other
divergence over-joins, which can at worst cost a false positive. The concrete shape, measured:
`ok=y\` with invisible trailing spaces, then a dedented `jq -e ...`, folds to `okyjq -e`, and
`\bjq\b` finds no word boundary after the `y`, so a live exit-status call reads as absent.

Dropping the `rstrip()` is a strict simplification toward the shell rather than another layer
of cleverness — the same direction as round 8 — so it does not restart the "3+ rounds on a
string-matching predicate, then WITHDRAW" clock. Verified both ways: with it gone, the
contrived shape above AND the genuinely reachable column-0 continuation both redden, and the
baseline stays green.

The reviewer also named the mutation that survived every fold case — dropping the `rstrip()` —
which was true because no case exercised trailing whitespace at all. That case now exists, and
it is the one that goes red first: I added it BEFORE the fix and watched it fail against the
shipped fold, then pass after. An assertion nobody has seen fail is not evidence.

Remaining known gaps, recorded rather than chased: a flag reaching jq through a variable
(`ef=-e; jq $ef`) is outside the detector's declared scope — indirection is not a spelling —
and the guard is function-scoped by design, so a helper CALLED by `count_pr_mutations` is not
covered. Both are documented choices; chasing either is the treadmill this branch withdrew
from.

Verification: 1224 passed, 2 skipped; ruff clean; decisions-validate OK; YAML ok. One file
changed, no shipped CI behaviour touched.
2026-08-29 00:34:21 +02:00
..
2024-01-15 10:29:07 -06:00
2024-01-16 13:28:46 -06:00