Build ErsatzTV Image / Docs update reminder (pull_request) Successful in 6s
Build ErsatzTV Image / EF migration integrity (SQLite + MySql) (pull_request) Failing after 18m17s
Build ErsatzTV Image / Build & test (.NET) (pull_request) Failing after 18m41s
Build ErsatzTV Image / Build & push image (amd64) (pull_request) Has been cancelled
Backend mutation-hardening cluster from the 2026-07-11 mutation-safety audit sweep (adversarial-reviewer #22/#23), the parallel-safe backend-isolated slice. audit#22 F4 — standardize post-commit enqueues on CancellationToken.None: 20 command handlers under MediaCollections/, ProgramSchedules/, Playouts/, Channels/ threaded the request cancellationToken into work that runs AFTER SaveChangesAsync commits (WriteAsync rebuild/refresh enqueues, mediator.Publish, reindex, cache Refresh, and post-commit lookups that gate an enqueue). A late client-disconnect then turns an already-durable commit into a thrown request AND drops the side effect. Generalizes the #251 deco-handler fix. Excludes BuildPlayoutHandler (worker/background token, not a client-disconnect token), the config/FFmpeg multi-upsert handlers (partial-commit case, separate follow-up), and response-projection reloads (correctly keep the request token). audit#22 F2 — DeleteChannelHandler/DeletePlayoutHandler now delete the channel guide {number}.xml through IFileSystem.File.Delete (observable under MockFileSystem) and BEFORE the commit (a post-commit delete orphans the xml on a crash; the xml is regenerable on demand, so pre-commit delete is the safe order). audit#23 F4 — ReplacePlayoutAlternateScheduleItemsHandler rejects an empty item list in the handler (not only the controller pre-guard) so a direct caller can't trip the Max()-on-empty crash. Docs: api-conventions.md §7a (post-commit token convention + boundaries), decisions.md entry (rationale, sweep scope, #253 PR2-4 coordination note). Tests: guide-cache-delete-through-FS for both delete handlers, empty-list guard. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
100 lines
4.3 KiB
C#
100 lines
4.3 KiB
C#
using System.Threading.Channels;
|
|
using ErsatzTV.Application.Playouts;
|
|
using ErsatzTV.Core;
|
|
using ErsatzTV.Core.Domain;
|
|
using ErsatzTV.Core.Interfaces.Repositories;
|
|
using ErsatzTV.Core.Scheduling;
|
|
using ErsatzTV.Infrastructure.Data;
|
|
using ErsatzTV.Infrastructure.Extensions;
|
|
using Microsoft.EntityFrameworkCore;
|
|
|
|
namespace ErsatzTV.Application.MediaCollections;
|
|
|
|
public class UpdateRerunCollectionHandler(
|
|
IDbContextFactory<TvContext> dbContextFactory,
|
|
IMediaCollectionRepository mediaCollectionRepository,
|
|
ChannelWriter<IBackgroundServiceRequest> channel)
|
|
: IRequestHandler<UpdateRerunCollection, Either<BaseError, Unit>>
|
|
{
|
|
public async Task<Either<BaseError, Unit>> Handle(
|
|
UpdateRerunCollection request,
|
|
CancellationToken cancellationToken)
|
|
{
|
|
await using TvContext dbContext = await dbContextFactory.CreateDbContextAsync(cancellationToken);
|
|
Validation<BaseError, RerunCollection> validation = await Validate(dbContext, request, cancellationToken);
|
|
return await validation.Apply(c => ApplyUpdateRequest(dbContext, c, request, cancellationToken));
|
|
}
|
|
|
|
private async Task<Unit> ApplyUpdateRequest(
|
|
TvContext dbContext,
|
|
RerunCollection c,
|
|
UpdateRerunCollection request,
|
|
CancellationToken cancellationToken)
|
|
{
|
|
c.Name = request.Name;
|
|
c.CollectionType = request.CollectionType;
|
|
c.CollectionId = request.Collection?.Id;
|
|
c.MultiCollectionId = request.MultiCollection?.Id;
|
|
c.SmartCollectionId = request.SmartCollection?.Id;
|
|
c.MediaItemId = request.MediaItem?.MediaItemId;
|
|
c.FirstRunPlaybackOrder = request.FirstRunPlaybackOrder;
|
|
c.RerunPlaybackOrder = request.RerunPlaybackOrder;
|
|
|
|
// rebuild playouts
|
|
if (await dbContext.SaveChangesAsync(cancellationToken) > 0)
|
|
{
|
|
// post-commit side effect runs on CancellationToken.None so a late request cancellation
|
|
// can't abort it after the commit landed (#254)
|
|
// refresh all playouts that use this rerun collection
|
|
foreach (int playoutId in await mediaCollectionRepository.PlayoutIdsUsingRerunCollection(
|
|
request.RerunCollectionId))
|
|
{
|
|
await channel.WriteAsync(new BuildPlayout(playoutId, PlayoutBuildMode.Refresh), CancellationToken.None);
|
|
}
|
|
}
|
|
|
|
return Unit.Default;
|
|
}
|
|
|
|
private static async Task<Validation<BaseError, RerunCollection>> Validate(
|
|
TvContext dbContext,
|
|
UpdateRerunCollection request,
|
|
CancellationToken cancellationToken) =>
|
|
(await RerunCollectionMustExist(dbContext, request, cancellationToken),
|
|
await ValidateName(dbContext, request),
|
|
await RerunCollectionSelectionValidation.SelectedEntityMustExist(
|
|
dbContext,
|
|
request.CollectionType,
|
|
request.Collection?.Id,
|
|
request.MultiCollection?.Id,
|
|
request.SmartCollection?.Id,
|
|
request.MediaItem?.MediaItemId,
|
|
cancellationToken))
|
|
.Apply((collectionToUpdate, _, _) => collectionToUpdate);
|
|
|
|
private static Task<Validation<BaseError, RerunCollection>> RerunCollectionMustExist(
|
|
TvContext dbContext,
|
|
UpdateRerunCollection updateCollection,
|
|
CancellationToken cancellationToken) =>
|
|
dbContext.RerunCollections
|
|
.SelectOneAsync(c => c.Id, c => c.Id == updateCollection.RerunCollectionId, cancellationToken)
|
|
.Map(o => o.ToValidation<BaseError>("Rerun collection does not exist."));
|
|
|
|
private static async Task<Validation<BaseError, string>> ValidateName(
|
|
TvContext dbContext,
|
|
UpdateRerunCollection updateCollection)
|
|
{
|
|
Validation<BaseError, string> result1 = updateCollection.NotEmpty(c => c.Name)
|
|
.Bind(_ => updateCollection.NotLongerThan(50)(c => c.Name));
|
|
|
|
bool duplicateName = await dbContext.RerunCollections
|
|
.AnyAsync(c => c.Id != updateCollection.RerunCollectionId && c.Name == updateCollection.Name);
|
|
|
|
Validation<BaseError, Unit> result2 = duplicateName
|
|
? Fail<BaseError, Unit>("Rerun collection name must be unique")
|
|
: Success<BaseError, Unit>(Unit.Default);
|
|
|
|
return (result1, result2).Apply((_, _) => updateCollection.Name);
|
|
}
|
|
}
|