Files
ersatztv/scripts
timothy 161c788a70 fix(807): the collision check did not walk the tree it was checking
Third round of the same shape in three consecutive commits, and the cleanest
statement of it yet.

The assertion added one commit ago — no property name may contain the separator —
iterated only the top-level `properties` of each named component schema. The
resolver it protects walks the WHOLE tree. So the two disagreed exactly where it
matters: a dotted name on a nested inline object, or inside an inline request
body, was undetected, and those are precisely the places the resolver qualifies a
name and can therefore collide. A guard for a hole, with the same hole.

`_property_names_containing_the_separator` now recurses over the parsed document
the way `_schema_refs` does. Witnessed across five shapes — top-level on a named
schema, a nested inline object, an `allOf` arm, under `items`, and inside an
inline request body — all detected; the middle three were not, before.

The transferable rule, which this issue has now paid for three times in a row: a
check must walk the SAME tree as the thing it checks. Not a similar tree, not the
obvious subset — the same one. Each of these three defects was introduced by the
commit fixing the previous one, so the pattern is not carelessness about the
subject, it is that a fix written to close one shape gets tested against that
shape only.

908 passed 2 skipped, ruff check 0, ruff format 0.
2026-08-23 01:36:32 +02:00
..
2024-01-15 10:29:07 -06:00
2024-01-16 13:28:46 -06:00