timothyandClaude Opus 4.8
8f7d240fc8
Build ErsatzTV Image / Build & test (.NET) (pull_request) Successful in 3m43s
Build ErsatzTV Image / EF migration integrity (SQLite + MySql) (pull_request) Successful in 4m58s
Build ErsatzTV Image / Build & push image (amd64) (pull_request) Has been skipped
Build ErsatzTV Image / Build & test (.NET) (push) Successful in 3m44s
Build ErsatzTV Image / EF migration integrity (SQLite + MySql) (push) Successful in 5m0s
Build ErsatzTV Image / Build & push image (amd64) (push) Successful in 3m41s
First slice of the REST API (ersatztv#2). Idiomatic REST over existing MediatR handlers; design in docs/rest-api.md.
Foundation: NotFoundError : BaseError (Core) to split 404 from 422; ApiResults mapping helpers (Either/Option -> 201+Location / 200 / 204 / 404 / 422), additive (existing *ToActionResult untouched); ApiKeyAuthorizationFilter (optional X-Api-Key on mutating actions, gated by Api:WriteKey, no-op when unset) — independent of the IPTV JWT toggle so Jellyfin/Dispatcharr reads are unaffected, applied at controller-class level so every mutating action incl. ResetPlayout is covered fail-safe.
Channels: POST /api/channels (201+Location), PUT/{id} (200/404), DELETE/{id} (204/404), GET/{id} (200/404). Request DTOs -> existing commands; responses reuse ChannelViewModel. Ported page-only validations into handlers (ShowInEpg-when-disabled, external-logo-URL, Group NotEmpty) + FFmpegProfile/Watermark/Filler existence on update for create-parity. Fixed a latent 500: the .Filter(c>0) existence pattern threw TaskCanceledException on not-found; rewritten to AnyAsync.
Tests (NUnit, TZ=UTC): handler success/404/422, ApiResults mapping, API-key filter, controller status/Location/mapping, a controller-security regression net, and a create->read->delete EF integration test on a new in-memory SQLite harness. ErsatzTV.Tests 46/46, Architecture 5/5.
Refs #34
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
61 lines
2.1 KiB
C#
61 lines
2.1 KiB
C#
using ErsatzTV.Core;
|
|
using ErsatzTV.Core.Domain;
|
|
|
|
namespace ErsatzTV.Application.Channels;
|
|
|
|
/// <summary>
|
|
/// Validation rules shared by <see cref="CreateChannelHandler" /> and
|
|
/// <see cref="UpdateChannelHandler" />. These were previously enforced only by the Blazor page
|
|
/// (<c>ChannelEditViewModelValidator</c>); porting them into the handlers makes them apply to
|
|
/// the REST API as well. Failures map to HTTP 422.
|
|
/// </summary>
|
|
internal static class ChannelValidations
|
|
{
|
|
/// <summary>
|
|
/// A channel must belong to a non-empty group; the value is used as the M3U
|
|
/// <c>group-title</c>. Mirrors the Blazor rule <c>RuleFor(x => x.Group).NotEmpty()</c>.
|
|
/// </summary>
|
|
internal static Validation<BaseError, string> ValidateGroup(string group)
|
|
{
|
|
// Use explicit returns (not a ternary): BaseError has an implicit string conversion, so a
|
|
// ternary would collapse both branches to BaseError and always produce a Fail.
|
|
if (string.IsNullOrWhiteSpace(group))
|
|
{
|
|
return BaseError.New("Channel group is required");
|
|
}
|
|
|
|
return group;
|
|
}
|
|
|
|
/// <summary>A disabled channel may not be shown in the EPG.</summary>
|
|
internal static Validation<BaseError, bool> ValidateShowInEpg(bool isEnabled, bool showInEpg)
|
|
{
|
|
if (!isEnabled && showInEpg)
|
|
{
|
|
return BaseError.New("Disabled channels cannot be shown in EPG");
|
|
}
|
|
|
|
return showInEpg;
|
|
}
|
|
|
|
/// <summary>
|
|
/// A logo path that is an absolute URI must be a valid external (http/https) url.
|
|
/// Relative/local logo paths and empty values are allowed.
|
|
/// </summary>
|
|
internal static Validation<BaseError, string> ValidateLogo(string logoPath)
|
|
{
|
|
if (string.IsNullOrWhiteSpace(logoPath))
|
|
{
|
|
return string.Empty;
|
|
}
|
|
|
|
bool isAbsoluteUri = Uri.TryCreate(logoPath, UriKind.Absolute, out _);
|
|
if (isAbsoluteUri && !Artwork.IsExternalUrl(logoPath))
|
|
{
|
|
return BaseError.New("External logo url is invalid");
|
|
}
|
|
|
|
return logoPath;
|
|
}
|
|
}
|