Build ErsatzTV Image / CI image pin matches docker/ci (pull_request) Successful in 8s
Build ErsatzTV Image / API docs in sync (OpenAPI + endpoint index) (pull_request) Successful in 12s
Build ErsatzTV Image / Docs update reminder (pull_request) Successful in 8s
Build ErsatzTV Image / decisions.md append-only (pull_request) Successful in 40s
Build ErsatzTV Image / Formatting (changed .cs conform to .editorconfig) (pull_request) Successful in 7m25s
Build ErsatzTV Image / Functional E2E (curl contracts) (pull_request) Successful in 14m59s
Build ErsatzTV Image / EF migration integrity (SQLite + MySql) (pull_request) Successful in 19m3s
Build ErsatzTV Image / Build & test (.NET) (pull_request) Successful in 19m47s
Build ErsatzTV Image / Build & push image (amd64) (pull_request) Has been skipped
Two concurrent adds of the same item both membership-check it absent, both insert the CollectionItem composite key, and the loser's SaveChangesForcingVersion threw an uncaught DbUpdateException (SQLite 19 / MySQL 1062) -> 500. Now the loser is an idempotent no-op. - ConcurrencyExtensions.TrySaveChangesForcingVersion: bool-returning sibling that catches only a classified unique/PK violation and returns false. - 10 single-item Add*ToCollection handlers: return Unit.Default (no-op, skip fan-out) on false — the racing winner already inserted + rotated + rebuilt. - Bulk AddItemsToCollection: retry on a fresh context against recomputed membership so a partial-overlap collision doesn't drop the non-colliding items (bounded loop; common no-collision path runs once). - Provider detection via a TvContext.IsUniqueConstraintViolation static delegate (matches the existing IsSqlite/LastInsertedRowId provider seam), wired from Startup to SqliteErrorClassifier / MySqlErrorClassifier. - Add*ToPlaylist is NOT affected (PlaylistItem has its own identity PK; a playlist may legitimately contain the same item more than once). Tests: a negative-control anchor proves the race genuinely throws a classified exception; end-to-end handler tests reproduce a real cross-connection race via a shared-cache SQLite harness + a SavingChanges interceptor (the single-conn in-memory fixture cannot). Every fix-dependent test verified to fail with the catch disabled. Docs: api-conventions.md §7a (idempotent insert under concurrency) + decisions/optimistic-concurrency.md. fixes #308 Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
69 lines
2.5 KiB
C#
69 lines
2.5 KiB
C#
using ErsatzTV.Infrastructure;
|
|
using ErsatzTV.Infrastructure.Data;
|
|
using ErsatzTV.Infrastructure.Sqlite.Data;
|
|
using Microsoft.Data.Sqlite;
|
|
using Microsoft.EntityFrameworkCore;
|
|
using Microsoft.Extensions.Logging.Abstractions;
|
|
|
|
namespace ErsatzTV.Tests.Support;
|
|
|
|
/// <summary>
|
|
/// In-memory SQLite harness for handler/integration tests. A single <see cref="SqliteConnection" />
|
|
/// is kept open for the lifetime of the harness so the schema (built via
|
|
/// <see cref="DatabaseFacade.EnsureCreatedAsync" />) and data persist across the multiple
|
|
/// <see cref="TvContext" /> instances created by an <see cref="IDbContextFactory{TvContext}" />.
|
|
/// Foreign keys are disabled so partial graphs can be seeded without satisfying every FK.
|
|
/// </summary>
|
|
public sealed class InMemoryTvContext : IAsyncDisposable
|
|
{
|
|
private readonly SqliteConnection _connection;
|
|
private readonly DbContextOptions<TvContext> _options;
|
|
|
|
private InMemoryTvContext(SqliteConnection connection, DbContextOptions<TvContext> options)
|
|
{
|
|
_connection = connection;
|
|
_options = options;
|
|
}
|
|
|
|
public IDbContextFactory<TvContext> Factory => new TestDbContextFactory(_options);
|
|
|
|
public static async Task<InMemoryTvContext> CreateAsync()
|
|
{
|
|
TvContext.IsSqlite = true;
|
|
TvContext.IsUniqueConstraintViolation = SqliteErrorClassifier.IsUniqueConstraintViolation;
|
|
|
|
var connection = new SqliteConnection("Data Source=:memory:;Foreign Keys=False");
|
|
await connection.OpenAsync();
|
|
|
|
DbContextOptions<TvContext> options = new DbContextOptionsBuilder<TvContext>()
|
|
.UseSqlite(connection)
|
|
.Options;
|
|
|
|
await using (TvContext context = Create(options))
|
|
{
|
|
await context.Database.EnsureCreatedAsync();
|
|
await context.Database.ExecuteSqlRawAsync("PRAGMA foreign_keys=OFF");
|
|
}
|
|
|
|
return new InMemoryTvContext(connection, options);
|
|
}
|
|
|
|
public TvContext CreateContext() => Create(_options);
|
|
|
|
public async ValueTask DisposeAsync()
|
|
{
|
|
await _connection.DisposeAsync();
|
|
}
|
|
|
|
private static TvContext Create(DbContextOptions<TvContext> options) =>
|
|
new(
|
|
options,
|
|
NullLoggerFactory.Instance,
|
|
new SlowQueryInterceptor(NullLogger<SlowQueryInterceptor>.Instance));
|
|
|
|
private sealed class TestDbContextFactory(DbContextOptions<TvContext> options) : IDbContextFactory<TvContext>
|
|
{
|
|
public TvContext CreateDbContext() => Create(options);
|
|
}
|
|
}
|