Build ErsatzTV Image / CI image pin matches docker/ci (pull_request) Successful in 9s
Build ErsatzTV Image / Docs update reminder (pull_request) Successful in 5s
Build ErsatzTV Image / decisions.md append-only (pull_request) Successful in 5s
Build ErsatzTV Image / Build & test (.NET) (pull_request) Successful in 7m6s
Build ErsatzTV Image / API docs in sync (OpenAPI + endpoint index) (pull_request) Successful in 7s
Build ErsatzTV Image / Functional E2E (curl contracts) (pull_request) Successful in 14m27s
Build ErsatzTV Image / EF migration integrity (SQLite + MySql) (pull_request) Successful in 19m10s
Build ErsatzTV Image / Build & push image (amd64) (pull_request) Has been skipped
Build ErsatzTV Image / Formatting (changed .cs conform to .editorconfig) (pull_request) Successful in 13m24s
Adds one Information-level structured log per HLS tune-in cold-start so the real driver breakdown can be measured on prod before optimizing the transcode pipeline (measure-before-optimize). Log-only; no transcode behavior change. - WaitForPlaylistSegments returns a PlaylistSegmentsResult: Phase A (process startup -> playlist exists) vs Phase B (segment fill), segments reached, deadline-expired. - StartFFmpegSessionHandler emits one summary: total = setup + startup + fill, plus cleanly-detectable feature flags (subtitle burn-in, hwaccel family). - ColdStartFeatures: pure, unit-tested args->features helper (14 cases). Watermark / HDR->SDR / image-subtitle burn-in are deliberately not flagged (all reduce to overlay= in the args, indistinguishable); the full ffmpeg arguments remain available at Debug. Refs #350 (instrumentation slice; optimization deferred pending real data). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
202 lines
8.8 KiB
C#
202 lines
8.8 KiB
C#
using System.Diagnostics;
|
|
using System.IO.Abstractions;
|
|
using System.Threading.Channels;
|
|
using ErsatzTV.Application.Channels;
|
|
using ErsatzTV.Application.Graphics;
|
|
using ErsatzTV.Application.Maintenance;
|
|
using ErsatzTV.Core;
|
|
using ErsatzTV.Core.Domain;
|
|
using ErsatzTV.Core.Errors;
|
|
using ErsatzTV.Core.FFmpeg;
|
|
using ErsatzTV.Core.Interfaces.FFmpeg;
|
|
using ErsatzTV.Core.Interfaces.Metadata;
|
|
using ErsatzTV.Core.Interfaces.Repositories;
|
|
using ErsatzTV.Core.Interfaces.Streaming;
|
|
using ErsatzTV.FFmpeg;
|
|
using ErsatzTV.FFmpeg.OutputFormat;
|
|
using Microsoft.Extensions.DependencyInjection;
|
|
using Microsoft.Extensions.Hosting;
|
|
using Microsoft.Extensions.Logging;
|
|
|
|
namespace ErsatzTV.Application.Streaming;
|
|
|
|
public class StartFFmpegSessionHandler : IRequestHandler<StartFFmpegSession, Either<BaseError, Unit>>
|
|
{
|
|
private readonly IFileSystem _fileSystem;
|
|
private readonly IConfigElementRepository _configElementRepository;
|
|
private readonly IFFmpegSegmenterService _ffmpegSegmenterService;
|
|
private readonly IGraphicsEngine _graphicsEngine;
|
|
private readonly IHlsPlaylistFilter _hlsPlaylistFilter;
|
|
private readonly IHlsInitSegmentCache _hlsInitSegmentCache;
|
|
private readonly IHostApplicationLifetime _hostApplicationLifetime;
|
|
private readonly ILocalFileSystem _localFileSystem;
|
|
private readonly ILogger<StartFFmpegSessionHandler> _logger;
|
|
private readonly IMediator _mediator;
|
|
private readonly IServiceScopeFactory _serviceScopeFactory;
|
|
private readonly ILogger<HlsSessionWorker> _sessionWorkerLogger;
|
|
private readonly ChannelWriter<IBackgroundServiceRequest> _workerChannel;
|
|
|
|
public StartFFmpegSessionHandler(
|
|
IHlsPlaylistFilter hlsPlaylistFilter,
|
|
IHlsInitSegmentCache hlsInitSegmentCache,
|
|
IServiceScopeFactory serviceScopeFactory,
|
|
IMediator mediator,
|
|
IFileSystem fileSystem,
|
|
ILocalFileSystem localFileSystem,
|
|
ILogger<StartFFmpegSessionHandler> logger,
|
|
ILogger<HlsSessionWorker> sessionWorkerLogger,
|
|
IFFmpegSegmenterService ffmpegSegmenterService,
|
|
IConfigElementRepository configElementRepository,
|
|
IGraphicsEngine graphicsEngine,
|
|
IHostApplicationLifetime hostApplicationLifetime,
|
|
ChannelWriter<IBackgroundServiceRequest> workerChannel)
|
|
{
|
|
_hlsPlaylistFilter = hlsPlaylistFilter;
|
|
_hlsInitSegmentCache = hlsInitSegmentCache;
|
|
_serviceScopeFactory = serviceScopeFactory;
|
|
_mediator = mediator;
|
|
_fileSystem = fileSystem;
|
|
_localFileSystem = localFileSystem;
|
|
_logger = logger;
|
|
_sessionWorkerLogger = sessionWorkerLogger;
|
|
_ffmpegSegmenterService = ffmpegSegmenterService;
|
|
_configElementRepository = configElementRepository;
|
|
_graphicsEngine = graphicsEngine;
|
|
_hostApplicationLifetime = hostApplicationLifetime;
|
|
_workerChannel = workerChannel;
|
|
}
|
|
|
|
public Task<Either<BaseError, Unit>> Handle(StartFFmpegSession request, CancellationToken cancellationToken) =>
|
|
Validate(request)
|
|
.MapT(_ => StartProcess(request, cancellationToken))
|
|
// this weirdness is needed to maintain the error type (.ToEitherAsync() just gives BaseError)
|
|
#pragma warning disable VSTHRD103
|
|
.Bind(v => v.ToEither().MapLeft(seq => seq.Head()).MapAsync<BaseError, Task<Unit>, Unit>(identity));
|
|
#pragma warning restore VSTHRD103
|
|
|
|
private async Task<Unit> StartProcess(StartFFmpegSession request, CancellationToken cancellationToken)
|
|
{
|
|
// measures the full client-visible cold-start: this handler only runs when the session
|
|
// is not already active, so its whole duration is the tune-in delay the client waits on
|
|
var coldStartStopwatch = Stopwatch.StartNew();
|
|
|
|
Option<TimeSpan> idleTimeout = await _configElementRepository
|
|
.GetValue<int>(ConfigElementKey.FFmpegSegmenterTimeout, cancellationToken)
|
|
.Map(maybeTimeout => maybeTimeout.Match(i => TimeSpan.FromSeconds(i), () => TimeSpan.FromMinutes(1)));
|
|
|
|
Option<FrameRate> targetFramerate = await _mediator.Send(
|
|
new GetChannelFramerate(request.ChannelNumber),
|
|
cancellationToken);
|
|
|
|
// disable idle timeout when configured to keep running
|
|
Option<ChannelViewModel> channel =
|
|
await _mediator.Send(new GetChannelByNumber(request.ChannelNumber), cancellationToken);
|
|
if (await channel.Map(c => c.IdleBehavior is ChannelIdleBehavior.KeepRunning).IfNoneAsync(false))
|
|
{
|
|
idleTimeout = Option<TimeSpan>.None;
|
|
}
|
|
|
|
await _mediator.Send(new RefreshGraphicsElements(), cancellationToken);
|
|
|
|
HlsSessionWorker worker = GetSessionWorker(request, targetFramerate);
|
|
|
|
_ffmpegSegmenterService.AddOrUpdateWorker(request.ChannelNumber, worker);
|
|
|
|
// fire and forget worker
|
|
_ = worker.Run(request.ChannelNumber, idleTimeout, _hostApplicationLifetime.ApplicationStopping)
|
|
.ContinueWith(
|
|
_ =>
|
|
{
|
|
_ffmpegSegmenterService.RemoveWorker(request.ChannelNumber, out IHlsSessionWorker inactiveWorker);
|
|
|
|
inactiveWorker?.Dispose();
|
|
|
|
_workerChannel.TryWrite(new ReleaseMemory(false));
|
|
},
|
|
TaskScheduler.Default);
|
|
|
|
int initialSegmentCount = await _configElementRepository
|
|
.GetValue<int>(ConfigElementKey.FFmpegInitialSegmentCount, cancellationToken)
|
|
.Map(maybeCount => maybeCount.Match(identity, () => 1));
|
|
|
|
PlaylistSegmentsResult segments = await worker.WaitForPlaylistSegments(initialSegmentCount, cancellationToken);
|
|
coldStartStopwatch.Stop();
|
|
|
|
// #350 cold-start instrumentation: one self-describing sample per tune-in so the real
|
|
// driver split (process startup vs segment fill, and which heavy features were active)
|
|
// can be measured on prod before any transcode-pipeline optimization.
|
|
// "setup" is the pre-wait handler overhead (config reads + framerate/channel/graphics
|
|
// mediator sends + worker spawn) so total = setup + startup + fill accounts for every ms.
|
|
long totalMs = (long)coldStartStopwatch.Elapsed.TotalMilliseconds;
|
|
long startupMs = (long)segments.ProcessStartup.TotalMilliseconds;
|
|
long fillMs = (long)segments.SegmentFill.TotalMilliseconds;
|
|
long setupMs = Math.Max(0, totalMs - startupMs - fillMs);
|
|
_logger.LogInformation(
|
|
"HLS cold-start channel {Channel} mode {Mode}: total {TotalMs}ms " +
|
|
"(setup {SetupMs}ms + startup {ProcessStartupMs}ms + fill {SegmentFillMs}ms), " +
|
|
"segments {SegmentsReached}/{InitialSegmentCount}, " +
|
|
"deadlineExpired {DeadlineExpired}, subtitleBurnIn {SubtitleBurnIn}, hwaccel {HwAccel}",
|
|
request.ChannelNumber,
|
|
request.Mode,
|
|
totalMs,
|
|
setupMs,
|
|
startupMs,
|
|
fillMs,
|
|
segments.SegmentsReached,
|
|
segments.InitialSegmentCount,
|
|
segments.DeadlineExpired,
|
|
segments.Features.SubtitleBurnIn,
|
|
segments.Features.HardwareAcceleration);
|
|
|
|
return Unit.Default;
|
|
}
|
|
|
|
private HlsSessionWorker GetSessionWorker(StartFFmpegSession request, Option<FrameRate> targetFramerate) =>
|
|
request.Mode switch
|
|
{
|
|
_ => new HlsSessionWorker(
|
|
_serviceScopeFactory,
|
|
_graphicsEngine,
|
|
OutputFormatKind.Hls,
|
|
_hlsPlaylistFilter,
|
|
_hlsInitSegmentCache,
|
|
_configElementRepository,
|
|
_fileSystem,
|
|
_localFileSystem,
|
|
_sessionWorkerLogger,
|
|
targetFramerate)
|
|
};
|
|
|
|
private Task<Validation<BaseError, Unit>> Validate(StartFFmpegSession request) =>
|
|
SessionMustBeInactive(request)
|
|
.BindT(_ => FolderMustBeEmpty(request));
|
|
|
|
private Task<Validation<BaseError, Unit>> SessionMustBeInactive(StartFFmpegSession request)
|
|
{
|
|
var result = Optional(_ffmpegSegmenterService.TryAddWorker(request.ChannelNumber, null))
|
|
.Where(success => success)
|
|
.Map(_ => Unit.Default)
|
|
.ToValidation<BaseError>(new ChannelSessionAlreadyActive());
|
|
|
|
if (result.IsFail && _ffmpegSegmenterService.TryGetWorker(
|
|
request.ChannelNumber,
|
|
out IHlsSessionWorker worker))
|
|
{
|
|
worker?.Touch(Option<string>.None);
|
|
}
|
|
|
|
return result.AsTask();
|
|
}
|
|
|
|
private Task<Validation<BaseError, Unit>> FolderMustBeEmpty(StartFFmpegSession request)
|
|
{
|
|
string folder = Path.Combine(FileSystemLayout.TranscodeFolder, request.ChannelNumber);
|
|
_logger.LogDebug("Preparing transcode folder {Folder}", folder);
|
|
|
|
_localFileSystem.EnsureFolderExists(folder);
|
|
_localFileSystem.EmptyFolder(folder);
|
|
|
|
return Task.FromResult<Validation<BaseError, Unit>>(Unit.Default);
|
|
}
|
|
}
|