Round 3's cold review found the same defect class for the third round running,
and this time in the fix for round 2's finding. That fix pinned the shared
`isInScopeSourcePath` with a hand-written table of 8 example paths. The table
names four of `src/`'s eight directories, so it proved only the one mutation the
previous round happened to use. MEASURED: narrowing the predicate to skip
`media|app|mediaSources|schedules` removed 23 real, tracked, on-disk files —
16% of the SPA — with all 35 tests green, and `/media/` alone was green too.
That is precisely what the rule it was meant to satisfy calls out: "a
hand-written literal list of members is the same defect in slower motion — a
filter frozen at authoring time, correct on the day it was written and unable to
report the day it stopped being."
So the mechanism is deleted rather than extended. The scope is now proved by
DECOMPOSITION over the whole tracked population: the predicate must equal its two
documented components — `!includes('/generated/')` and `isScannableSourceFileName`
— each already independently pinned by the 14-case filename table. Any new term,
naming any directory or any filename shape, makes the two sets differ. MEASURED
red against all four mutations above plus a filename-shaped one
(`!endsWith('.d.ts')`) that a path table could never have seen. The table stays
as worked examples and now says so instead of claiming to be the proof.
Also from round 3:
- The anti-vacuity floor's stated reason was falsified by the commit that wrote
it: with the fixture test present, `expectedTrackedSources -> []` reddens even
without the floor. Restated as what the floor uniquely covers — vacuity in the
REAL plugin output, which injected fixtures structurally cannot reach — and the
floor is now derived from the index size rather than a literal that was true
once. The stale "1249-test suite" figure is gone with it.
- `testing.guard-derives-population-from-source` states "assert existence rather
than filtering on it" in its `rule:` field, so the catalog row a reader
resolves by topic said the opposite of what this guard does. The record now
carries the bounded exception — filtering on existence is admissible only where
the OTHER direction reports the on-disk hole, so the absent member stays
representable — and the catalog is regenerated. Without that pairing it remains
the original defect.
- Three cross-references the refactor invalidated: the `/generated/` exclusion
moved to `isInScopeSourcePath`, and one comment said "above" of a predicate
defined below.
- guard-inventory: the docstring quote is attributed to
`test_every_index_derived_module_is_registered` rather than the module, with the
elided `Path.rglob` clause restored, and the over-long line rewrapped.
Refs: #819
Decisions-Edit: yes