Review round 6: one MERGEABLE with non-blocking prose, one NOT-MERGEABLE with a real
test defect. Both addressed.
THE n PIN DID NOT PIN ANYTHING. `assert n == 10` was checked against a fixture holding
exactly ten records, so a mutation returning a constant 10 for EVERY input satisfied it —
while changing the live denominator from 183 to 10, which is precisely the production
defect the test was added to close. A single hardcoded count cannot tell "counts the
input" from "returns this number". Now a dynamic oracle at two distinct cardinalities;
verified the constant-n mutation fails it.
"MOVED p90 by 21 lines" asserted a history I had not measured. 21 is TODAY's gap (60 ->
81). The actual #672 event was smaller — at that tree p90 was 60 with the next value 83,
so the 62-line record moved p90 to 62 and reddened CI with a 2-line move. The capability
claim is what matters and is true at both refs; the past tense was not. Changed to "can
move" in the two places that asserted it, which also makes all four sites agree with
docs/ci-cd.md and the validator docstring, both of which already said "could".
A REVIEW FINDING I REJECTED, having measured it. Round 6 called "p90 52" wrong for the
#620-era distribution, measuring 57. That measurement is at `fefd11dff`; the record cites
`f394d6ce`, and at THAT sha p90 is exactly 52 (n=167, min 2, median 26). The number is
correct as written and is unchanged. Recording the disagreement rather than silently
keeping it: the reviewer measured a different tree than the one the claim names.
Also corrected in this branch's own commit message trail: `b24c51ab5` said origin/main
has three 59-line records; it has four 59s and two 60s (HEAD: four and three). The claim
that survives, and the only one the code and docs now make, is that NOTHING sits between
61 and 80 at either ref — verified independently at both.
Cosmetics from the same round: a dangling modifier in ceiling_calibration's docstring, a
test_decisions_lib assertion message that said "field(s) differ" when faults can now also
be rejections, and a sentence in corpus-size-signal that named the replacement test
without saying what it asserts.
Verification: 431 scripts/tests pass; ruff at baseline parity (47); validator exits 0 with
no drift notice; corpus at p90=60, 18/183, calibrated.
Decisions-Edit: yes
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
timothyandClaude Opus 5
2ff52d4236