Files
ersatztv/docs/decisions/records/media/lastscan-null-boundary.md
T
timothy fba5233caf
PR Gates / CI image pin matches docker/ci (pull_request) Successful in 11s
PR Gates / Docs update reminder (pull_request) Successful in 16s
PR Gates / decisions lifecycle (pull_request) Failing after 23s
Build ErsatzTV Image / Formatting (changed .cs conform to .editorconfig) (pull_request) Successful in 1m17s
Build ErsatzTV Image / API docs in sync (OpenAPI + endpoint index) (pull_request) Successful in 1m29s
Build ErsatzTV Image / Build & test (.NET) (pull_request) Successful in 8m5s
Build ErsatzTV Image / EF migration integrity (SQLite + MySql) (pull_request) Successful in 16m5s
Build ErsatzTV Image / Functional E2E (curl + UI contracts) (pull_request) Successful in 17m6s
Build ErsatzTV Image / Build & push image (amd64) (pull_request) Has been skipped
feat(610): split the decision corpus into one YAML-frontmatter file per record
168 records -> docs/decisions/records/<area>/<topic>.md (163 active, 23 dirs) and
docs/decisions/archive/<area>/<topic>.md (5 archived). The filename IS the key,
so one-active-record-per-key becomes a filesystem property rather than a
validator check, and supersession becomes a `git mv`.

WHY: the monolith was a concurrency problem before an aesthetic one. A
3,900-line append target made parallel sessions collide -- PR #605 and PR #614
both hit append-vs-append conflicts during routine rebases, and hand-resolving
those inside the corpus is exactly the operation the rationale-rewrite guard
exists to police.

HOW IT IS VERIFIED: a ~170-file diff cannot be meaningfully read, so correctness
does not rest on reading it. The parser was taught BOTH formats first, so the
body-diff guard parses the old form at the merge-base and the new form at head --
the migration validates itself, no bypass. The proof is a field-level equivalence
harness: 168 records before and after, zero lost, zero gained, zero field
mismatches, zero rationale bodies differing. Reviewers should scrutinise the
harness; it is the actual evidence.

What measuring caught that reading would not have:

- ~500 lines sit OUTSIDE any record -- decisions.md's lifecycle schema and each
  topic file's preamble, mostly the only copy. Source files are kept and
  stripped, never deleted. They also cannot be filed per-area: topic files hold
  several areas and 4 of 23 areas span several files.
- Archive discovery was a non-recursive glob; after the split it found ZERO
  archived records, surfacing as four bogus "supersedes points to unknown key"
  errors rather than an obvious failure.
- ~32 live docs point into the corpus BY DATE, which the split dangles. Each
  stripped file now ends with a generated "Records formerly in this file" index,
  which also rescues the identical breadcrumbs in old issue comments.
- decisions.md's "In this file:" list was 97 same-file anchor bullets that the
  split makes WRONG, not merely stale. Dropped; the generated index replaces
  them with links that resolve.

The equivalence harness now runs against a checked-in FIXTURE, not the live
corpus. The earlier version migrated the real tree, which made it a one-shot:
the moment the migration landed there was nothing left to move and the tests
failed for reasons unrelated to the code. A fixture keeps them testing the
SCRIPT rather than the repo's current state.

Keys preserved verbatim, warts included: `sched` (12) and `scheduling` (1) remain
two directories for one concept. Renaming a key is not a move -- it changes
identity, breaks the equivalence proof, and invalidates MemPalace's per-key
drawers. Taxonomy normalisation is separate work.

refs #610
2026-07-25 19:45:09 +02:00

4.6 KiB

key, title, status, since, supersedes, superseded-by, rule, signals, mechanics
key title status since supersedes superseded-by rule signals mechanics
media.lastscan-null-boundary 2026-07-18 — Never-scanned `LastScan` surfaces as null at the API boundary, not the 0001-01-01 MinValue sentinel (#409) active 2026-07-18 none none A never-scanned `LastScan` surfaces as `null` at the API/MCP boundary, not the `0001-01-01` MinValue sentinel — enforced by an ongoing read-boundary coercion plus a one-time data migration cleanup. LastScan, MinValue sentinel, API-boundary honesty · paths: `GetAllMediaSourcesForApiHandler.NormalizeLastScan`, `MediaSourceRepository` · issues: #409, #460 `NullOutNeverScannedLastScan` migration; `LibrariesScreen.tsx` `hasScanned` removal; #460 write-side `null`

Library.LastScan / LibraryPath.LastScan are DateTime?; a never-scanned library is null at runtime for a freshly-created row. But the 0001-01-01 00:00:00 MinValue sentinel appeared in the DB from two sources — both now closed:

  1. Old Reset_* migrations wrote it via raw SQL (UPDATE Library SET LastScan = '0001-01-01 00:00:00').
  2. Live code wrote it on the Plex/Jellyfin/Emby remove-and-recreate (disable-sync) flows in MediaSourceRepository. Closed by #460: those three writes now set null, so normal use no longer produces new sentinel rows. Safe because every remaining LastScan reader either coalesces (LastScan ?? SystemTime.MinValueUtc) for its own non-nullable scan-comparison, or is the read-boundary coercion below — scan-comparison behavior is unchanged.

GetAllMediaSourcesForApiHandler projected l.LastScan straight onto its DateTime? DTO, so that sentinel leaked to API/MCP clients as a fake midnight timestamp — the SPA papered over it with a client-side year<1900 heuristic (#409 first pass). Decision: the API is the right place to be honest, so never-scanned reports as null for API/MCP parity with the UI, via two layers:

  • Read-boundary coercion — the load-bearing guard (provider/history-independent): GetAllMediaSourcesForApiHandler.NormalizeLastScan maps any < 2000-01-01 value to null. It stays permanent even after #460 closed source #2: it is what makes the contract hold for sentinel rows this codebase is not going to rewrite — a restored or hand-edited DB, and any row written by source #2 between #409's cleanup migration and #460 — and a migration-only fix would have regressed the next time a user toggled a library's sync off.
  • Data migration (NullOutNeverScannedLastScan, dual-provider): a one-time cleanup of the historical residue — UPDATE Library/LibraryPath SET LastScan = NULL WHERE LastScan IS NOT NULL AND LastScan < '2000-01-01'. Data-only (empty Up/Down otherwise, both TvContextModelSnapshot.cs byte-identical). The < '2000-01-01' predicate matches the 0001-01-01 sentinel robustly on both providers (ISO-text compare on SQLite, whatever the out-of-range zero date stored on MySQL — where no Reset_*LastScan migration ever ran, so it's a safe no-op there) without depending on the exact stored bytes; no real scan predates ErsatzTV. Down is a no-op — the original sentinel is unrecoverable and worthless.

GetAllMediaSourcesForApiHandler is the only API/MCP-facing consumer of LastScan (grepped LastScan under ErsatzTV.Application/**/Queries and ErsatzTV/Controllers); the other reads are internal scanner code that coalesces to SystemTime.MinValueUtc for its own non-nullable DateTimeOffset scan-comparison needs and never serializes it to a client. The DTO field was already DateTime?, so the OpenAPI schema is unchanged (no regen). The SPA's hasScanned heuristic in LibrariesScreen.tsx was removed — both call sites revert to a plain null/truthy check now that the API is honest.

#460 (write side, 2026-07-25): the follow-up this record deferred is done — the three disable-sync writes set null instead of MinValue, so no new sentinel rows are created. Deliberately ships no second cleanup migration: rows written by source #2 between #409's NullOutNeverScannedLastScan and this change still hold the sentinel at rest, and the read coercion above (not a migration) is what keeps the contract honest for them. Regression-tested per provider in MediaSourceRepositoryDisableSyncTests. LibraryPath.LastScan is deliberately left untouched — the disable-sync flows re-add Paths with their original values, and the only readers of the path-level column are the local-library scan handlers, so it has no API surface and no remote-scan effect. This extends the rule rather than reversing it: the read-boundary coercion is unchanged and authoritative.