PR Gates / CI image pin matches docker/ci (pull_request) Successful in 11s
PR Gates / Docs update reminder (pull_request) Successful in 16s
PR Gates / decisions lifecycle (pull_request) Failing after 23s
Build ErsatzTV Image / Formatting (changed .cs conform to .editorconfig) (pull_request) Successful in 1m17s
Build ErsatzTV Image / API docs in sync (OpenAPI + endpoint index) (pull_request) Successful in 1m29s
Build ErsatzTV Image / Build & test (.NET) (pull_request) Successful in 8m5s
Build ErsatzTV Image / EF migration integrity (SQLite + MySql) (pull_request) Successful in 16m5s
Build ErsatzTV Image / Functional E2E (curl + UI contracts) (pull_request) Successful in 17m6s
Build ErsatzTV Image / Build & push image (amd64) (pull_request) Has been skipped
168 records -> docs/decisions/records/<area>/<topic>.md (163 active, 23 dirs) and docs/decisions/archive/<area>/<topic>.md (5 archived). The filename IS the key, so one-active-record-per-key becomes a filesystem property rather than a validator check, and supersession becomes a `git mv`. WHY: the monolith was a concurrency problem before an aesthetic one. A 3,900-line append target made parallel sessions collide -- PR #605 and PR #614 both hit append-vs-append conflicts during routine rebases, and hand-resolving those inside the corpus is exactly the operation the rationale-rewrite guard exists to police. HOW IT IS VERIFIED: a ~170-file diff cannot be meaningfully read, so correctness does not rest on reading it. The parser was taught BOTH formats first, so the body-diff guard parses the old form at the merge-base and the new form at head -- the migration validates itself, no bypass. The proof is a field-level equivalence harness: 168 records before and after, zero lost, zero gained, zero field mismatches, zero rationale bodies differing. Reviewers should scrutinise the harness; it is the actual evidence. What measuring caught that reading would not have: - ~500 lines sit OUTSIDE any record -- decisions.md's lifecycle schema and each topic file's preamble, mostly the only copy. Source files are kept and stripped, never deleted. They also cannot be filed per-area: topic files hold several areas and 4 of 23 areas span several files. - Archive discovery was a non-recursive glob; after the split it found ZERO archived records, surfacing as four bogus "supersedes points to unknown key" errors rather than an obvious failure. - ~32 live docs point into the corpus BY DATE, which the split dangles. Each stripped file now ends with a generated "Records formerly in this file" index, which also rescues the identical breadcrumbs in old issue comments. - decisions.md's "In this file:" list was 97 same-file anchor bullets that the split makes WRONG, not merely stale. Dropped; the generated index replaces them with links that resolve. The equivalence harness now runs against a checked-in FIXTURE, not the live corpus. The earlier version migrated the real tree, which made it a one-shot: the moment the migration landed there was nothing left to move and the tests failed for reasons unrelated to the code. A fixture keeps them testing the SCRIPT rather than the repo's current state. Keys preserved verbatim, warts included: `sched` (12) and `scheduling` (1) remain two directories for one concept. Renaming a key is not a move -- it changes identity, breaks the equivalence proof, and invalidates MemPalace's per-key drawers. Taxonomy normalisation is separate work. refs #610
4.3 KiB
4.3 KiB
key, title, status, since, supersedes, superseded-by, rule, signals, mechanics
| key | title | status | since | supersedes | superseded-by | rule | signals | mechanics |
|---|---|---|---|---|---|---|---|---|
| sched.weightedshuffle-editor | 2026-07-19 — WeightedShuffle SPA: weights edited on the multi-collection, order offered only on classic MultiCollection schedule items; fair-share is a reset not a mode (#404) | active | 2026-07-19 | none | none | WeightedShuffle per-source weights are edited on the multi-collection editor (property of the MultiCollection), while the WeightedShuffle order itself is offered only on classic MultiCollection schedule items; fair-share is a "reset weights to 1" action, not a stored mode. | WeightedShuffle SPA, multi-collection weights, fair-share reset · paths: `web/src/.../itemRules.ts` `MULTI_COLLECTION_ORDERS`, `itemsFromMultiCollection`/`toItemRequest` · issues: #404, #70, #402 | spa-conventions.md §4 (replace-all-DTO trap); `fillWithGroupModeEligible` exclusion |
The UI half of #70 (backend + API shipped in PR #402). No new endpoint or DTO — weight was already on
MultiCollectionItemRequest/…ResponseModel and WeightedShuffle already in the PlaybackOrder enum; this
is purely SPA (+ docs).
- Two surfaces, split by where each datum lives. The per-source weights are a property of the
MultiCollection, so they are edited in the multi-collection editor (/app/multi-collections), not on the schedule item. The order (WeightedShuffle) is a property of the schedule item, so it is added to the classic schedule item's Playback Order options. Putting weights on the schedule item was rejected: the same multi-collection can be referenced by many schedule items, and weights are shared, not per-reference. WeightedShuffleis offered ONLY forcollectionType === 'MultiCollection'(itemRules.tsMULTI_COLLECTION_ORDERS) — a meaningfulness scope, not a rejection mirror. Weights only exist on multi-collection members, so the order only does something with 2+ weighted sources; on a single collection the classic engine still accepts it (verified by live-E2E:PUT /schedules/{id}/itemswith a plain Collection +WeightedShuffle→ 200) but it degrades to fair-share (≈Shuffle), a confusing no-op — so the SPA doesn't offer it there. The rejection the #70 entry describes is on the separate playlist and block write paths (different engines); the playlist/block editors keep their own order lists (notMULTI_COLLECTION_ORDERS) and already omitWeightedShuffle, so nothing extra was needed there.WeightedShufflejoinsShuffleInOrderin thefillWithGroupexclusion.fillWithGroupModeEligiblealready excludedShuffleInOrder; WeightedShuffle is excluded for the same structural reason —PlayoutBuildersplits a fill-with-group item into per-group enumerators scheduled one group at a time, which is incompatible with WeightedShuffle's whole-multi-collection per-source share of airtime. Offering the combination would silently not do what the name says.- Fair-share is a "Reset to fair share" button, not a stateful toggle. decisions.md 2026-07-17 established
that fair-share is not a separate mode — it is
WeightedShufflewith all weights left at the default 1. So there is nothing to toggle on: the button just sets every source's weight to 1 (disabled when already there). A persistent toggle was rejected because "fair share" has no stored representation distinct from "the weights all happen to be 1". - Weights round-trip through the editor draft or they silently reset. The multi-collection PUT replaces
the whole item list, so
weightis read initemsFromMultiCollectionand written intoItemRequest; dropping it would reset every source to 1 on the next unrelated save (rename, add a source). Covered by a round-trip test. This is the general replace-all-DTO trap now recorded inspa-conventions.md§4. - Percentages are display-only; the wire format is the integer weight. A 3:1 weight shows as 75% / 25%,
computed from the clamped weights; the request always carries the integer relative share (1..1000). The
weight field is held as a string in the editor draft so it edits smoothly, clamped to the API validator's
1..1000 on blur and again at save — an out-of-range value never reaches the server as a raw 400.
Inputgainedmin/max/inputMode/onBlurpassthroughs for this (reusable by #425's weight UI).