timothy
fba5233caf
PR Gates / CI image pin matches docker/ci (pull_request) Successful in 11s
PR Gates / Docs update reminder (pull_request) Successful in 16s
PR Gates / decisions lifecycle (pull_request) Failing after 23s
Build ErsatzTV Image / Formatting (changed .cs conform to .editorconfig) (pull_request) Successful in 1m17s
Build ErsatzTV Image / API docs in sync (OpenAPI + endpoint index) (pull_request) Successful in 1m29s
Build ErsatzTV Image / Build & test (.NET) (pull_request) Successful in 8m5s
Build ErsatzTV Image / EF migration integrity (SQLite + MySql) (pull_request) Successful in 16m5s
Build ErsatzTV Image / Functional E2E (curl + UI contracts) (pull_request) Successful in 17m6s
Build ErsatzTV Image / Build & push image (amd64) (pull_request) Has been skipped
168 records -> docs/decisions/records/<area>/<topic>.md (163 active, 23 dirs) and docs/decisions/archive/<area>/<topic>.md (5 archived). The filename IS the key, so one-active-record-per-key becomes a filesystem property rather than a validator check, and supersession becomes a `git mv`. WHY: the monolith was a concurrency problem before an aesthetic one. A 3,900-line append target made parallel sessions collide -- PR #605 and PR #614 both hit append-vs-append conflicts during routine rebases, and hand-resolving those inside the corpus is exactly the operation the rationale-rewrite guard exists to police. HOW IT IS VERIFIED: a ~170-file diff cannot be meaningfully read, so correctness does not rest on reading it. The parser was taught BOTH formats first, so the body-diff guard parses the old form at the merge-base and the new form at head -- the migration validates itself, no bypass. The proof is a field-level equivalence harness: 168 records before and after, zero lost, zero gained, zero field mismatches, zero rationale bodies differing. Reviewers should scrutinise the harness; it is the actual evidence. What measuring caught that reading would not have: - ~500 lines sit OUTSIDE any record -- decisions.md's lifecycle schema and each topic file's preamble, mostly the only copy. Source files are kept and stripped, never deleted. They also cannot be filed per-area: topic files hold several areas and 4 of 23 areas span several files. - Archive discovery was a non-recursive glob; after the split it found ZERO archived records, surfacing as four bogus "supersedes points to unknown key" errors rather than an obvious failure. - ~32 live docs point into the corpus BY DATE, which the split dangles. Each stripped file now ends with a generated "Records formerly in this file" index, which also rescues the identical breadcrumbs in old issue comments. - decisions.md's "In this file:" list was 97 same-file anchor bullets that the split makes WRONG, not merely stale. Dropped; the generated index replaces them with links that resolve. The equivalence harness now runs against a checked-in FIXTURE, not the live corpus. The earlier version migrated the real tree, which made it a one-shot: the moment the migration landed there was nothing left to move and the tests failed for reasons unrelated to the code. A fixture keeps them testing the SCRIPT rather than the repo's current state. Keys preserved verbatim, warts included: `sched` (12) and `scheduling` (1) remain two directories for one concept. Renaming a key is not a move -- it changes identity, breaks the equivalence proof, and invalidates MemPalace's per-key drawers. Taxonomy normalisation is separate work. refs #610
3.0 KiB
3.0 KiB
key, title, status, since, supersedes, superseded-by, rule, signals, mechanics
| key | title | status | since | supersedes | superseded-by | rule | signals | mechanics |
|---|---|---|---|---|---|---|---|---|
| spa.sidebar-collapsible-accordions | 2026-07-18 — Collapsible sidebar + nav-group accordions: two `ctv-sidebar-*` localStorage keys, labeled groups default-collapsed (#396) | active | 2026-07-18 | none | none | The shell sidebar's collapse + nav-group-accordion state persists under two hyphenated `ctv-sidebar-*` localStorage keys (matching the repo's `ctv-` convention, not the prototype's dotted names); labeled groups default-collapsed. | sidebar, collapsible nav groups, localStorage keys · paths: `web/src/app/AppShell.tsx`, `web/src/app/sidebarState.ts` · issues: #396 | spa-conventions.md §5d; `ctv-sidebar-collapsed` / `ctv-sidebar-groups` keys |
The shell sidebar (web/src/app/AppShell.tsx) gained (a) a header toggle that collapses it to a 60px
icon rail and (b) collapsible accordions per labeled nav group (Media, System); the unlabeled
Primary group is always open. Mirrors the Claude Design prototype's updated Sidebar.
- State lives in a small hook, not App.
web/src/app/sidebarState.tsuseSidebarState()owns both pieces of state + persistence;AppShellconsumes it (nothing else needs it) and stampsctv-app-shell-collapsedon the shell root so the collapse is CSS-driven from one class. - Persistence keys use the established
ctv-hyphen convention, NOT the prototype's dotted names. The issue quotedctv.sidebar.collapsed/ctv.sidebar.groups, but every existing client-local pref is hyphenated (ctv-theme,ctv-logs-page-size— spa-conventions §5d), so we usectv-sidebar-collapsed("1"/"0") andctv-sidebar-groups(JSON{groupKey: boolean}, boolean = collapsed). Deliberate deviation from the issue's literal key text in favour of the repo convention the issue itself points to; helpers validate/parse defensively (bad JSON / non-boolean values → default). - Labeled groups default to COLLAPSED (absent
ctv-sidebar-groupsentry ⇒ collapsed), so a fresh load shows only Primary — matching the prototype ("default-collapsed, leaving only Primary visible"). A behavior change for existing users;App.test.tsx's shell/nav suite seeds the two groups open because it clicks Media/System nav links directly (the accordion behavior is covered in its own describe). - Accordions apply only in the expanded sidebar. In the rail, group-collapse is ignored — every
item renders as an icon (label kept in the a11y tree via an sr-only span so the accessible name/tests
survive; surfaced as a native
titletooltip), groups separated by a hairline divider, numeric badges shown as a corner dot. The active-route indicator (left rail bar + active background) works in both states. - Group keys are explicit + stable (
SidebarNavGroupDefinition.key:'media','system') rather than derived from the label, so renaming a label doesn't silently orphan persisted state. - No route/screen was added or redirected (shell-chrome only), so no
blazor-route-parity.mdchange.