Files
ersatztv/web
timothy 366e9e9571 fix(819): state the wiring residual honestly, and correct the checkout/binary claim
Round 9 found no blocker and no HIGH. These are its mechanical findings, plus one
correction to the fix it proposed.

The proposed fix for its MEDIUM did NOT work, and I measured it rather than
taking it. Round 9 suggested two assertions to pin the population WIRING —
`TRACKED_SOURCE_PATHS` equals `trackedSources.tracked`, and `listSourceFiles()`
equals `listSourceFilesFrom(rawSourceModules, TRACKED_SOURCE_PATHS)` — reported
as reddening the two survivors. Written and measured: both mutations stayed green
with those assertions in place (44/44). The reason is structural. On a clean
checkout the walk set and the index set ARE the same set — every tracked file is
on disk, nothing untracked exists — so no comparison between the two populations
can tell which one is wired in. It is observable only on a tree that HAS an
untracked source file, which is precisely the tree CI never checks out.

So it is recorded as residual (4) with its measurement and its DIRECTION, rather
than papered over with an assertion that cannot fail. Direction is what makes it
a residual and not a defect: reverting the wiring is fail-NOISY — it reddens a
developer's checkout that has a scratch file, the original #819 complaint — and
cannot hide a call site from the registry. Every blind direction runs through the
population SOURCE, and those are pinned by the cross-check.

Also from round 9:
- The checkout-vs-binary distinction was stated as an either/or in
  `docs/testing.md` and the Dockerfile. MEASURED: with `.git` PRESENT and git off
  `PATH`, the guard still fails — it needs both. As written it would license a
  future "just `COPY .git` and re-enable it", which is round 8's blocker in
  reverse. Both now say so explicitly.
- `docs/guard-inventory.md` claimed the partition residual is "checked only by
  the plugin's own real-git tests". They catch an unconditional mispartition, not
  one keyed on a path pattern. Corrected, and the wiring residual added beside it.
- The file split left two comments pointing at the file the real-git tests are no
  longer in, and one saying "every test above" where there is now nothing above.
- A drifting "1259 tests" figure — the class this PR already swept out once.
- The TS/C#-guards scope item had grown into "A, B and C and D and its sibling"
  across four over-long lines; rewritten as a four-item list.

Rebased onto b6b3520bd (#874).

Refs: #819
2026-08-29 05:22:33 +02:00
..
2026-07-07 10:05:39 +02:00
2026-07-02 18:36:56 +02:00
2026-07-07 10:05:39 +02:00