Build ErsatzTV Image / Docs update reminder (pull_request) Successful in 6s
Build ErsatzTV Image / EF migration integrity (SQLite + MySql) (pull_request) Successful in 4m22s
Build ErsatzTV Image / Build & test (.NET) (pull_request) Successful in 5m17s
Build ErsatzTV Image / Build & push image (amd64) (pull_request) Has been skipped
Independent review (cold fork = MERGEABLE-WITH-NITS; Codex = BLOCKED, caught concurrency defects the fork missed). All actionable findings folded in: - HIGH (Codex) atomic first-claim-wins: ClaimLocalAdmin now writes the three credential rows in ONE transaction guarded by the unique ConfigElement.Key index (lost race -> DbUpdateException -> 409), so concurrent claims can't produce a mixed-state credential. - HIGH (Codex) consistent login snapshot: VerifyLocalAdminLogin reads hash+stamp in one query and drops rehash-on-verify, so a login racing a password change can't capture a stamp newer than the hash it verified (concurrent change -> old password fails, or the issued cookie carries the pre-change stamp -> revoked next request). - MEDIUM (Codex) env-seed migration race: LocalAdminSeedService is now a RunOnce BackgroundService that awaits SystemStartup.WaitForDatabase (the migrator is a BackgroundService; registration order didn't guarantee the schema) + try/catch. - MEDIUM (fork M1) ForwardedHeaders: reverted the strict-opt-in flip — it would regress /iptv M3U/XMLTV/HLS absolute-URL generation (Request.Scheme) behind a proxy without KnownProxies. Kept #285 behavior; KnownProxies still recommended. - LOW (Codex/fork) require X-CSRF on /api/auth/logout + /password (the [SkipApiAuthorization] surface isn't covered by the filter's CSRF check; closes forced-logout CSRF). - ChangeLocalAdminPassword also writes hash+stamp atomically. Input length caps on username/password. Deferred with a tracked gate: MEDIUM (Codex) side-effecting [RequiresAuthentication] GETs (troubleshoot playback/archive) aren't CSRF-covered -> #301, gates PR2 (latent in PR1: the SPA still uses the machine key). Verify: full ErsatzTV.Tests green (1501); no OpenAPI/generated drift. Docs updated (api-conventions §9, decisions.md). Refs #295 #301 Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
50 lines
1.7 KiB
C#
50 lines
1.7 KiB
C#
using System.Security.Cryptography;
|
|
using ErsatzTV.Core;
|
|
|
|
namespace ErsatzTV.Application.Auth;
|
|
|
|
internal static class LocalAdminHelpers
|
|
{
|
|
public const int MaxUsernameLength = 256;
|
|
|
|
// Upper bound so an absurdly long password can't burn CPU in PBKDF2 (the request body is also capped
|
|
// by Kestrel, #283; this is defense-in-depth on the field itself).
|
|
public const int MaxPasswordLength = 1024;
|
|
|
|
/// <summary>128 bits of random, lowercase hex. Rotated on every password change to revoke sessions.</summary>
|
|
public static string NewSecurityStamp() =>
|
|
Convert.ToHexString(RandomNumberGenerator.GetBytes(16)).ToLowerInvariant();
|
|
|
|
/// <summary>Validates a new username + password. Returns the error, or None if valid.</summary>
|
|
public static Option<BaseError> ValidateNewCredentials(string username, string password)
|
|
{
|
|
string trimmed = (username ?? string.Empty).Trim();
|
|
if (trimmed.Length == 0)
|
|
{
|
|
return BaseError.New("Username is required");
|
|
}
|
|
|
|
if (trimmed.Length > MaxUsernameLength)
|
|
{
|
|
return BaseError.New("Username is too long");
|
|
}
|
|
|
|
return ValidatePassword(password);
|
|
}
|
|
|
|
public static Option<BaseError> ValidatePassword(string password)
|
|
{
|
|
if (string.IsNullOrEmpty(password) || password.Length < AuthConstants.MinPasswordLength)
|
|
{
|
|
return BaseError.New($"Password must be at least {AuthConstants.MinPasswordLength} characters");
|
|
}
|
|
|
|
if (password.Length > MaxPasswordLength)
|
|
{
|
|
return BaseError.New($"Password must be at most {MaxPasswordLength} characters");
|
|
}
|
|
|
|
return Option<BaseError>.None;
|
|
}
|
|
}
|