Sixth review round. Every finding from round five verified FIXED — including a
negative control on the `.spec.ts` bypass, which is the part that matters: with the
new clause reverted and the fixture present, the guard goes green with the real
builder unprotected, so the clause is load-bearing rather than decorative. Two new
MEDIUMs, both introduced by that fix, both measured by execution.
N1. The intersection throw carried a comment saying `allOf` was "the ONE non-object
shape that can HIDE members rather than having none". Review measured that false
against the real scanner: a union of refs, a union of object literals, a `$ref`
alias and an array each hid members too. None is hypothetical —
`generateTypes` emits a union for `oneOf`/`anyOf` AND for a plain nullable object
(`type: ["object","null"]`), so a request schema modelled that way would leave the
droppable population silently.
A universal negative in a comment is the exact shape this record is about, so the
fix is not a longer list of shapes to reject. The test is now POSITIVE: a schema
type is either something the scanner can enumerate (an object literal) or something
it has SHOWN carries nothing (`isEnumShaped` — a literal, a union of literals, a
bare keyword — a property checked rather than asserted). Everything else throws.
All five shapes are pinned as fixtures, the four enum-shaped ones too. Confirmed
against the real `v1.d.ts`: 220 object literals, 54 enum-shaped, zero throws.
N2. `isProductionSource` hardcodes `'src/setupTests.ts'`, mirroring `vite.config.ts`'s
`setupFiles` with nothing coupling them — a hand-written mirror of an authoritative
source, reintroduced inside the fix for a hand-written mirror. Renaming the setup
file would leave the exclusion stale while vitest kept loading the new one, and the
round-5 bypass would reopen with the suite green. The path is now pinned, so that
staleness is a red rather than a silence.
Two doc corrections from the same round: the guard-inventory splice had attached
"claims no standing MUTATION grade" to the plugin-residual sentence instead of to
the hand-run-mutations one that explains it, and the row omitted the 0.95 ratio
floor when describing what catches a scope edit. The record's frontmatter said the
guard requires an annotation for "each schema that can drop a member" — it requires
one for each schema DISPOSITIONED as needing it, three of the thirteen. §4b had it
right; the frontmatter is the copy that gets mirrored out of context, so it is the
one that had to be exact.
Verified: web 1318 tests green, scripts/tests 1241 green (2 skipped), typecheck +
eslint + ruff clean, decisions-validate OK, inventory counts machine-checked.
Decisions-Edit: yes
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01UYNbVwgVszv6Pum7ZuGd75