Build ErsatzTV Image / CI toolchain image resolves (pull_request) Successful in 7s
PR Gates / CI image pin matches docker/ci (pull_request) Successful in 12s
Build ErsatzTV Image / Delimiter ban (release path) (pull_request) Successful in 19s
review-verdict/h10 Review-verdict: MERGEABLE @ 5459e21 (base: main)
PR Gates / decisions lifecycle (pull_request) Successful in 18s
PR Gates / Docs update reminder (pull_request) Successful in 25s
PR Gates / Fix proofs (Proves trailers) (pull_request) Successful in 27s
Review verdict / Set review-verdict status (pull_request_target) Successful in 12s
PR Gates / Script lint and tests (ruff + pytest) (pull_request) Successful in 5m7s
Build ErsatzTV Image / Build & test (.NET) (pull_request) Successful in 8m50s
Build ErsatzTV Image / EF migration integrity (SQLite + MySql) (pull_request) Successful in 6m9s
Build ErsatzTV Image / Build & push image (amd64) (pull_request) Skipped
Build ErsatzTV Image / Functional E2E (curl + UI contracts) (pull_request) Successful in 5m50s
Build ErsatzTV Image / API docs in sync (OpenAPI + endpoint index) (pull_request) Successful in 5m11s
Build ErsatzTV Image / Formatting (changed .cs conform to .editorconfig) (pull_request) Successful in 8s
The write path used to accept an out-of-range `qsvExtraHardwareFrames`, store the floored value instead and return 200 — the accepted residual #529 recorded, where a client PUTs 0 and reads back 64. `FFmpegProfileBounds` now rejects a newly submitted out-of-range value with a 422 naming the bound and its consequence; the render-time floor in `FFmpegState` stays, which is what keeps the change migration-free for rows written before this existed. On update an UNCHANGED legacy value is still accepted, because the SPA round-trips the whole profile and rejecting it would make an old profile uneditable over a field the operator never touched and, outside QSV, cannot see. The `-readrate` / `-readrate_catchup` pacing that `PipelineBuilderBase` hardcoded becomes two nullable profile fields with the same bounded treatment. During #726 the only way to try a different pacing value was to rebuild the app and replay command lines by hand on the Docker host. `null` means unset and resolves to the values the pipeline used before, so an untouched profile paces identically; catchup stays on by default and capability-gated in code. The draft helpers moved out of `FFmpegProfilesScreen.tsx` into `ffmpegProfileDraft.ts` so the bounds can be tested directly — a component module that exports non-components trips react-refresh, and the baseline was warning-free. Mutation-checked: ignoring the pacing override, disarming each bound, and removing the unchanged-legacy exemption each redden their own tests. fixes #735 Decisions-Edit: yes Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
137 lines
6.1 KiB
C#
137 lines
6.1 KiB
C#
using ErsatzTV.Core;
|
|
using ErsatzTV.Core.Domain;
|
|
using ErsatzTV.Core.Errors;
|
|
using ErsatzTV.Core.Interfaces.Search;
|
|
using ErsatzTV.FFmpeg;
|
|
using ErsatzTV.Infrastructure.Data;
|
|
using ErsatzTV.Infrastructure.Extensions;
|
|
using Microsoft.EntityFrameworkCore;
|
|
|
|
namespace ErsatzTV.Application.FFmpegProfiles;
|
|
|
|
public class CreateFFmpegProfileHandler :
|
|
IRequestHandler<CreateFFmpegProfile, Either<BaseError, CreateFFmpegProfileResult>>
|
|
{
|
|
private readonly IDbContextFactory<TvContext> _dbContextFactory;
|
|
private readonly ISearchTargets _searchTargets;
|
|
|
|
public CreateFFmpegProfileHandler(IDbContextFactory<TvContext> dbContextFactory, ISearchTargets searchTargets)
|
|
{
|
|
_dbContextFactory = dbContextFactory;
|
|
_searchTargets = searchTargets;
|
|
}
|
|
|
|
public async Task<Either<BaseError, CreateFFmpegProfileResult>> Handle(
|
|
CreateFFmpegProfile request,
|
|
CancellationToken cancellationToken)
|
|
{
|
|
await using TvContext dbContext = await _dbContextFactory.CreateDbContextAsync(cancellationToken);
|
|
Option<int> maybeResolutionId = await ResolutionMustExist(dbContext, request, cancellationToken);
|
|
return await maybeResolutionId.Match(
|
|
Some: async resolutionId =>
|
|
{
|
|
Validation<BaseError, FFmpegProfile> validation = Validate(request, resolutionId);
|
|
return await validation.Apply(profile => PersistFFmpegProfile(dbContext, profile));
|
|
},
|
|
None: () => Task.FromResult<Either<BaseError, CreateFFmpegProfileResult>>(
|
|
new NotFoundError($"[Resolution] {request.ResolutionId} does not exist")));
|
|
}
|
|
|
|
private async Task<CreateFFmpegProfileResult> PersistFFmpegProfile(
|
|
TvContext dbContext,
|
|
FFmpegProfile ffmpegProfile)
|
|
{
|
|
await dbContext.FFmpegProfiles.AddAsync(ffmpegProfile);
|
|
await dbContext.SaveChangesAsync();
|
|
_searchTargets.SearchTargetsChanged();
|
|
return new CreateFFmpegProfileResult(ffmpegProfile.Id);
|
|
}
|
|
|
|
private static Validation<BaseError, FFmpegProfile> Validate(
|
|
CreateFFmpegProfile request,
|
|
int resolutionId) =>
|
|
(ValidateName(request),
|
|
ValidateThreadCount(request),
|
|
FFmpegProfileBounds.ValidateQsvExtraHardwareFrames(request.QsvExtraHardwareFrames, stored: null),
|
|
FFmpegProfileBounds.ValidateReadRate(request.ReadRate),
|
|
FFmpegProfileBounds.ValidateReadRateCatchup(request.ReadRateCatchup, request.ReadRate))
|
|
.Apply((name, threadCount, _, _, _) =>
|
|
{
|
|
var hwAccel = request.NormalizeVideo
|
|
? request.HardwareAcceleration
|
|
: HardwareAccelerationKind.None;
|
|
|
|
return new FFmpegProfile
|
|
{
|
|
Name = name,
|
|
ThreadCount = threadCount,
|
|
|
|
NormalizeAudio = request.NormalizeAudio,
|
|
NormalizeVideo = request.NormalizeVideo,
|
|
|
|
HardwareAcceleration = hwAccel,
|
|
VaapiDriver = request.VaapiDriver,
|
|
VaapiDevice = request.VaapiDevice,
|
|
// stored exactly as submitted: an out-of-range value was already rejected with a
|
|
// 422 naming the bound, so there is nothing left to silently rewrite (ersatztv#735)
|
|
QsvExtraHardwareFrames = request.QsvExtraHardwareFrames,
|
|
ResolutionId = resolutionId,
|
|
ScalingBehavior = request.ScalingBehavior,
|
|
|
|
// only allow customization with VAAPI accel
|
|
PadMode = hwAccel switch
|
|
{
|
|
HardwareAccelerationKind.None => FilterMode.Software,
|
|
HardwareAccelerationKind.Vaapi => request.PadMode,
|
|
_ => FilterMode.HardwareIfPossible
|
|
},
|
|
|
|
VideoFormat = request.NormalizeVideo ? request.VideoFormat : FFmpegProfileVideoFormat.Copy,
|
|
VideoProfile = request.VideoProfile,
|
|
VideoPreset = request.VideoPreset,
|
|
AllowBFrames = request.AllowBFrames,
|
|
|
|
// mpeg2video only supports 8-bit content
|
|
BitDepth = request.VideoFormat is FFmpegProfileVideoFormat.Mpeg2Video
|
|
? FFmpegProfileBitDepth.EightBit
|
|
: request.BitDepth,
|
|
|
|
VideoBitrate = request.VideoBitrate,
|
|
VideoBufferSize = request.VideoBufferSize,
|
|
TonemapAlgorithm = request.TonemapAlgorithm,
|
|
AudioFormat = request.NormalizeAudio ? request.AudioFormat : FFmpegProfileAudioFormat.Copy,
|
|
AudioBitrate = request.AudioBitrate,
|
|
AudioBufferSize = request.AudioBufferSize,
|
|
|
|
NormalizeLoudnessMode = request.NormalizeLoudnessMode,
|
|
TargetLoudness = request.NormalizeLoudnessMode is NormalizeLoudnessMode.LoudNorm
|
|
? request.TargetLoudness
|
|
: null,
|
|
|
|
AudioChannels = request.AudioChannels,
|
|
AudioSampleRate = request.AudioSampleRate,
|
|
NormalizeFramerate = request.NormalizeFramerate,
|
|
NormalizeColors = request.NormalizeColors,
|
|
DeinterlaceVideo = request.DeinterlaceVideo,
|
|
QsvPreferNativeDecoder = request.QsvPreferNativeDecoder,
|
|
ReadRate = request.ReadRate,
|
|
ReadRateCatchup = request.ReadRateCatchup
|
|
};
|
|
});
|
|
|
|
private static Validation<BaseError, string> ValidateName(CreateFFmpegProfile createFFmpegProfile) =>
|
|
createFFmpegProfile.NotEmpty(x => x.Name)
|
|
.Bind(_ => createFFmpegProfile.NotLongerThan(50)(x => x.Name));
|
|
|
|
private static Validation<BaseError, int> ValidateThreadCount(CreateFFmpegProfile createFFmpegProfile) =>
|
|
createFFmpegProfile.AtLeast(0)(p => p.ThreadCount);
|
|
|
|
private static Task<Option<int>> ResolutionMustExist(
|
|
TvContext dbContext,
|
|
CreateFFmpegProfile createFFmpegProfile,
|
|
CancellationToken cancellationToken) =>
|
|
dbContext.Resolutions
|
|
.SelectOneAsync(r => r.Id, r => r.Id == createFFmpegProfile.ResolutionId, cancellationToken)
|
|
.MapT(r => r.Id);
|
|
}
|